Race condition on libjuice agent destruction about libdatachannel HOT 7 CLOSED

Oh i thought it was precisely the case that was fixed by this :D anyway thank you

from libdatachannel.

Looks like this happens when recvfrom fails inside agent_run, making it exit the loop and destroy the agent

from libdatachannel.

Good catch, it seems that it's not even a race condition, I actually forgot the test in libjuice when the thread terminates to destroy the agent only if its destruction has been requested. For some reason the connectivity test doesn't crash.

from libdatachannel.

Maybe you also need to release the agent mutex?

from libdatachannel.

i ended up doing this to fix it:

if (len < 0) {
	JLOG_ERROR("recvfrom failed, errno=%d", sockerrno);
	agent->thread_started = false;
	pthread_mutex_unlock(&agent->mutex);
	agent_change_state(agent, JUICE_STATE_DISCONNECTED);
	return;
	//break;
}

from libdatachannel.

Maybe you also need to release the agent mutex?

Oh, yes indeed. Your solution works except in the edge case where destruction is requested, and at the same moment recvfrom fails.

from libdatachannel.

FYI, I took the opportunity to add a proper thread interruption mechanism to libjuice, which allows to join the thread on destruction: paullouisageneau/libjuice@dd3a537

from libdatachannel.