Source directory requires read/write filesystem during build about libdatachannel HOT 3 CLOSED

1. instead of having a header file with the 4 defines, the defines could be added using cmake's add_definitions (or the newer alternatives)

This is not a solution because definitions won't be written in headers so they won't be there when a program includes them after building and installing.

2. A folder in the output directory could be setup and added to the includes, then the configure_file command could place the output there

This is typical for a CMake build but libdatachannel also supports alternative build systems (Makefile and Jamfile), which would be broken due to the missing header.

Generating the version.h header was added by @Sean-Der in #1112 only to synchronize the CMake version and the version in header:

I think a simple way to fix your issue is to introduce a CMake option, let's say RTC_UPDATE_VERSION_HEADER, defaulting to OFF, and condition the version file configuration with it. It would be enabled in check-version.yml with -DRTC_UPDATE_VERSION_HEADER=1. What do you think?

from libdatachannel.

yeah that would also work for me, sure

from libdatachannel.

@paullouisageneau I submitted #1231

from libdatachannel.