WebSocketServer not stopping properly about libdatachannel HOT 2 CLOSED

Thank you for reporting. This is expected as the current design mimics TCP sockets: closing the server stops listening for new connections but doesn't close existing ones.

libdatachannel/src/impl/websocketserver.cpp

Line 75 in 55e5b57

while (auto incoming = tcpServer->accept()) {

Do we need to check mStopped flag here?

As you can see in the log, the server thread itself goes out of the listening loop and stops. The server itself is closed as expected.

Do we need to keep client list and close all on stop function?

You can indeed keep a list of clients and close them when you close the server. This could be done inside the library, but some people might rely on the current behavior (for instance you might what to change certificates without closing connections).

from libdatachannel.

Ok then I will implement in node-data channel
Thanks

from libdatachannel.