Code Monkey home page Code Monkey logo

Comments (3)

paullouisageneau avatar paullouisageneau commented on July 26, 2024 3

This is indeed an incorrect implementation in libdatachannel. The issue is with tracking the negotiation needed state: currently, it is too simplistic, the library sets a flag when adding a track and clears it when setLocalDescription() is called. As a result, when concurrent events happen, a track may be left non-negotiated, but the library forgets negotiation is needed. I'm looking into it.

from libdatachannel.

paullouisageneau avatar paullouisageneau commented on July 26, 2024 1

@daweifeng The specification forbids adding new tracks in answers, you can only add new tracks in offers. You may however modify offered tracks in the onTrack() callback before answering.

from libdatachannel.

daweifeng avatar daweifeng commented on July 26, 2024

How about invoking addTrack() when peer B receives an offer from peer A? Should we add track after calling setRemoteDescription() and before setLocalDescription() ? This is for a scenario that peer B might want to open a track that has a different name from the one open by A.

from libdatachannel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.