Gulp support about patternlab-node HOT 17 CLOSED

I've started on this here: https://github.com/oscar-g/patternlab-node/tree/dev-gulp
I'm almost done...There is still jshint, watch, and sass tasks to configure.

from patternlab-node.

That's great @oscar-g. Feel free to ping whenever you need testers to generate with it.

from patternlab-node.

@oscar-g this is great! I am excited to dig in and learn more about gulp soon. Thank you so much for taking the reins on this. I'd love to see the pl-node repo structured in such a way that it supports node,grunt and gulp versions.

Any thoughts?

from patternlab-node.

@bmuenzenmeyer, might be useful to pull in a library like https://github.com/chjj/blessed to let people configure for vanilla, grunt, or gulp and then add the processes in / node modules based on the selection. http://yeoman.io would be another option to allow people to select their preference when they build out the project.

from patternlab-node.

@yuvilio - You're welcome, I'll be working on it today.

@bmuenzenmeyer - Another way of doing that would be with a Yeoman generator. For example, check out Keystone JS, and it's Yeoman generator: https://github.com/keystonejs/generator-keystone. That generator let's you choose different build step systems and template engines for their CMS app.

@ivanmayes - I've never seen that library, I'll check it out!

edit:
Okay, it's ready! The task names and their structures are a bit different than the grunt version, but it's still pretty simple. I'm thinking that if we end up using yeoman, or something similar, we may have to move some tasks from gulpfile.js to builder/gulp-patternlab.js.

from patternlab-node.

Has anybody gotten the chance to work with the gulp branch in their specific environment?

• Thanks!

from patternlab-node.

We have a project coming up that we will be trying to integrate the gulp version into in the next month. Our boilerplate has the vanilla version at the moment, but the rest of our boilerplate uses gulp.

from patternlab-node.

Hi @oscar-g and all,

I briefly looked at this the other day but did not run it.

I think in the short term I would accept some pull requests into the dev branch, and then would address the grunt/gulp/vanilla versions in the readme.

In the midterm, I would break out the versions into specifc repos that reference the pure node version, similar to https://github.com/kangax/html-minifier.

The final step(s) then would be npm/bower/yeoman etc.

Does this make sense? Looking for some feedback on how best to structure the project to be clear, maintainable, and approachable to newcomers and veterans alike.

Thanks for the continued support - I have some things to finish up this month but then plan on further development.

from patternlab-node.

I haven't heard any response to my above comment - but have added some notes to the readme to address the gulp version.

from patternlab-node.

Moving this old comment to the description

from patternlab-node.

@bmuenzenmeyer, sorry for the lack of communication...I've been terribly busy on my end.

I'm willing to put some more work into the gulpfile and the docs.

Are we still thinking about supporting all grunt, gulp, and vanilla versions?

Also, what is the reasoning behind the first point in your list, above ("Update gulpfile to omit scss where possible as a default")?

Thanks

from patternlab-node.

I should have been more clear- this list is for me. The work is done but I
need to document it. I am not a Gulp expert, if I pushed it to a branch
would you please review it?
On Wed, Sep 16, 2015 at 10:03 AM Oscar G [email protected] wrote:

@bmuenzenmeyer https://github.com/bmuenzenmeyer, sorry for the lack of
communication...I've been terribly busy on my end.

I'm willing to put some more work into the gulpfile and the docs.

Are we still thinking about supporting all grunt, gulp, and vanilla
versions?

Also, what is the reasoning behind the first point in your list, above
("Update gulpfile to omit scss where possible as a default")?

Thanks

—
Reply to this email directly or view it on GitHub
#57 (comment)
.

from patternlab-node.

At a computer, so I can answer more fully.

Are we still thinking about supporting all grunt, gulp, and vanilla versions?

Yes. My current plan is to keep this all in the same repository, and just document the (in my eyes) simple means to switch out the node_modules and package.json file.

Also, what is the reasoning behind the first point in your list, above ("Update gulpfile to omit scss where possible as a default")?

The reasoning here is that scss or any css preprocessor was never a project dependency in pattern lab. This is almost a trivial point in a node environment as its so simple to integrate whichever you like, but what matters is that the core files still ship with scss. I think this might change in a post v1.0.0 world, but for now it's going to be this way. Therefore, the files are there if you want them but I don't want to assume someone starts with scss. I need to determine which configuration causes less confusion in the long run and is most approachable to newbies.

from patternlab-node.

@oscar-g @yuvilio @ivanmayes can anyone take a gander at the dev branch and attempt to upgrade / install the gulp version? I am pretty confident I've got everything but want some other eyes on it first!

UPGRADE INSTRUCTIONS

Assuming you are on v0.11.X, one should be safe following the instructions in here and here, in addition to overwriting this file when complete:

• source/_patternlab-files/partials/ishControls.mustache

cheers

from patternlab-node.

I'll take a look at this today.

from patternlab-node.

@bmuenzenmeyer, this looks good so far. It builds, serves, and the tests pass. I haven't tested editing patterns and live reload, yet.

One thing: I would add gulp-sass to the package.json...the other option would be to remove sass = require('gulp-sass') from the gulpfile, but then the user would have to add that in, if they want to use scss. On that note, we could add a section in the readme on exactly what comments to remove, in order to use scss (in gulpfile.js, for example, it would be lines 89-90, 109-126, and 135).

from patternlab-node.

@oscar-g ah, I missed the require statement - great catch. The readme does ake some mention of CSS Preprocessor support - please check that out and let me know if it makes sense - it's a bit blunt. I like the idea of either just commenting it out or providing further instruction.

I did test the pattern editing and live reload, but yes hammer away a bit more.

Thanks for your help testing!

from patternlab-node.