[Documentation] Engine configuration fileExtension vs extension about patternlab-node HOT 6 CLOSED

If you do not need the files located in https://github.com/n8design/htwoo/tree/main/htwoo-core/helpers loaded by handlebars, this is also not required and you can just use

  "engines": {
    "handlebars": {
      "package": "@pattern-lab/engine-handlebars",
    }
  }

from patternlab-node.

I'm afraid none of the above is correct.
I wonder that there is an error message popping up because we do absolutely nothing with the given settings at the moment.
For most engines we, we only use extent, noting more.

I think the initial intention of the creator of that code was to allow the user to override the default fileExtensions.
I will prepare a fix for the engines and also for the documentation.

Thank you very much for highlighting this discrepancy.

from patternlab-node.

Have you updated the package @pattern-lab/engine-handlebars in the first project where you tried?
Would you mind reproducing it and hand me the error message you receive?

I tried it for myself with different options and none were giving me an error.

from patternlab-node.

Where I started:

I also had only extend in configuration:

  "engines": {
    "handlebars": {
      "extend": "helpers/*.js"
    }
  }

Which I then update to:

  "dependencies": {
    "@pattern-lab/cli": "^6.0.1",
    "@pattern-lab/core": "^6.0.1",
    "@pattern-lab/engine-handlebars": "^6.0.0",
    "@pattern-lab/uikit-bare": "^0.0.1",
    "@pattern-lab/uikit-workshop": "^6.0.1"
  }

After npm install and run pattern labs got the following message still with the extend in there:

I headed over to the documentation, pasted the prescribed change, and got the same message. That's how I provisioned a new project and figured out the misleading configuration there.

If you like reproducing it, you can use hTWOo.

• Clone the repo
• navigate to htwoo-core folder in there and try it for yourself

Thanks in advance.

from patternlab-node.

The only required parameter is the following and it is the source of the issue.
"package": "@pattern-lab/engine-handlebars",

The extend property will be used by the handlebars engine if you have extensions installed.

from patternlab-node.

Am I correct? The only thing needed is:

  "engines": {
    "handlebars": {
      "package": "@pattern-lab/engine-handlebars",
      "extend": "helpers/hbs/*.js"
    }
  }

or could I remove even the "extend" and all the helpers will get recognised too?

from patternlab-node.