p2psp / core Goto Github PK

The project Bluemindo can be useful to view how to apply the MVC pattern in a desktop app developed with python, pygtk and glade.

A peer should be able to automatically select the needed peer class (Set of Rules) based on the magic flags sent by the splitter.
The following method is proposed:

• An initial/startup peer class ("InitPeer", or just "Peer", or "Player"?) handles the connection to splitter, and loading configuration, header and list of peers from splitter.
• The startup peer class creates an instance of the needed peer class derived from PeerIMS, in a similar way like the splitter currently is implemented. This instance is provided by the (Init)Peer class to get access to its methods.

A possible implementation proposal will follow. Any comments or suggestions are highly appreciated.

On every machine that I try to run the GUI I get this error:

Traceback (most recent call last):
  File "p2psp_application_gui.py", line 12, in <module>
    App_Window = Main_Window()
  File "/home/cmedina/p2psp/src/view/main_window.py", line 14, in __init__
    self.interface = file_util.get_user_interface('glade', '../data/glade/mainwindow.glade')
  File "/home/cmedina/p2psp/src/common/file_util.py", line 16, in get_user_interface
    builder.add_from_file(fName)
gi._glib.GError: ../data/glade/mainwindow.glade: required gtk+ version 3.12, current version is 3.10

Why gtk+ 3.12 is required? Is there an easy way to resolve it?

The way to resolve it that I've found is not so easy for regular users (it's a little bit tedious)

using python gives following error -

Enter yes if you want to download the boost libraries and use the updated boost libraries...
Traceback (most recent call last):
  File "./make.py", line 23, in <module>
    user_input = raw_input()
NameError: name 'raw_input' is not defined

Since lot of installations default to python3 as default python, it would be wise to set python2 shebang explicitly 😅

This could be an endless issue, but it can be useful for those that prefer to work with Python instead of C++.

The RESTSplitter() will be invoked in tracker mode to set the splitter address. It should connect to the crossroad server and send a GET request to obtain the splitter address and port and set them for the peer.

While trying to import peer.py module , it gets executed.
I needed to import so that I could control peer sessions from gui.

The slideshow containing Information about NAT traversal in the P2PSP protocol is not linked properly in the markdown file:-
https://github.com/P2PSP/core/blob/master/doc/NTS/NAT_traversal.md

When the buffer is 100%, the progress bar should disappear whether the window is in full screen.

Previously the GUI folder was not there and after moving modules to GUI directory the import statements not changed which causing Import Error.
Fixed test_gtk3player.py 2e0da51
Fixed test_gtk2player.py 05565ac

 File "/p2psp/src/core/peer_ims.py", line 339, in buffer_data
    buffering_adapter.update_widget(BUFFER_STATUS)
NameError: global name 'buffering_adapter' is not defined

The problem is in a method that only should be used in the desktop app.
We should try to find a solution to run the peer in console and GUI mode.

Currently App is not restored to its previous state when its restarted.

Reference: PyInstaller.

C++ version. When the splitter accepts to server a incoming peer (this is TCP) and the communication switches to UDP, due to, for example, a UDP NAT traversal problem, the peer does not receives chunks and the user stops (CTRL+C) the peer ... the splitter does not realise that the peer has been gone. This is an annoying issue that disables the team because the chunks that are sent to the gone peer are lost :-/

The bug can be in the monitor peer (that does not report the lost chunks) or in the splitter (that does not delete the gone peer in the list of peers).

Reference:

• pychromecast
  Library for Python 2 and 3 to communicate with the Google Chromecast. It currently supports:
  • Auto discovering connected Chromecasts on the network
  • Start the default media receiver and play any online media
  • Control playback of current playing media
  • Implement Google Chromecast api v2
  • Communicate with apps via channels
  • Easily extendable to add support for unsupported namespaces

The cpp sources are producing tons of deprecation warnings while compiling the project. The warnings look like - warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated].

Maybe something to look in near future :)

C++ version

root@io:~# uname -a
Linux io 3.13.0-77-generic #121-Ubuntu SMP Wed Jan 20 10:50:42 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

root@io:~# /root/p2psp/bin/splitter --source_port 4551 --channel BBB-480.ogg --port 4554
2016-02-20 09:06:46.929373 Initialized IMS
2016-02-20 09:06:46.929791 max_chunk_loss = 32
2016-02-20 09:06:46.929863 mcast_addr = 0.0.0.0
2016-02-20 09:06:46.929914 Initialized DBS
2016-02-20 09:06:46.929964 Initialized ACS
2016-02-20 09:06:46.930054 Initialized LRS
2016-02-20 09:06:46.930118 STrPe
2016-02-20 09:06:46.930199 Start
2016-02-20 09:06:46.930370 | Received | Sent | Number losses/ losses
2016-02-20 09:06:46.930436 Time | (kbps) | (kbps) | peers (peer) sents threshold period kbps
2016-02-20 09:06:46.930483 ---------+-----------+-----------+-----------------------------------...
2016-02-20 09:06:46.930556 Requesting the stream header ...
2016-02-20 09:06:46.931005 127.0.0.1 connected to (127.0.0.1, 4551)
2016-02-20 09:06:46.931217 127.0.0.1IMS: GET_message = GET /BBB-480.ogg HTTP/1.1

2016-02-20 09:06:46.931265 Loading the video header
2016-02-20 09:06:47.908044 Stream header received!
2016-02-20 09:06:47.908153 waiting for the monitor peers ...
2016-02-20 09:06:47.930681 |0|0|
2016-02-20 09:06:47.930841 Size peer list: 0
2016-02-20 09:06:48.931011 |0|0|
2016-02-20 09:06:48.931152 Size peer list: 0
2016-02-20 09:06:49.931309 |0|0|
2016-02-20 09:06:49.931445 Size peer list: 0
^C2016-02-20 09:06:50.215905 Keyboard interrupt detected ... Exiting!
2016-02-20 09:06:50.931598 |0|0|
2016-02-20 09:06:50.931728 Size peer list: 0
2016-02-20 09:06:50.931762 Ending
2016-02-20 09:06:50.931853 Bytes transferred saying goodbye: 1
2016-02-20 09:06:50.932118 Accepted connection from peer 127.0.0.1:33010
2016-02-20 09:06:50.932338 Communicating the multicast channel (0.0.0.0, 4554)
2016-02-20 09:06:50.932469 Communicating the header size 10
2016-02-20 09:06:50.932530 Error: Broken pipe
2016-02-20 09:06:50.932605 Sending a chunk_size of 1024 bytes
2016-02-20 09:06:50.932658 Error: Broken pipe
2016-02-20 09:06:50.932707 Sending a header of 10240 bytes
2016-02-20 09:06:50.932765 Error: Broken pipe
2016-02-20 09:06:50.932814 Sending a buffer_size of 256 bytes
Segmentation fault (core dumped)
root@io:~#

root@io:~# uname -a
Linux io 3.13.0-77-generic #121-Ubuntu SMP Wed Jan 20 10:50:42 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

root@io:# /root/p2psp/bin/splitter --source_port 4551 --channel BBB-134.ogv --port 4552
2016-02-20 09:05:03.817840 Initialized IMS
2016-02-20 09:05:03.818249 max_chunk_loss = 32
2016-02-20 09:05:03.818320 mcast_addr = 0.0.0.0
2016-02-20 09:05:03.818372 Initialized DBS
2016-02-20 09:05:03.818426 Initialized ACS
2016-02-20 09:05:03.818526 Initialized LRS
2016-02-20 09:05:03.818592 STrPe
2016-02-20 09:05:03.818680 Start
2016-02-20 09:05:03.818855 | Received | Sent | Number losses/ losses
2016-02-20 09:05:03.818922 Time | (kbps) | (kbps) | peers (peer) sents threshold period kbps
2016-02-20 09:05:03.819053 ---------+-----------+-----------+-----------------------------------...
2016-02-20 09:05:03.819220 Requesting the stream header ...
terminate called after throwing an instance of 'boost::exception_detail::clone_implboost::exception_detail::error_info_injector<boost::system::system_error >'
what(): bind: Address already in use
Aborted (core dumped)
root@io:#

Last versions of Boost has changed the way threads are used. The code of P2PSP should be modified considering that.

The peer just waits for data from the team socket. Suppose the splitter removes the peer because it reached the threshold for max chunk losses, then the other peers also receive the new peer_list and no data is sent to this peer. The peer is just waiting for data while there will be no data coming.
#105

This pull request solves the issue

I don't know how to achieve this, but it would be a nice feature :-)

A review is necessary.

Low priority

In the GUI (gui brach: https://github.com/P2PSP/p2psp/tree/gui) would be interesting to download a thumbnail of the channel from a URL and save it into a local location. Also, the use of the relative path instead of absolute path would be great.

Player surface is not created on mac and windows.

It's not a priority task but maybe it's a good idea.

peer_ims.py uses a connection to Interner in order to get the network interface IP but when Internet is not available that error appear (see title).

If we use the old version of the code we get the loopback IP. Some alternatives to fix this issue are shown at http://stackoverflow.com/questions/24196932/how-can-i-get-the-ip-address-of-eth0-in-python

A volume bar is necessary.

Maybe it could be interesting to display (with color or something like that) the percentage of chunks lost in a period of time. It is an indicator of the channel quality.

When a peer or a set of peers are in the team and the video from the source is restarted (because it finishes), a new peer can't join to the team because a "end of file" error is returned.

I think that the buttons should be in a relative position instead of a fixed position.

Minimum size of the window should be smaller in order to use it in a small screen.

First the player is paused. After that it is stopped. Now if play_back_toggle button is pressed,nothing happens.

I found some unresolved merge conflicts in splitter_ims.py (here) that can cause syntax errors in Python.
I haven't checked yet, but there can be others too.

Display information about download and upload speed in the player window in real time. Moreover, in order to keep a log, would it be possible to use a chart?