Code Monkey home page Code Monkey logo

Comments (4)

mrow4a avatar mrow4a commented on July 1, 2024

I mean, these are personal settings. We have this logic in other parts of the code, and agreed it is legacy, but it is not worth the effort to refactor it. Also I am not sure if I hold right skillset for this.

The reason is, you do not want that someone accidentaly overwrites the key.

from richdocuments.

jnweiger avatar jnweiger commented on July 1, 2024

I agree, it is important to clearly show if the key is already set, or if it is unset.
But I am worried about security aspects here.

Also, in the database, the key is stored unencrypted. So all system admin / backup operator have immediate access.

ariaDB [owncloud]> select * from oc_preferences;
+--------+----------------+---------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| userid | appid | configkey | configvalue |
+--------+----------------+---------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| admin | richdocuments | zoteroAPIPrivateKey | 79870870987098709870987098709870987098709870987098709870987098709870987098709870987098709870987098709870987098709870987098709870987098709870987098709870987098709870987098709879870987098709870987098709870987098709870987098709870987 |

from richdocuments.

mrow4a avatar mrow4a commented on July 1, 2024

Also, in the database, the key is stored unencrypted. So all system admin / backup operator have immediate access.

@jnweiger same with wopi tokens. this info is not user password like, and should be accessible to administrators. the same as with config files for owncloud.

from richdocuments.

jnweiger avatar jnweiger commented on July 1, 2024

Fixed in #529 - personal settings page no longer exposes the key.

from richdocuments.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.