ourzora / zora-721-contracts Goto Github PK

I believe line 36 should read

/// @param _implementation ERC721Drop logic implementation contract to clone

Or should it be the interface?

Withdraws should emit an event

Resolution:

• Delete this project
• Reflect upon the course of maintainer's life that led them to make these kinds of selfish decisions

ERC721Drop should take IFactoryUpgradeGate instead of FactoryUpgradeGate in the constructor for more clean code and convention.

@jemgold

• chainID: 84532
• I have a PR open with deployments already. however, I just need a deployment. If zora team wants to ignore my PR and deploy their own on base sepolia I would welcome it

chiru-labs/ERC721A#28

This implements a batchSize of 8 to the internal _mintNFTs function to balance gas for ownerOf and mint price.

See: chiru-labs/ERC721A#28

As far as I understand, the editionSize of a drop is the total number of tokens that can be minted. So why doens't the purchase() function check for this limit like in the mintWithRewards() function.

Should include salesManagerRole

Would it make sense to add a proveenance hash field to the metadata engine for drops?

hi zora devs,

just me again
asking for another
base deployment

can you please deploy the latest version of ERC721DROP_IMPL on Base mainnet? (chainId: 8453)

latest ERC721DROP_IMPL: [0xaDf8fF6a7EA4f028A384D00136fEF0FFfEb39f14] is missing mintWithRewards function
(https://thirdweb.com/base/0xaDf8fF6a7EA4f028A384D00136fEF0FFfEb39f14/explorer)

Summary

In the README's How do I integrate these in my own site?, step 2 says:

Use our subgraph to find media / metadata information (rinkeby: https://thegraph.com/hosted-service/subgraph/iainnash/erc721droprinkeby) (mainnet: https://thegraph.com/hosted-service/subgraph/iainnash/zora-editions-mainnet)

As of September 2, 2022, https://testnet.create.zora.co/ only supports the Goerli testnet (which in turn means that the Rinkeby testnet was deprecated).

I think it would be helpful to update step 2 to replace the rinkeby information with the goerli link -- could
https://api.thegraph.com/subgraphs/name/iainnash/erc721drop-goerli be the correct one? 💭

(Originally discovered in a component in the 0xTranqui/present-materials repo)

Deployed Contract on Goerli: https://goerli.etherscan.io/address/0xa063e18781ec993b6070446cce80ea934262b11e

Hi! We're trying to create an Editions contract with unlimited editions. The spec says

/// @param _editionSize Number of editions that can be minted in total. If 0, unlimited editions can be minted.

However, using 0 as _editionSize leads to the contract being unusable. All transactions fail. Looking at the code, I don't see any special case handling for editionSize == 0, so my suspicion is it's actually setting the total volume of the collection to 0.

Lmk if you need anymore info! Thanks for publishing these contracts!

uint64 publicSalePrice & uint64 privateSalePrice can only be ~18.45 ETH at max.

ez fix: change to uint104, will still fit in one slot

https://github.com/ourzora/zora-nft-contracts/blob/main/contracts/ZoraNFTBase.sol#L67-L70

Allow the sale admin to update the sales config, right now that permission is not allowed.

In the canvas feature,

I think it’s better if the word used to ‘imagine’ can be auto-used as the Title.

Currently, one cannot add new properties to NFTs using the on-chain metadata renderer for create. Perhaps add an optional field to add arbitrary strings to the metadata (and can be used to override the default serial behavior).