Spider Monkey Panel: brw.groups[albumIndex] is undefined about eole-foobar-theme HOT 12 CLOSED

Well, I didn't manage to reproduce the error, but you can still fix it by update just JStheme_common.js.
Alternatively, you can give me the faultly audio file, maybe it will give me some clue about what's going on.

from eole-foobar-theme.

I did an update which may give me some more informations, can you install the latest version of JStheme_common.js here ? And then, instead of a crash message, yu should see a popup when this error will occur. Please can you give me then the content of this error message?

from eole-foobar-theme.

OK, I have tested this a bunch of times in an attempt to get as much information as possible, so here goes. This is going to be another long post. :) With this new file I get a variation of the following displayed:

albumIndex undefined 2 brw.groups.length:3

The main difference is that the numbers change. I have seen the first value ranging from anywhere between 1 and 38, and I presume that it's tied to the number of tracks. As for the length attribute, I have seen values of 1, 2, 3, 6, 8 and 15. When the error appears, I get a lot of error message popups at once, the most I've received is about 150 error popups on a single 30 track album. In an hour of testing, this is the only type of error I've seen.

If I close foobar and go to the same item that gave me errors, it may or may not happen again. I can also say that combinations of albums or tracks where some have art and others don't doesn't appear to be the source of the issue. When the error happens, the theme seems to force some re-scan of cached images. The thing is, the art is already cached properly and displays correctly in the seconds before it disappears and gives me those errors. When the errors stop and I restart foobar, even if I restart foobar without waiting for the errors to stop, the images are usually displayed correctly.

Basically, all of the images are correctly displayed, until I click on some item, and a forced re-scan is triggered, which then causes the error. All of my art is embedded in the track tags and foobar is set to prefer embedded art, and all of these albums and tracks are properly scanned and have the cached images present in eole's cache folder. I have tracks in various languages, mostly FLAC or mp3, and some of the folders and tracks are in Cyrillic script, could that be an issue? I have noticed that some of the folders that gave me the errors originally, when I refreshed the image cache, never appeared during this round of testing.

from eole-foobar-theme.

"I have tracks in various languages, mostly FLAC or mp3, and some of the folders and tracks are in Cyrillic script"
AHah... Then maybe you need to give me those tracks and folders. Could you upload that somewhere, a zipped folder ? gdrive, dropbox, mediafire, whatever suit you

from eole-foobar-theme.

"Then maybe you need to give me those tracks and folders."
Preferably ones that trigger the error of course : )

from eole-foobar-theme.

And you can also update the file
https://github.com/Ottodix/Eole-foobar-theme/blob/master/themes/eole/js/JStheme_common.js

But don't overthink it, i have enough information with all this, just a report of the errors messages and a sample of the audio files and folders should be enough to fix it.

from eole-foobar-theme.

Sorry for the late response, my internet is a slog for some reason.

The errors that I receive with the new update look like this:

albumIndex undefined 11 brw.groups.length:8
TypeError: brw.groups[albumIndex] is undefined

Here is a link to two complete albums that seem to me to get the error moist frequently, though even these albums don't trigger every time. I'm sending you the albums since I have no idea whether it's a file, tag or album issue, since everything looks OK to me.

Let me know if you need more files or more information!

from eole-foobar-theme.

Ok, thanks! This error makes more sense, albumIndex is greater than brw.groups.length, and it shouldn't be.
Can you install the latest JStheme_common.js there, and give me the two error messages? because then the panel will crash like before, but you'll get 2 messages.

from eole-foobar-theme.

Here you go, I got this to trigger on the folder containing the two albums I sent you:

Error: Spider Monkey Panel v1.2.2-beta+67d2c599 (GraphicBrowser v1.2.2b22 by Ottodix)
brw.groups[albumIndex] is undefined

File: JStheme_common.js
Line: 2818, Column: 4

Stack trace:
  get_albumArt_async@JStheme_common.js:2818:4
  async*oImageCache/this.hit@JStheme_common.js:2959:9
  oBrowser/[email protected]:4629:15
  oBrowser/[email protected]:4759:6
  [email protected]:5932:12

And also:

albumIndex 4 brw.groups.length:2false
TypeError: brw.groups[albumIndex] is undefined

from eole-foobar-theme.

Ok, thanks for that! I can't reproduce it though for the moment. You don't use special grouping or sorting pattern that you would have set from the settings menu (the button with 3 vertical dots on top of the library panel)? If you want to go further, you can send me an export of your columnUI settings (Foobar>File>Preferences>Display-ColumnUI>Export configuration)

You can try this latest file also, it may fix your issue. Still, even if it work, it may be useful to look at your ColumnUI config file.
https://github.com/Ottodix/Eole-foobar-theme/blob/master/themes/eole/js/JStheme_common.js

from eole-foobar-theme.

Sort by "Artist / Album / Track number", and Group by "Default (artist, album)" is what I use. It seems that this last tweak has fixed the issue. I haven't been able to reproduce it on any of my files!

Anyway, here is a link to my config file. I have made some modifications to the ELPlaylist, and I also replaced Shpeck with the "Analog VU Meter" visualisation plugin, but everything else is stock.

Btw, any clue as to why this issue was a problem for me, but not for others? Let me know if there's any more info that I can provide.

from eole-foobar-theme.

Nope, i don't know why it happened on your computer but not on others. Maybe your computer is a little bit slow? I have assumptions, like ... the error occurs on a asynchronous function called get_albumArt_async, it calls an array at some index and this index doesn't exists. So a possibility is that the Array have change in the meantime. My last JStheme_comon.js file contains a fix supposing that this was the right explanation (old asycnronous calls that end their execution too late).

You can grab and install the latest release, but you can also leave it as it is, this new release contains only this bug fix that you already installed.
https://github.com/Ottodix/Eole-foobar-theme/releases

from eole-foobar-theme.