orgmanager / orgmanager Goto Github PK

To do:

• Modify database
• Add a command to update users from v1.1
• Basic GET endpoints
• Basic POST endpoints
• Basic DELETE endpoints

Description:

Use

public function settings(Org $org)

instead of

public function settings($id)
{
$org = Org::findOrFail($id);
}

TO DO:

• Make the change (82cc976)
• Check everything is still working

Notes:

This could be a bit more difficult if #56 is done...

Error in OrgManager

ReflectionException in GET /org/25961132/teams
Method App\Http\Controllers\TeamController::index() does not exist

View on Bugsnag

Stacktrace

vendor/laravel/framework/src/Illuminate/Routing/Route.php:333 - ReflectionMethod::__construct

View full stacktrace

Expected Behavior

Org Admins can import a list of their employees' github usernames, and they're aout-invited to the organization.

Current Behavior

Org Admins manually have to add users, and have to fill in the captcha every time.

Possible Solution

Add an option where admins can upload a csv/excel file to invite users.

Context

Feature

Your Environment

Standard OrgManager Development Version

• Version used:

• Environment name and version (e.g. PHP 5.4 on nginx 1.9.1): PHP 7.1 on Hotel

• Server type and version: Hotel 0.7.1

• Operating System and version: Ubuntu 16.10

In this screenshot I had entered a password for the third entry in the list and pressed enter:

At the top I get a notification saying "opensourcedesign was updated", which is the second entry in the list. The password doesn't save.

Error in OrgManager

BadMethodCallException in POST /org/25961132/teams
Method [validateNumber] does not exist.

View on Bugsnag

Stacktrace

app/Http/Middleware/HttpsMiddleware.php:23 - App\Http\Middleware\HttpsMiddleware::handle

View full stacktrace

Description:

Change functions like

public function showPage()

to more standard names like

public function index()

TO DO:

• Change fuction names (af544bd)
• Check everything is still working

Notes:

Error in OrgManager

PDOException in GET /api/stats
SQLSTATE[HY000] [1105] (proxy) all backends are down

View on Bugsnag

Stacktrace

vendor/laravel/framework/src/Illuminate/Database/Connectors/Connector.php:119 - PDO::__construct

View full stacktrace

Error in OrgManager

ReflectionException in vendor/laravel/framework/src/Illuminate/Container/Container.php:749
Class OrgManager\OrgmanagerCustom\InviteToOrgmanager does not exist

View on Bugsnag

Stacktrace

vendor/laravel/framework/src/Illuminate/Container/Container.php:749 - ReflectionClass::__construct

View full stacktrace

It would be really cool if we could put an input field right on the website so people can join directly from there.

cc @m1guelpf @bnvk @simonv3 :)

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

• Version used:

• Environment name and version (e.g. PHP 5.4 on nginx 1.9.1):

• Server type and version:

• Operating System and version:

• Link to your project:

Where it says »Join Open Source Design« it should actually link »Join Open Source Design«.

Error in OrgManager

Symfony\Component\Console\Exception\CommandNotFoundException in vendor/symfony/console/Application.php:488
There are no commands defined in the "run" namespace.

View on Bugsnag

Stacktrace

vendor/symfony/console/Application.php:488 - Symfony\Component\Console\Application::findNamespace

View full stacktrace

Error in OrgManager

Symfony\Component\Debug\Exception\FatalThrowableError in POST /org/25961132/teams
Class 'App\Http\Controllers\Github' not found

View on Bugsnag

Stacktrace

app/Http/Controllers/TeamController.php:32 - App\Http\Controllers\TeamController::store
app/Http/Middleware/HttpsMiddleware.php:23 - App\Http\Middleware\HttpsMiddleware::handle

View full stacktrace

Error in OrgManager

Symfony\Component\Console\Exception\CommandNotFoundException in vendor/symfony/console/Application.php:534
Command "orgmanager" is not defined.

Did you mean one of these?
orgmanager:orgpwdcrypt
orgmanager:invitetoorg
orgmanager:updateorg
orgmanager:joinorg
orgmanager:tokens

View on Bugsnag

Stacktrace

vendor/symfony/console/Application.php:534 - Symfony\Component\Console\Application::find

View full stacktrace

This is a security problem.

If you automatically create a link (without setting a password) it means that anyone scanning your website for working URLs could feasibly join any organization where someone has given your app permission to join.

Currently https://orgmanager.miguelpiedrafita.com/join/4183553 says »Join opensourcedesign«.

Much nicer would be to say »Join Open Source Design« and use the proper clear name we use on the Github page https://github.com/opensourcedesign :)

Error in OrgManager

Symfony\Component\Debug\Exception\FatalThrowableError in POST /org/25961132/teams
Parse error: syntax error, unexpected 'return' (T_RETURN)

View on Bugsnag

Stacktrace

app/Http/Controllers/TeamController.php:39 - Composer\Autoload\includeFile

View full stacktrace

So in @opensourcedesign for example we have a lot of people set to Private (because it’s the default) and lots of people only invited (because the mails land in spam, or people don’t see where to accept etc).

It would be nice to be able to mass-contact them about setting themselves to Public, or about accepting (or declining) the invitation. The current cumbersome workaround is to manually go through the list …

Test error in Example.com

ExampleException in home#example
Something really bad happened

View on Bugsnag

Stacktrace

app/controllers/home_controller.rb:123 - example
app/controllers/other_controller.rb:12 - broken
lib/important/magic.rb:4 - load_something

View full stacktrace

Error in OrgManager

Symfony\Component\Console\Exception\RuntimeException in vendor/symfony/console/Input/ArgvInput.php:184
Too many arguments, expected arguments "command".

View on Bugsnag

Stacktrace

vendor/symfony/console/Input/ArgvInput.php:184 - Symfony\Component\Console\Input\ArgvInput::parseArgument

View full stacktrace

Expected Behavior

Users find channels for contacting other users or the support team.

Current Behavior

There isn't any info about how users can contact support or other users.

Possible Solution

Add a section in the README with a link to the Glitter channel, mention the on-website chat, github issues and a contact email.

Context

User engagement / Support

Your Environment

OrgManager Developer Version

• Version used: Lastest commit

• Environment name and version (e.g. PHP 5.4 on nginx 1.9.1): PHP 7.1 on hotel 0.7.1

• Server type and version: hotel 0.7.1

• Operating System and version: Ubuntu 16.10

Passwords shouldn't be stored in plain text.

Error in OrgManager

Github\Exception\RuntimeException in PUT /org/24753030
Not Found

View on Bugsnag

Stacktrace

app/Console/Commands/UpdateOrg.php:44 - App\Console\Commands\UpdateOrg::handle
app/Http/Controllers/OrgController.php:41 - App\Http\Controllers\OrgController::update
app/Http/Middleware/HttpsMiddleware.php:23 - App\Http\Middleware\HttpsMiddleware::handle

View full stacktrace

As already mentioned in opensourcedesign/organization#50 (comment)

is there also an easy way to have the visibility of people set to »Public« by default? The current standard of »Private« is a bit annoying because we have to ask everyone.

@m1guelpf you said

it would not be possible as the user needs to accept the invitation before we can modify status via the API

It’s ok to do it afterwards too. :) Ideally there would be some prodding to set it to Public, but of course with a confirmation. But most people sadly don’t change the default and then it just is not visible. :\

Add a Login with GitHub button to the join page, and let users skip the captcha by using it.

TO DO:

• Check if it wouldn't break current functionality (It would)

Add mailables

TO DO:

• Welcome mailable (1d62b5a)
• Send a mail to users that heven't added organizations one week after register (083e16f)

Error in OrgManager

ReflectionException in POST /org/25961132/teams
Class App\Http\Controllers\TeamRequest does not exist

View on Bugsnag

Stacktrace

vendor/laravel/framework/src/Illuminate/Routing/Route.php:339 - ReflectionParameter::getClass

View full stacktrace

Of course best would be to not need the captcha at all, but I understand the uses. But you are able to click the »Join« button without putting in a username nor checking the captcha. You get a big error on the top. Best would be to deactivate the Join button until both is filled out.

Ideally having a tooltip when hovering the join button saying »Please fill out the username« and then »Please check the "I am not a robot" checkbox above«.

Error in OrgManager

Symfony\Component\Console\Exception\RuntimeException in vendor/symfony/console/Input/ArgvInput.php:219
The "--steps" option does not exist.

View on Bugsnag

Stacktrace

vendor/symfony/console/Input/ArgvInput.php:219 - Symfony\Component\Console\Input\ArgvInput::addLongOption

View full stacktrace

Error in OrgManager

ErrorException in GET /callback
Undefined variable: newuser

View on Bugsnag

Stacktrace

app/Http/Controllers/LoginController.php:49 - Illuminate\Foundation\Bootstrap\HandleExceptions::handleError
app/Http/Controllers/LoginController.php:49 - App\Http\Controllers\LoginController::loginUser
app/Http/Middleware/RedirectIfAuthenticated.php:25 - App\Http\Middleware\RedirectIfAuthenticated::handle
app/Http/Middleware/HttpsMiddleware.php:23 - App\Http\Middleware\HttpsMiddleware::handle

View full stacktrace

pinging @elioqoshi

Forntend redesign

Error in OrgManager

Symfony\Component\Debug\Exception\FatalThrowableError in app/Console/Commands/InviteToOrgmanager.php:52
Parse error: syntax error, unexpected ''username'' (T_CONSTANT_ENCAPSED_STRING), expecting ']'

View on Bugsnag

Stacktrace

app/Console/Commands/InviteToOrgmanager.php:52 - Composer\Autoload\includeFile

View full stacktrace

Expected Behavior

OrgManager has a register process where we firslty create an account, and then ask for the org scope.

Current Behavior

OrgManager requires the Org Admin scope without any explanation.

Possible Solution

Build an interactive register promt.

Context

User Engagement / General

Your Environment

Standard OrgManager Developer Version

• Version used:

• Environment name and version (e.g. PHP 5.4 on nginx 1.9.1): PHP 7.1 on Hotel

• Server type and version: Hotel 0.7.1

• Operating System and version: Ubuntu 16.04

Error in OrgManager

Symfony\Component\Debug\Exception\FatalThrowableError in GET /org/25961132
Parse error: syntax error, unexpected '$org' (T_VARIABLE), expecting ',' or ')'

View on Bugsnag

Stacktrace

app/Http/Middleware/HttpsMiddleware.php:23 - App\Http\Middleware\HttpsMiddleware::handle

View full stacktrace

Description:

Allow organizations to set a default team that users will join.

TO DO:

• Check if it is possible
• Add a migration to store org teams
• Add option to dashboard
• Add team joiner to the invite command
• Testing

Notes:

Github API documentation for Organization teams:

https://developer.github.com/v3/orgs/teams/

Endpoint to get organization teams:

https://developer.github.com/v3/orgs/teams/#list-teams

Endpoint to invite user and add to a team:

https://developer.github.com/v3/orgs/teams/#add-or-update-team-membership

API Client function

https://github.com/KnpLabs/php-github-api/blob/master/lib/Github/Api/Organization/Teams.php#L66

Description:

Currently, validation is done manually, and that makes the code a disaster. We can use Validation hooks to keep showing errors with toastr. We should also stop using toastr. Sweetalert2 seems a cool alternative.

TO DO:

• Change to Laravel validation system
• Return errors using SweetAlert

Notes:

Adding custom validation the easy way (could be used with reCaptcha validation):

Laravel validation documentation:

https://laravel.com/docs/5.3/validation

Currently on the page https://orgmanager.miguelpiedrafita.com/join/4183553 it says »Added by @simonv3« in the footer. And it seems only Simon can approve new members, or at least I’m not sure how I would be able to.

As we are an organization, it should be maintained by the organization and all its owners. :) And all of the owners should automatically get access to it.

Error in OrgManager

Github\Exception\RuntimeException in POST /org/25961132/teams
Not Found

View on Bugsnag

Stacktrace

app/Http/Controllers/TeamController.php:34 - App\Http\Controllers\TeamController::store
app/Http/Middleware/HttpsMiddleware.php:23 - App\Http\Middleware\HttpsMiddleware::handle

View full stacktrace

Instead of https://orgmanager.miguelpiedrafita.com/join/4183553 it would be much nicer to have https://orgmanager.miguelpiedrafita.com/join/opensourcedesign :)

Also – get a real nice domain which isn’t just a subdomain maybe. ;)

Undefined variable: username in app/Http/Controllers/JoinController.php:61

Test error in Example.com

ExampleException in home#example
Something really bad happened

View on Bugsnag

Stacktrace

app/controllers/home_controller.rb:123 - example
app/controllers/other_controller.rb:12 - broken
lib/important/magic.rb:4 - load_something

View full stacktrace

Error in OrgManager

Symfony\Component\Debug\Exception\FatalThrowableError in app/Console/Commands/InviteToOrgmanager.php:73
Parse error: syntax error, unexpected end of file, expecting function (T_FUNCTION) or const (T_CONST)

View on Bugsnag

Stacktrace

app/Console/Commands/InviteToOrgmanager.php:73 - Composer\Autoload\includeFile

View full stacktrace

In case you are already a member of the organization, you should not get the normal message of »check your email«.

Instead you could get to a page where you can manage your visibility (see #48) or also invite others.

Description:

Security is one of the most important things at OrgManager. Therebefore, we should have a page where people can report vulnerabilities. HackerOne offers a plan for open-source projects, so I'd be cool to use it.

TO DO:

• Wait for OrgManager to get 3 months old (April 13th)
• Apply to the HackerOne Community Version
• Wait for response
• Configure the HackerOne page
• Launch the program privately
• Make the program public

It seems like most people are confused about how to use Orgmanager, let's improve that!

TO DO:

• Make those login links login you instead of taking you to the login page (b9f6dbc)
• Remove the login page (488ff40)
• Autosync on register (338f446)
• Change the login text in the front page with a dashboard text (75f705d)
• Add more options to the menu (8ad535d)
• Change the sync link to a sync button (e719ca0)