Code Monkey home page Code Monkey logo

Comments (16)

m1guelpf avatar m1guelpf commented on June 11, 2024

@jancborchardt Well, you could use the API to invite users to the organization...
Also, I am planning on building a small one-file php version that contains only the join page and uses the API.

from orgmanager.

jancborchardt avatar jancborchardt commented on June 11, 2024

Yeah I know I could, but I can’t cause I’m not that deep of a developer. ;) And I thought that’s maybe what orgmanager would be useful for too.

from orgmanager.

jancborchardt avatar jancborchardt commented on June 11, 2024

There’s no way it could just be using JS? Cause that would be immensely helpful for static pages like ours.

from orgmanager.

m1guelpf avatar m1guelpf commented on June 11, 2024

@jancborchardt Not without exposing your Orgmanager token, I think...
I mean, if you don't mind exposing your API token, you can make a form, transform output to json and use the API.
You migth want to take a look at the api docs...
http://docs.orgmanager.miguelpiedrafita.com
Also, stackoverflow about transforming form output to json:
http://stackoverflow.com/questions/11338774/serialize-form-data-to-json

from orgmanager.

m1guelpf avatar m1guelpf commented on June 11, 2024

@jancborchardt Maybe a form integration can be possible, but you need a way to keep the bots out, as you can't use your own recaptcha... Ideas?

from orgmanager.

simonv3 avatar simonv3 commented on June 11, 2024

Could we just embed an iframe with the form?

from orgmanager.

m1guelpf avatar m1guelpf commented on June 11, 2024

@simonv3 Chrome and Mozilla disabled iframes for security reasons. Also, iframes are deprecated for lots of security issues.

from orgmanager.

simonv3 avatar simonv3 commented on June 11, 2024

Huh, when did that happen? I'm fairly sure that sandstorm makes extensive use of iframes, and I use it in Chrome.

Edit: I don't think I see anything here about them being insecure or being disabled: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe

from orgmanager.

m1guelpf avatar m1guelpf commented on June 11, 2024

@simonv3 You're rigth. Iframes aren't deprecated. You may want to read about iframe security for pages that embed them. The problem I have is with the server-side validation. Orgmanager tries ro prevent bot signups, by providing a captcha on web request or requiring the admin's token on the API. Allowing forms would raise two security issues:

  1. CSRF Protection. Orgmanager uses tokens to prevent Cross Site Request Forgery, and if I allow posting from the outside, I'd have to disable some routes, risking from malicious requests.

  2. Bot prevention. As you can't add a dynamic token to static pages, there wouldn't be any bot prevention (or, at least, not any secure bot prevention).

I will make some tests with OrgManager and iframes as soon as I can and report results back.

from orgmanager.

m1guelpf avatar m1guelpf commented on June 11, 2024

@jancborchardt Is this still a need? It is the last issue open tagged before v3.0, and now that you linked the join page on the opensourcedesign website, maybe this can be closed...

from orgmanager.

simonv3 avatar simonv3 commented on June 11, 2024

I'll let @jancborchardt be the judge of that, he created the issue :)

from orgmanager.

m1guelpf avatar m1guelpf commented on June 11, 2024

@jancborchardt What do you think?

from orgmanager.

m1guelpf avatar m1guelpf commented on June 11, 2024

@jancborchardt @simonv3 I think I'm going to move this to v4 because I want to release v3 this week.

from orgmanager.

jancborchardt avatar jancborchardt commented on June 11, 2024

It would really be cool still – as said on #56 (comment)

That also gets everyone who lands on your page to get involved very quickly. Sure, with a button you could just link to the orgmanager page, but abstracting the whole thing away through just an input field or a button which launches Github auth would be even cooler.

from orgmanager.

m1guelpf avatar m1guelpf commented on June 11, 2024

@jancborchardt So then, this can be closed in favour of #56?

from orgmanager.

jancborchardt avatar jancborchardt commented on June 11, 2024

@m1guelpf :D I think #56 should be closed in favor of this, since this here is much clearer, and the other issue was a completely different one at the start. ;)

from orgmanager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.