Code Monkey home page Code Monkey logo

Comments (3)

sklueber avatar sklueber commented on May 24, 2024

For identifying an "Unknown Place Bookmark", is it enough to check whether the name of the bookmark is equal to the current translation of the "Unknown Place" string?

Of course that would break when changing the app language or if the string gets updated after creating the bookmark. But it would at the very least support the most common case of editing immediately after creation.

from organicmaps.

biodranik avatar biodranik commented on May 24, 2024

String identifiers can be queried dynamically for any language. Another, more robust approach could be to check if there is any POI under the bookmark.

from organicmaps.

sklueber avatar sklueber commented on May 24, 2024

The title should not be focused if the user already set a custom title, correct? As the "Unknown Place" title is set as a custom name in the C++ code, there is no way to differentiate a user-given title and an "Unknown Place" without string comparison (or adding some kind of flag to the C++ code, but that seems very over-engineered for this use case).

As for querying all languages, it does not seem very efficient to create 40+ resource objects just for this small feature.

from organicmaps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.