Comments (3)
For identifying an "Unknown Place Bookmark", is it enough to check whether the name of the bookmark is equal to the current translation of the "Unknown Place" string?
Of course that would break when changing the app language or if the string gets updated after creating the bookmark. But it would at the very least support the most common case of editing immediately after creation.
from organicmaps.
String identifiers can be queried dynamically for any language. Another, more robust approach could be to check if there is any POI under the bookmark.
from organicmaps.
The title should not be focused if the user already set a custom title, correct? As the "Unknown Place" title is set as a custom name in the C++ code, there is no way to differentiate a user-given title and an "Unknown Place" without string comparison (or adding some kind of flag to the C++ code, but that seems very over-engineered for this use case).
As for querying all languages, it does not seem very efficient to create 40+ resource objects just for this small feature.
from organicmaps.
Related Issues (20)
- Crash when user search coordinates HOT 1
- Node id bigger than the allocated cache size
- [styles] Motorbike parking areas without fill
- routing to area: stop routing once in an area eg. car park
- Openstreetmap data update HOT 4
- [Android Auto] Search only works when car is parked
- [Android Auto] Adding stops while navigating or on the "Start Navigation" screen is not possible. HOT 1
- [Android Auto] Show addresses for search results
- Support area:highway and highway=* area=yes
- Highlight that drive through is available for a POI
- Update first map download message HOT 9
- [android] Crash in search due to invalid translation key
- Order of the intermediate stops is not adhered to HOT 1
- Split Malaysia and add isolines for it.
- Misses bookmark when tap on a building HOT 1
- Reinstate updates of OrganicMaps on F-droid app store HOT 2
- Strip non-supported HTML tags from Huawei descriptions HOT 2
- [IOS] Editing map data while navigating causes the dialog buttons to appear behind the bar at the bottom
- Some users do not discover how to add a stop
- Crash with memory tagging (MTE) enabled HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from organicmaps.