Code Monkey home page Code Monkey logo

Comments (5)

github-actions avatar github-actions commented on June 24, 2024

Invalid Version reported. DISTRIB_REVISION='2.14.51'
Is this from a clean repository?

from openwrt.

github-actions avatar github-actions commented on June 24, 2024

Invalid Release reported. DISTRIB_RELEASE='22.03.3'
Is this from a clean repository?

from openwrt.

github-actions avatar github-actions commented on June 24, 2024

Invalid Target/Subtarget reported. DISTRIB_TARGET='rockchip/armv8'
Is this from a supported device?

from openwrt.

brada4 avatar brada4 commented on June 24, 2024

Can you repeat on mainstream stable OpenWRT and copy proper release tags?

from openwrt.

zhengyikeng avatar zhengyikeng commented on June 24, 2024

My problem has been resolved. My code has a mechanism that attempts to subscribe periodically after a subscription failure. The same struct ubus_subscriber has called API ubus_register_subscriber() multiple times, which can cause structural abnormalities in the avl tree

image

Just a suggestion, would it be better to do a check before insertion

diff --git a/libubus-obj.c b/libubus-obj.c
index 29cbb2b..aec0a4d 100644
--- a/libubus-obj.c
+++ b/libubus-obj.c
@@ -169,7 +169,9 @@ static void ubus_add_object_cb(struct ubus_request *req, int type, struct blob_a
 
        if (attrbuf[UBUS_ATTR_OBJTYPE])
                obj->type->id = blob_get_u32(attrbuf[UBUS_ATTR_OBJTYPE]);
-
+       /*
+        * Suggest: check if avl node exists in the AVL tree? and if it exists, would it be better to remove it first?
+        */
        obj->avl.key = &obj->id;
        avl_insert(&req->ctx->objects, &obj->avl);

from openwrt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.