Comments (16)
Hello @ydelattre! Apparently, S3 does cause the problem. We'll look into the problem! Thanks again for your feedback
from onlyoffice-mattermost.
I too get the same error message.
from onlyoffice-mattermost.
Hello @Nsenz,
the crash happen before the editing session just after enabling the plugin.
And then this message is shown in the plugin management page :
This plugin crashed multiple times and is no longer running. Check your system logs for errors.
In our dev env, the plugin start without problem :
{"timestamp":"2023-01-24 14:51:38.207 +01:00","level":"debug","msg":"starting plugin","caller":"plugin/hclog_adapter.go:52","plugin_id":"com.onlyoffice.mattermost","wrapped_extras":"pathplugins/com.onlyoffice.mattermost/server/dist/plugin-linux-amd64args[plugins/com.onlyoffice.mattermost/server/dist/plugin-linux-amd64]"}
{"timestamp":"2023-01-24 14:51:38.208 +01:00","level":"debug","msg":"plugin started","caller":"plugin/hclog_adapter.go:52","plugin_id":"com.onlyoffice.mattermost","wrapped_extras":"pathplugins/com.onlyoffice.mattermost/server/dist/plugin-linux-amd64pid780"}
{"timestamp":"2023-01-24 14:51:38.208 +01:00","level":"debug","msg":"waiting for RPC address","caller":"plugin/hclog_adapter.go:52","plugin_id":"com.onlyoffice.mattermost","wrapped_extras":"pathplugins/com.onlyoffice.mattermost/server/dist/plugin-linux-amd64"}
{"timestamp":"2023-01-24 14:51:38.444 +01:00","level":"debug","msg":"using plugin","caller":"plugin/hclog_adapter.go:52","plugin_id":"com.onlyoffice.mattermost","wrapped_extras":"version1"}
{"timestamp":"2023-01-24 14:51:38.464 +01:00","level":"debug","msg":"plugin address","caller":"plugin/hclog_adapter.go:52","plugin_id":"com.onlyoffice.mattermost","wrapped_extras":"networkunixaddress/tmp/plugin577205606timestamp2023-01-24T14:51:38.433+0100"}
{"timestamp":"2023-01-24 14:51:38.594 +01:00","level":"info","msg":"[ONLYOFFICE CMD]: The server responded without errors","caller":"app/plugin_api.go:973","plugin_id":"com.onlyoffice.mattermost"}
{"timestamp":"2023-01-24 14:51:38.956 +01:00","level":"info","msg":"[ONLYOFFICE CMD]: The server responded without errors","caller":"app/plugin_api.go:973","plugin_id":"com.onlyoffice.mattermost"}
Hmmmmm, maybe i found something :
onlyoffice-mattermost/server/cmd/plugin.go
Line 107 in b129dc1
There is only one argument in this method : ToFileBackendSettings(license != nil && *license.Features.Compliance)
But in Mattermost code, this method need 2 arguments :
func (s *FileSettings) ToFileBackendSettings(enableComplianceFeature bool, skipVerify bool) filestore.FileBackendSettings {
If you look at the method, second argument skipVerify
is only use if local storage is not enable. Could explain why the plugin crash in our test env (S3 storage) and not in our dev env (local storage).
from onlyoffice-mattermost.
Released
https://github.com/ONLYOFFICE/onlyoffice-mattermost/releases/tag/v1.1.1
from onlyoffice-mattermost.
@ydelattre, Hello!
Thanks for your feedback. We will look into the problem as soon as possible!
from onlyoffice-mattermost.
Same here:
{"timestamp":"2023-01-14 15:54:45.778 Z","level":"warn","msg":"Health check failed for plugin","caller":"plugin/health_check.go:59","id":"com.onlyoffice.mattermost","error":"plugin RPC connection is not responding"}
{"timestamp":"2023-01-14 15:54:45.778 Z","level":"warn","msg":"error closing client during Kill","caller":"plugin/hclog_adapter.go:70","plugin_id":"com.onlyoffice.mattermost","wrapped_extras":"errconnection is shut down"}
{"timestamp":"2023-01-14 15:54:45.778 Z","level":"warn","msg":"plugin failed to exit gracefully","caller":"plugin/hclog_adapter.go:72","plugin_id":"com.onlyoffice.mattermost"}
{"timestamp":"2023-01-14 15:54:45.954 Z","level":"error","msg":"RPC call to OnActivate plugin failed.","caller":"plugin/client_rpc.go:268","plugin_id":"com.onlyoffice.mattermost","error":"unexpected EOF"}
{"timestamp":"2023-01-14 15:54:45.955 Z","level":"error","msg":"plugin process exited","caller":"plugin/hclog_adapter.go:79","plugin_id":"com.onlyoffice.mattermost","wrapped_extras":"pathplugins/com.onlyoffice.mattermost/server/dist/plugin-linux-amd64pid21025errorexit status 2"}
{"timestamp":"2023-01-14 15:55:00.833 Z","level":"error","msg":"Plugin failed to ServeHTTP, RPC call failed","caller":"plugin/client_rpc.go:423","plugin_id":"com.onlyoffice.mattermost","error":"connection is shut down"}
{"timestamp":"2023-01-14 15:55:05.835 Z","level":"error","msg":"Plugin failed to ServeHTTP, muxBroker couldn't Accept request body connection","caller":"plugin/client_rpc.go:397","plugin_id":"com.onlyoffice.mattermost","error":"timeout waiting for accept"}
{"timestamp":"2023-01-14 15:55:05.835 Z","level":"error","msg":"Plugin failed to ServeHTTP, muxBroker couldn't accept connection","caller":"plugin/client_rpc.go:378","plugin_id":"com.onlyoffice.mattermost","serve_http_stream_id":3,"error":"timeout waiting for accept"}
from onlyoffice-mattermost.
@abbasharoon, @ydelattre could you please share more details about the deployment/steps to reproduce the error? The plugin seems to be working fine with MM 7.5.2. There is a visual problem with the editor page (status codes) though.
from onlyoffice-mattermost.
@Nsenz here is my setup:
Ubuntu 18.04
MM: 7.5.2
OO-MM Plugin: 1.1.0
MM is installed via their docker setup: https://mattermost.com/deploy/
OO Document server is also a docker instance https://github.com/ONLYOFFICE/Docker-DocumentServer
Both are behind Nginx reverse proxy.
from onlyoffice-mattermost.
Hello @abbasharoon, i tested the same deploy as you and no errors, i think it's a reverse proxy issue, not plugin.
from onlyoffice-mattermost.
@Nsenz :
MM is installed via Docker and OO Docs on K8S.
HAProxy is used in front of OO Docs and then NGINX Ingress controller is used on K8S, so could it be a reverse proxy issue but no idea what may be causing it.... π§
from onlyoffice-mattermost.
@ydelattre will ask our DevOps to have a look at that!
from onlyoffice-mattermost.
@Nsenz Great ! Thanks :)
from onlyoffice-mattermost.
Hello @igwyd @Nsenz
I looked again.
When i activate the plugin, it successfully check the version :
HTTP request from MM plugin :
{"exp":1674484628,"iat":1674484568,"c":"version","token":"XXXXXXXXXXXXXXXXXXXXXXXXXXXXX"}
HTTP answer from OO Docs :
{"error":0,"version":"7.2.2.56"}
And quickly after the plugin crashed with this error :
"timestamp":"2023-01-23 15:36:08.723 +01:00","level":"debug","msg":"panic: runtime error: invalid memory address or nil pointer dereference","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.onlyoffice.mattermost"}
{"timestamp":"2023-01-23 15:36:08.723 +01:00","level":"debug","msg":"[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x965d0b]","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.onlyoffice.mattermost"}
{"timestamp":"2023-01-23 15:36:08.723 +01:00","level":"debug","msg":"","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.onlyoffice.mattermost"}
{"timestamp":"2023-01-23 15:36:08.723 +01:00","level":"debug","msg":"goroutine 39 [running]:","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.onlyoffice.mattermost"}
{"timestamp":"2023-01-23 15:36:08.723 +01:00","level":"debug","msg":"github.com/mattermost/mattermost-server/v6/model.(*FileSettings).ToFileBackendSettings(0x7f030090b6e0, 0x10)","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.onlyoffice.mattermost"}
{"timestamp":"2023-01-23 15:36:08.723 +01:00","level":"debug","msg":"\tgithub.com/mattermost/mattermost-server/[email protected]/model/config.go:1492 +0x12b","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.onlyoffice.mattermost"}
{"timestamp":"2023-01-23 15:36:08.723 +01:00","level":"debug","msg":"github.com/ONLYOFFICE/onlyoffice-mattermost/server/cmd.(*Plugin).OnConfigurationChange(0xc00014c4d0)","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.onlyoffice.mattermost"}
{"timestamp":"2023-01-23 15:36:08.723 +01:00","level":"debug","msg":"\tgithub.com/ONLYOFFICE/onlyoffice-mattermost/server/cmd/plugin.go:107 +0x3cc","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.onlyoffice.mattermost"}
{"timestamp":"2023-01-23 15:36:08.724 +01:00","level":"debug","msg":"github.com/mattermost/mattermost-server/v6/plugin.(*hooksRPCServer).OnActivate(0xc0004d0220, 0xc0004ea030, 0xc00026a160)","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.onlyoffice.mattermost"}
{"timestamp":"2023-01-23 15:36:08.724 +01:00","level":"debug","msg":"\tgithub.com/mattermost/mattermost-server/[email protected]/plugin/client_rpc.go:307 +0x1f5","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.onlyoffice.mattermost"}
{"timestamp":"2023-01-23 15:36:08.724 +01:00","level":"debug","msg":"reflect.Value.call({0xc00052f320, 0xc0005323a0, 0x13}, {0xf13a64, 0x4}, {0xc0004f3ef8, 0x3, 0x3})","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.onlyoffice.mattermost"}
{"timestamp":"2023-01-23 15:36:08.724 +01:00","level":"debug","msg":"\treflect/value.go:543 +0x814","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.onlyoffice.mattermost"}
{"timestamp":"2023-01-23 15:36:08.724 +01:00","level":"debug","msg":"reflect.Value.Call({0xc00052f320, 0xc0005323a0, 0x0}, {0xc00060bef8, 0x3, 0x3})","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.onlyoffice.mattermost"}
{"timestamp":"2023-01-23 15:36:08.724 +01:00","level":"debug","msg":"\treflect/value.go:339 +0xc5","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.onlyoffice.mattermost"}
{"timestamp":"2023-01-23 15:36:08.724 +01:00","level":"debug","msg":"net/rpc.(*service).call(0xc0000c8600, 0x0, 0x0, 0xc0000b8390, 0xc0000ca680, 0x0, {0xd708e0, 0xc0004ea030, 0x0}, {0xd70920, ...}, ...)","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.onlyoffice.mattermost"}
{"timestamp":"2023-01-23 15:36:08.724 +01:00","level":"debug","msg":"\tnet/rpc/server.go:377 +0x239","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.onlyoffice.mattermost"}
{"timestamp":"2023-01-23 15:36:08.724 +01:00","level":"debug","msg":"created by net/rpc.(*Server).ServeCodec","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.onlyoffice.mattermost"}
{"timestamp":"2023-01-23 15:36:08.724 +01:00","level":"debug","msg":"\tnet/rpc/server.go:474 +0x405","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.onlyoffice.mattermost"}
Don't know how this error could be related to a reverse proxy issue :-/
FYI, the plugin was downloaded from this repo in the release page.
Thanks for your help !
from onlyoffice-mattermost.
So far all test was done in our test env. I tested the plugin in our dev env : it practically works (little problem with mixed contents) but the plugin start successfully.
The difference between dev and test env : file storage is done on S3 in our test env
Furthermore, the stack trace mentioned :
{"timestamp":"2023-01-23 15:36:08.723 +01:00","level":"debug","msg":"github.com/mattermost/mattermost-server/v6/model.(*FileSettings).ToFileBackendSettings(0x7f030090b6e0, 0x10)","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.onlyoffice.mattermost"}
It's a lead, i think :)
from onlyoffice-mattermost.
Hello @ydelattre!
Do you know if the crash happens after your editing session? Please shed some light on the steps you take in order for us to recreate the exact issue. Also, it would be helpful if you could share logs from your dev environment. @Eloncase, could you please have a look at that?
from onlyoffice-mattermost.
@ydelattre, I suppose our calls to MM's filestore might cause the problem provided the bug occurs during/after editing.
from onlyoffice-mattermost.
Related Issues (17)
- Unable to install the plugin on version MM 7.1.2 HOT 2
- config sending of notifications
- Plugin Failed to start (Invalid character) HOT 3
- Error `Token used before issued` HOT 5
- Integration with Mattermost Boards
- plugin RPC connection is not responding HOT 7
- can't open the doc by onlyoffice HOT 4
- How to display the full file nameοΌ HOT 2
- Error when enable the ONLYOFFICE plugin HOT 1
- Unable to build the plugin HOT 1
- JWT header Authorisation ERROR after last update HOT 3
- Not open document in onlyoffice - Download failed HOT 9
- https mattermost with context and http onlyoffice integration issues
- use without JWT HOT 2
- Do not display the version history menu item HOT 1
- Unable to enable the ONLYOFFICE plugin HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from onlyoffice-mattermost.