oksydan / falcon Goto Github PK
View Code? Open in Web Editor NEWPrestashop starter theme that provides great development experience.
License: GNU General Public License v3.0
Prestashop starter theme that provides great development experience.
License: GNU General Public License v3.0
Hi @Oksydan
This plugin and your excellent theme work fine with PHP 7.3 but there are some trouble with PHP 7.4.
I replace in template is_shoppingcart.tpl and modal-success.tpl :
{if $subtotal.value}
By
{if isset($subtotal.value)}
And it's works.
Regards,
Olivier
On mobile version there is no "subscribe" button. It's hidden via hidden-xs-down class.
<input class="btn btn-primary float-right hidden-xs-down" name="submitNewsletter" type="submit" value="Subskrybuj">
After removing class hidden-xs-down
button is displaying correctly on mobile.
PS 1.7.7.5 (which was the latest PS version around when I installed my webshop in July 2021, updating has always been a challange and a hit and miss for me... resulting in crashed and pretty unusable shops)
PHP 7.3.29
starter theme 1.3.0
is_imageslider-1.0.4
is_searchbar-1.0.0
is_shoppingcart-1.0.0
is_themecore-1.1.2
The theme was installed on a test copy of my live webshop installed in July 2021.
When I click on a products picture to see more details in front office I get the following:
Add some items to cart.
Go to cart page.
In cart page when you update quantities in products the price is updated only in each item row. But the subtotal and total price not changes values via ajax. you need to refresh the page to see the current values.
I have the debug mode activated but not show errors.
Hello it seems that productcomments module create a Notice failure on product page when debug is active
I fixed this by editing modules/productcomments/views/templates/hook/product-comments-list.tpl
i replaced:
line 49
data-comment-item-prototype="{$comment_prototype|escape:'html_attr'}">
by
data-comment-item-prototype="{$comment_prototype}">
the error was
User Notice: escape: unsupported type: html_attr - returning unmodified string
i don't know if there is an other way to cleanup the string or to avoid this notice if nothing is cleaned.
Thank you.
Please add a license to the project so people know whether they can, or not, use it in commercial projects, addons themes etc.
I just built the theme assets to play around this theme and i got this error.
Attempted to load class "GeneralConfiguration" from namespace "Oksydan\Module\IsThemeCore\Form\Settings".
Did you forget a "use" statement for e.g. "PrestaShop\PrestaShop\Adapter\Order\GeneralConfiguration", "PrestaShop\PrestaShop\Adapter\Product\GeneralConfiguration" or "PrestaShop\PrestaShop\Adapter\GeneralConfiguration"?
I don't know what i'm doing wrong because i just started :(.
ps: i have the is_themecore module installed and that class is present in modules/is_themecore/..
During the installation process (step 6), when you try to run npm run dev
You have :
/themes/starter/_dev/webpack.config.js:20
purge: options?.purge ? options.purge : false,
^
SyntaxError: Unexpected token '.'
at wrapSafe (internal/modules/cjs/loader.js:915:16)
at Module._compile (internal/modules/cjs/loader.js:963:27)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
at Module.load (internal/modules/cjs/loader.js:863:32)
at Function.Module._load (internal/modules/cjs/loader.js:708:14)
at Module.require (internal/modules/cjs/loader.js:887:19)
at require (internal/modules/cjs/helpers.js:74:18)
Hello!
There is a missing {if $product.default_image}
control in starter/modules/is_shoppingcart/views/template/front/is_shoppingcart-product-line.tpl
For any of you having this same problem, there's a quick fix waiting for the next release of the theme with these bugs fixed, (as announced by @Oksydan here and here ):
In theme's directory starter/modules/is_shoppingcart/views/template/front/is_shoppingcart-product-line.tpl
change these lines:
<img
{generateImagesSources image=$product.default_image size='cart_default' lazyload=false}
alt="{$product.name|escape:'quotes'}"
class="img-fluid"
width="{$product.default_image.bySize.cart_default.width}"
height="{$product.default_image.bySize.cart_default.height}">
to:
<img
{if $product.default_image}
{generateImagesSources image=$product.default_image size='cart_default' lazyload=false}
{else}
src="{$urls.no_picture_image.bySize.cart_default.url}"
{/if}
alt="{$product.name|escape:'quotes'}"
class="img-fluid"
width="{if !empty($product.default_image)}{$product.default_image.bySize.cart_default.width}{/if}"
height="{if !empty($product.default_image)}{$product.default_image.bySize.cart_default.height}{/if}">
Hello,
I tried to install this theme earlier and encountered the following error after the install in FO:
/public/themes/starter/templates/catalog/_partials/miniatures/_partials/product-thumb.tpl" on line 7 "{generateImagesSources image=$product.default_image size='home_default'}" unknown tag 'generateImagesSources'
Btw great work with this theme, it seems great, really looking forward using it in the future.
During installation I have some errors, because some required modules is missing.
We nee to alert people in requirements doc.
File _nice_select.scss line: 5
$input-height: $custom-select-height;
After run build I have error message:
throw new Error("Module build failed (from ./node_modules/sass-loader/dist/cjs.js):\nSassError: Undefined operation "-calc(1.5em + 1rem + 2px)".\n ╷\n93 │ transform: scale(0.75) translateY(-$input-height / 2);\n │ ^^^^^^^^^^^^^^\n ╵\n css/theme/vendors/_nice-select.scss 93:37 @import\n css/theme/vendors/_index.scss 1:9 @import\n css/theme/_index.scss 2:9 @import\n css/theme.scss 2:9 root stylesheet");
Any change $input-height (ex. 14px) - build works fine.
Hello,
Can you tell me how to reuse Swipper JS to create a slider like for product thumbnails?
Exemple :
<div class="swiper">
<div class="swiper-wrapper">
<!-- Slides -->
{foreach $instagram_pics as $pic}
<div class="swiper-slide">
<a href="{$pic.link}" title="{$pic.caption|escape:'html':'UTF-8'}" target="_blank" rel="nofollow">
<img src="{$pic.image}" alt="{$pic.caption|escape:'html':'UTF-8'}" class="img-responsive" />
</a>
</div>
{/foreach}
</div>
Thank's :)
Hello,
Thanks for your work. This theme is amazing ! But I had some error messages with is_imageslider module.
I'm running Prestashop 1.7.8.1 on a Docker container in Windows with PHP 7.4.26.
I followed install instructions, so I've downloaded and installed is_ modules on my {shop_dir}/modules/
before setting up the theme (latest version: 2.0.1) .
After running npm install
, npm run build
and npm run dev
, the image slider was not showing.
In the back office, I clicked on Modules Manager, searched ImageSlider and when I clicked on Configure, I had this error modal:
Notice à la ligne 980 du fichier /var/www/modules/is_imageslider/is_imageslider.php
[8] Trying to access array offset on value of type null
Notice à la ligne 982 du fichier /var/www/modules/is_imageslider/is_imageslider.php
[8] Trying to access array offset on value of type null
Notice à la ligne 983 du fichier /var/www/modules/is_imageslider/is_imageslider.php
[8] Trying to access array offset on value of type null
Notice à la ligne 984 du fichier /var/www/modules/is_imageslider/is_imageslider.php
[8] Trying to access array offset on value of type null
After closing the modal, I was able to upload images to the slider and it worked fine, but whenever I want to add other slides, this error modal shows up again.
I'm new in Prestashop theme development so I don't know if it is a bug from Prestashop or from the module/theme.
To do list:
Hello thanks for your work !
Some CSS are missing for the module blockwishlist in order to work with the starter theme.
Especially concerning the modal. Have you seen this issue ?
I test the template - good job, but there is some problem with the swiper, after going to the last photo the whole block changes its size.
Hello,
When shop is in maintenance, logo is not displayed.
I fixed it replacing
<img src="{$urls.img_ps_url}{$shop.logo}" alt="logo" loading="lazy">
by just {$shop.logo}
<img src="{$shop.logo}" alt="logo" loading="lazy">
in maintenance.tpl
Hello
do you have updated your demo with latest release ?
I staill have this issue on #81 on safari mobile latest ios
Modern prestashop starter theme.pdf
Accessories.pdf
Regards
Hello
I am using your theme with PS 1.7.8.5
On registration form I don't see social title and birthdate field, do you have any idea why ?
I have unable birtdate in Parameters > Customers
I saw that on your demo site social title are not displayed too ? (birtdate I don't know if you have enabled it in bo)
Hello
"Multiple entry point for webpack, files separated per view. There are 4 output js/css files theme, product, checkout, listing and you are able to add more with ease. If you need rich cms pages with a lot of styles included in it. You don't have to include them everywhere with theme output file. You are able to create another entry e.g. cms and just modify assets.yml file to include new assets file."
This is a great feature to improve page loading time but when we activate "Smart cache" in Performance tab the custom css and js files are not included anymore.
Is there a way to activate Smart Cache and keep product/checkout and listing css and js files ?
After validating an order, a smarty exception is thrown on the order confirmation page.
Steps to reproduce the behavior:
The error is explicit, an operator is missing between the first condition $order.subtotals !== null
and the second one $order.subtotals.tax.label !== null
. After adding the operator || (or &, depends of what you expect) in the file /templates/checkout/order-confirmation.tpl, line 110, the page is displayed as expected :)
Screenshots
Hello
I just noticed that in the cart summary page and order page the promo code is missing.
Regards
Hi !
First of all, thanks for your work!
I spent many hours to setup your dev theme under Windows 10 / WSL without any success. Main blocking points are:
Is it possible to deactivates both?
My local webserver is apache2 under WSL (Debian10). I reach local prestashop under vhost (e.g. https://dev.prestashop.fr) from Windows 10. So, in my opinion, launch automatically a webserver must be an option.
Do you have any advise on how to make your dev theme works on Windows 10 / WSL?
Many thanks!
How can i access SwiperSlider from in page declaration? Anyone can help?
If I have a product with just one image, nothing happens when clicking "zoom".
This is printed in the console:
Uncaught (in promise) TypeError: this.mainSliderSwiperInstance is null
handleModalOpen ProductGallery.js:72
Hello,
At first thank you for your work with creating this theme.
I have issue similar to this topic:
#39
If i'm using custom module for order page there is issue with this tag "generateImagesSources".
Module which i'm using is "SZYBKIE ZAKUPY PRO DLA PRESTASHOP 1.7.X" from PrestaDev. I have also try with other module One Page Checkout from Knowband and it's also not working.
You can see error message from debug on attachment.
Do you have any suggestions how could I fix that?
PHP: 7.4
TODO:
Hello,
i think i found an issue on your new management of thumbnails scrolling for product thumbs in product page,
you declare the galleryThumbs.on('afterInitSlider', ({ object, eventName }) => {
after initialisation of the object swiperslider so it never execute your event callback because in the instant of initialisation the thumb swiper there is no event on this emitter.
same issue for this one :
mainSlider.on('afterInitSlider', ({ object, eventName }) => {
this.mainSliderSwiperInstance = mainSlider.SwiperInstance;
});
can you check?
thanks
Hi,
there are issues with filters in category.
If you change number of product per page or sort option and filter after, it reset the configuration of sort and number of products.
If you filter on a feature and you filter on price right after, it reset the previous filters and keep only the price.
Regards,
Cédric
Sometimes when on first slide click prev arrow, image isn't load and background is gray. Tested on demo. This most often occurs after returning to the home page from another page.
When quick viewing a product with images assigned to combinations, the image is not refreshed after selecting a combination.
For example - Hummingbird printed t-shirt, changed from white to black in the quick view popup.
Hi,
It will be more than helpful to be able to set a start + end date for the slides. Imagine promotions that should start on one date and finish on a determined date.
Thanks!
Hi
When more than few items (>4) in the N+1 subcategories, the items list in the header horizontal menu creates an x-axis overflow on the page.
PS 1.7.8.2 (fresh install nothing added/changed except for the starter theme)
PHP 7.3.29
starter theme 2.0.2
is_imageslider-1.0.4
is_searchbar-1.0.0
is_shoppingcart-1.0.0
is_themecore-1.1.2
View of front office with classic theme (no white space at the top of the page):
Changed theme from classic to starter & cleared cache from back office.
View of front office with starter theme (notice that the scroll bar on the right is half way the browser window!):
If you scroll up you see the enormous amount of white space:
PrestaShop version: 1.7.8.2
starter theme 2.0.2
is_themecore-1.1.2
When I try to increase quantity or change combination of the product, form HTML disappear.
product.tpl
<div class="product-information ">
{block name='product_description_short'}
<div id="product-description-short-{$product.id}" class="product-description cms-content">{$product.description_short nofilter}</div>
{/block}
{block name='product_prices'}
{include file='catalog/_partials/product-prices.tpl'}
{/block}
{if $product.is_customizable && count($product.customizations.fields)}
{block name='product_customization'}
{include file="catalog/_partials/product-customization.tpl" customizations=$product.customizations}
{/block}
{/if}
<div class="product-actions js-product-actions mt-3 col-xl-6 p-0">
{block name='product_buy'}
<form action="{$urls.pages.cart}" method="post" id="add-to-cart-or-refresh">
<input type="hidden" name="token" value="{$static_token}">
<input type="hidden" name="id_product" value="{$product.id}" id="product_page_product_id">
<input type="hidden" name="id_customization" value="{$product.id_customization}" id="product_customization_id" class="js-product-customization-id">
{block name='product_variants'}
{include file='catalog/_partials/product-variants.tpl'}
{/block}
{block name='product_pack'}
{if $packItems}
<section class="product-pack">
<p class="h4">{l s='This pack contains' d='Shop.Theme.Catalog'}</p>
<div class="card-group-vertical mb-4">
{foreach from=$packItems item="product_pack"}
{block name='product_miniature'}
{include file='catalog/_partials/miniatures/pack-product.tpl' product=$product_pack showPackProductsPrice=$product.show_price}
{/block}
{/foreach}
</div>
</section>
{/if}
{/block}
{block name='product_discounts'}
{include file='catalog/_partials/product-discounts.tpl'}
{/block}
{block name='product_add_to_cart'}
{include file='catalog/_partials/product-add-to-cart.tpl'}
{/block}
<section class="additional-info d-flex flex-column ml-2 mt-3">
{if $product.reference}
<div class="row"><span class="mr-1">Number: </span> {$product.reference}</div>
{/if}
<section class="">
<dl class="row no-gutters mb-0 ml-n2 mt-2">
{foreach from=$product.grouped_features item=feature}
<dt class="col-3 {if !$feature@last} {/if}">{$feature.name}:</dt>
<dd class="col-7 {if !$feature@last}{/if}">{$feature.value|escape:'htmlall'|nl2br nofilter}</dd>
{/foreach}
</dl>
</section>
{if $product.quantity > 0}
<div class="row mt-1"> <span class="mr-1">Status: </span><span style="color: #03894A; font-weight: 600;">available</span></div>
{/if}
{if $product.delivery_in_stock}
<div class="row mt-1"><span class="mr-1">Estimated delivery time: </span><span class="font-weight-bold"></span></div>
{/if}
<div class="row mt-1"><span class="mr-1">Delivery price: </span><span class="font-weight-bold"> price </span><a class="ml-1" href="">look more</a></div>
</section>
{block name='product_additional_info'}
{include file='catalog/_partials/product-additional-info.tpl'}
{/block}
{* Input to refresh product HTML removed, block kept for compatibility with themes *}
{block name='product_refresh'}{/block}
</form>
{/block}
</div>
</div>
Hello!
I found a typo in the translation line in catalog/_partials/per-page.tpl. I was not able to translate "Per page:", so I changed
{l s='Per page:' l='Shop.Theme.Catalog'}
to
{l s='Per page:' d='Shop.Theme.Catalog'}
Just change the l
and replace it by d
Maybe it would be good to use json-ld implementation from 1.7.8 and classic?
Hello !
For some reason, products swiper stopped to work. I could not swipe products clicking next and prev icons. Also, I had this error message from console :
So in PageSlider.js
I removed && typeof elConfig.navigation === 'undefined'
from this if statement:
if ($nextEl.length && $prevEl.length && typeof elConfig.navigation === 'undefined') {
elConfig = {
...elConfig,
navigation: {
nextEl: $nextEl[0],
prevEl: $prevEl[0],
},
};
}
And now it works. :) But I'm not sure if it's a bug.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.