🐛 [BUG] - is_imageslider some problems about falcon HOT 8 OPEN

now I tried again to insert all the images due to the error reported in point 4 and it made me generate the slide without errors, just when I was making the video :).
I tried again to create a new slide this time it gives me errors in two languages, then I tried to put them back and it makes me save the slide, so it seems that the errors are there on the first try and if I put them back then it makes me save.

Tried on the real website and it is not possible to creare a new slide with 11 languages, with 9 yes

https://watch.screencastify.com/v/11UeESMiPp6CaCUIiu5p

from falcon.

Hi @maofree,

problem with uploading images for 11 languages might be due to limitation of upload_max_filesize or post_max_size on your server. OFC we have to handle this kind of error better with an exception and proper error message.
I am adding this to is_imageslider EPIC

from falcon.

Hi @Oksydan
I think it is necessary to change the way in which the data is saved after pressing the Save button.
From what I've seen, if there are errors, images are not saved and new slides are created.
if I take this site as an example which has 11 languages, to create a slide it would have to save 44 images, 4 per language, 2 jpeg and 2 webp, then in the future if it were to also manage the avif format it would become 6, so it would become very likely to encounter limitations of the server, especially in shared ones.
a simple way to get around this problem is to use a foreach and have it manage texts and images only for one language at a time, so you can save 2-4-6 images at a time without server limit problems.
then there is another problem, that when there are errors, since nothing is saved, every time you have to put back photos and texts for each language and try again, instead if it saves the data for some languages, you could only try again where there are errors.

from falcon.

these are the limits of php, but with litespeed there are other parameters that I don't have access to. However, by managing the data one language at a time, there should no longer be these problems

from falcon.

Hi @maofree,

webp files are not created within upload process. webp files are created on demand.
I am thinking how to change it 🤔. I can make FileType not required so you could be able to upload them separately and it could be the easiest workaround tbh.
On the other hand, I am thinking of adding something like a all langs switch for images. If the all langs switch is checked, we could set this image for each language, but it will only save one file.

from falcon.

Hi @Oksydan
can you tell me where are saved the image associations? in the database this module does not have a table and I don't even think it is in the configuration table. I think what you suggest is correct, because in this way it is possible to replace images, or add new ones if they were not present for some languages, I usually avoid too rigid solutions, because each site and server have different configurations, so it is right to consider more wait

from falcon.

Hi,

are you asking about where are stored images names?
All of them exists in image_slider_lang table and these fields are inside ImageSliderLang ORM Entity

from falcon.

Hi
I had seen those tables, but I thought they were from another module, I thought you used names that started with is_
I didn't check the module code

from falcon.