Comments (8)
Hi
now he answered to me in this mode
The reason the listing is empty is because an error occurs while rendering your theme template with the found product.
First, there is " Undefined array key "listingDisplayType" " in your productlist.tpl, and even when this one is fixed, there is another occurring in the product-thumb.tpl, "Undefined array key "webpEnabled""
I've fixed these two problems adding a default value to those variables (also for pack-product.tpl and products-top.tpl)
Is there a variable I can call in the theme's tpl file to find out if the webp option is active in the module?
from falcon.
removing those line the module doesn't work, it doesn't show products
from falcon.
I commented the lines that avoid the removal of jquery ui, and the error has been resolved, but it doesn't load the products after the selection, perhaps because some hooks have been changed, given that this module expects the same behavior as the faced module
however this module has no problems with falcon
from falcon.
I'm checking the scores on google page speed and now I see that they have worsened by almost 25-30 points, so I will make sure to remove that module and convince the shopkeeper, I don't want poor modules on the site :)
from falcon.
Hi @maofree,
yes, actually it's right about check before unregister if factedsearch module is enabled.
TBH I don't want to use jQuery UI and the reason is performance. It's legacy UI library that we should avoid using.
Version 4 gets rid of jQuery completely, so relying on this kind of library is a bottleneck in terms of performance.
Another problem about advance search is the module way it's loading products is different from core. So every variable assigned by is_themecore is undefined in template.
from falcon.
I would be happy to be able to exclude is_themecore from the theme, or greatly reduce its management, because several things it does, in some cases, are not necessary, like partytown, or webp or changes in the htaccess file
TBH it's not going to happened. This module will always contains core mechanics of the theme and in version 5 it will be even more coupled with the theme.
You can disable web - no htaccess changes.
You can disable partytown - no partytown script will be loaded.
You can almost disable all of it's feature but core stuff have to stay.
Without this module, the assets.yml file will not be parsed, etc.
from falcon.
when I was talking about webp, it was related to the fact that I can use webp management in prestashop, since the module doesn't work on litespeed.
in any case it was just an outlet, because it's not easy to make shopkeepers understand certain things, they understand graphic things and usability more, because they see them, while the rest not much, because they don't realize
from falcon.
Hi @maofree
webEnabled parameter is optional. You can remove it and function will retrieve this information from configuration
from falcon.
Related Issues (20)
- 🚀 [REQUEST] - add decoding="async" together loading="lazy" HOT 3
- 🚀 [REQUEST] - add use fetchpriority to is_imageslider HOT 1
- 🚀 [REQUEST] - Add the arrows in the product-thumbs carousel HOT 3
- [IMPROVEMENT] - into featured-products.tpl it is necessary to set the default slidesPerView for sliderConfig HOT 3
- 🚀 [REQUEST] - Notification when click on add to cart button HOT 2
- 🐛 [BUG] - [FIX] passwords created from the reset page have problems with the next login HOT 3
- 🐛 [BUG] - [Small Fix] In the search results it is necessary to add something to indicate making a choice HOT 1
- 🐛 [BUG] - is_themecore install HOT 4
- 🐛 [BUG] - pattern problem in the address form HOT 3
- Cannot configure image slider module neither uninstall it HOT 4
- 🐛 [BUG] - yarn dev not working HOT 10
- 🐛 [BUG] - pagination is not a function HOT 3
- 🚀 [REQUEST] - Does anyone use Stripe? HOT 1
- 🐛 [BUG] - Compiled theme doesn't allow ajax cart HOT 4
- 🐛 [BUG] - Unable to place order with official stripe module on mobile devices HOT 1
- 🐛 [BUG] - send URL of product not retrieve the main cover picture of item HOT 3
- 🐛 [BUG] - problem with the children's theme HOT 1
- 🐛 [BUG] - Adding discount code fails in checkout step HOT 2
- 🐛 [BUG] - Ajax cart doesn't work HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from falcon.