Comments (6)
It's to do with the ApplyParameters
extension we use. Here's a failing test:
[Fact]
public void DoesNotDropPageFromQueryStringWhenUsingParameters()
{
var uri = new Uri("https://api.github.com/repositories/1/milestones?state=closed&sort=due_date&direction=asc&page=2");
var parameters = new Dictionary<string, string> { { "state", "open" }, { "sort", "other"} };
var actual = uri.ApplyParameters(parameters);
Assert.True(actual.Query.Contains("page=2"));
}
cc @haacked if he wants to look into this fix
from octokit.net.
I've started a PR for this fix here
https://github.com/octokit/octokit.net/tree/milestones-kill-your-rate-limit
I haven't confirmed the milestones client works as expected, but that's easy to chase down now...
from octokit.net.
@haacked @shiftkey i notice 0.1.3 is out. did this one make it into the release?
from octokit.net.
https://github.com/octokit/octokit.net/releases/tag/v0.1.3
"Fixed bug in applying query parameters that could cause paging to continually request the same page"
looks like it. so shall we close this?
from octokit.net.
@SimonCropp Can you try it out?
from octokit.net.
Works on my machine
from octokit.net.
Related Issues (20)
- [DOCS] documentation site 'Edit On GitHub' links return a 404 HOT 6
- [FEAT]: Private Repo access ( get the details of the issues , Code & Bugs ) in C#
- [BUG]: exception "mediatype is null or empty" when trying to delete file HOT 2
- [MAINT]: Clean Up All ~1132 `xUnit` Build Error Warnings HOT 1
- [BUG]: ValidateLINQPadSamples and TearDown Errors
- [BUG]: Failed API calls update response cache HOT 1
- [FEAT]: Download Release archive files
- [FEAT]: Cancel an organization invitation
- [BUG]: WorkflowJobStatus enum does not contain "pending" value. HOT 4
- octokit is missing NuGet package README file
- [BUG]: Error deserializing new issues HOT 18
- [BUG]: Timeout getting multiple renamed repositories when running in NET Framework HOT 1
- [BUG]: Int32 overflow for Github object ids HOT 4
- [FEAT]: Create an organization invitation via email address
- [BUG]: Accessing Pull Requests from all GHE Org Repos (internal included)
- [BUG]: Download Artifact - Content Stores Differing Content-Types Cause Errors HOT 8
- [FEAT]: Implementation for gitHubClient.Branches HOT 1
- [BUG/FEAT]: BranchProtetionPushRestictions Properties Should Be Nullable HOT 1
- [BUG]: Github Enterprise License API fails when parsing temp license HOT 1
- [FEAT]: Codespaces: Add support for creating codespaces and get machine types
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from octokit.net.