Comments (4)
Thanks for the detailed explanation! I've done a little code spelunking internally and I think it's appropriate to add a Pending
value here.
from octokit.net.
@kfcampbell should the existing enum just be extended with a Pending
member, or is the fix to split this into a separate enum WorkflowJobStepStatus
? I didn't see anything int he REST API docs what the legal values for this enum were, and it already has a Waiting
which seems like it would be the same as Pending
?
from octokit.net.
@redoz I'm sorry I'm a bit confused. Your title mentions WorkflowJobStatus
but the description mentions WorkflowJobStep
. Do you mind linking to the documentation you're looking at here?
from octokit.net.
@kfcampbell Sorry for the confusion, I'm getting the error while accessing the Status
property on the WorkflowJobStep
, that property is of type StringEnum<WorkflowJobStatus>
which is the same type of the Status
property on the WorkflowJob
type. It wasn't clear if they are referring to the same status (of the WorkflowJob
), or if the enum is just re-used to represent the state of the WorkflowJobStep
.
I can easily submit a PR to add the Pending
value to this enum, but I wasn't sure if this was the correct fix, or if there is more to this than it seems, given that the enum already has a Waiting
member.
And maybe I'm looking at the wrong place but it seems the step is documented to have the following statuses:
based on this documentation: https://docs.github.com/en/rest/actions/workflow-jobs?apiVersion=2022-11-28
So, before I put effort into submitting a PR, I figured I'd ask for some clarification to make sure it got fixed correctly. I hope that makes more sense, thanks for your time so far!
from octokit.net.
Related Issues (20)
- [FEAT]: Add support for setting the branch protection option "Require approval of the most recent reviewable push"
- [BUG]: missing Rocket & Eyes reactions in ReactionSummary
- [FEAT]: Add support for "required signed commits" feature.
- [FEAT]: Move all types to Octokit namespace HOT 2
- [BUG]: Weird exception
- [FEAT]: Allow Nulls to be Passed to `BranchProtectionRequiredReviewsDismissalRestrictionsUpdate Constructor`
- [DOCS]: ScriptCs.OctoKit is Deprecated/Archived HOT 3
- [BUG]: BranchProtectionSettingsUpdate type is missing a bool property for RequiredSignatures. HOT 2
- [BUG]: class Artifact is in global namespace HOT 5
- [DOCS] documentation site 'Edit On GitHub' links return a 404 HOT 6
- [FEAT]: Private Repo access ( get the details of the issues , Code & Bugs ) in C#
- [BUG]: exception "mediatype is null or empty" when trying to delete file HOT 2
- [MAINT]: Clean Up All ~1132 `xUnit` Build Error Warnings HOT 1
- [BUG]: ValidateLINQPadSamples and TearDown Errors
- [BUG]: Failed API calls update response cache HOT 1
- [FEAT]: Download Release archive files
- [FEAT]: Cancel an organization invitation
- octokit is missing NuGet package README file
- [BUG]: Error deserializing new issues HOT 18
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from octokit.net.