Code Monkey home page Code Monkey logo

Comments (8)

thomhurst avatar thomhurst commented on June 11, 2024

I think this is happening to me as I'm getting a null stream back sometimes.

Is that not an issue with blob storage though? zip isn't a valid MIME type is it?

from octokit.net.

jack0x539 avatar jack0x539 commented on June 11, 2024

I think this is happening to me as I'm getting a null stream back sometimes.

Is that not an issue with blob storage though? zip isn't a valid MIME type is it?

I agree, it's not a valid MIME type, but I'm assuming that those storage servers are way out of the remit of this repository, so there's not a lot that can be done about it from that side.

On this side, however, we could relax the restriction on MIMEs, or we could add a special case for zip, allowing it to be treated as if it was application/zip ?

from octokit.net.

thomhurst avatar thomhurst commented on June 11, 2024

I think this is happening to me as I'm getting a null stream back sometimes.
Is that not an issue with blob storage though? zip isn't a valid MIME type is it?

I agree, it's not a valid MIME type, but I'm assuming that those storage servers are way out of the remit of this repository, so there's not a lot that can be done about it from that side.

On this side, however, we could relax the restriction on MIMEs, or we could add a special case for zip, allowing it to be treated as if it was application/zip ?

Yeah agreed. Adding zip would be easy, I don't see any downside to it. Currently my pipelines are broken because of this issue.

But it's up to the maintainers. Hoping resolution doesn't take ages.

from octokit.net.

thomhurst avatar thomhurst commented on June 11, 2024

Sorry I need to re-open this - The content type is flowing through as null even though it's there:

It's on the headers object:
image

But then the ContentType property to easily access it returns null:
image

from octokit.net.

thomhurst avatar thomhurst commented on June 11, 2024

I'm guessing because it's not a "Standard" format that it doesn't parse it

from octokit.net.

jack0x539 avatar jack0x539 commented on June 11, 2024

from octokit.net.

thomhurst avatar thomhurst commented on June 11, 2024

Oh have you - I've just raised a PR too! Didn't know you were working on it

from octokit.net.

jack0x539 avatar jack0x539 commented on June 11, 2024

from octokit.net.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.