oasisbeatle / pe Goto Github PK

The error message for all the commands in the command list section could be indicated by a WARNING or ERROR icon, it looks a little better in that format rather than a bullet point.

To reproduce the bug type in delete expense -10 as shown:

The exception thrown could be related to invalid index.

The spend command takes in any value of currency. To reproduce enter spend lunch v/5 date/2020-11-08 currency/monkey as shown:

Possible improvement to the feature could be to validate what currency is entered.

1. The page numbers could be included for easier navigatability and reference while bugs are being checked.

2. Bolding the unfamiliar keyword could be done so the user can know to reference the acronym mentioned. Also a hyperlink to the glossary of terms would be quite helpful! Could be done with the keywords "DRY" and "SLOC" as shown below:

The sequence diagram for storage is quite large and hence it breaks across the page. Maybe you could abstract the diagram a little more or create seperate diagrams to show one or two interactions of storage with the commands.

• The purpose of the diagram below is slightly unclear as it is not labelled with the title of the diagram.
• The connection between the enumeration classes and the command classes could be indicated to clarify which commands access the enumeration class while executing.
• I believe the arrow that indicates inheritance could be a bit larger as the arrows right now look kind of like connecting arrows.
• Maybe the size of the diagram could be made larger for easy viewing
• I think that an architechture diagram could have been a little bit better to represent the various commands rather than a UML diagram as there is less complexity involved

I believe the description of the commands could be shortened in the list feature section and replaced with sequence diagrams to make it a little bit clearer

The spend command allows to set a spending task to 0, which is not techincally an expense as it has no value. To reproduce the bug type in spend lunch v/0 date/2020-11-08 currency/SGD as shown:

To improve this bug, the value of zero price could be rejected by the function.

To reproduce the bug, enter add module CS2119 g/A+ mc/4 ay/2021S1 as shown:

However when entered again it accepts the above command and yields the following result:

The inconsistency in this could be improved upon

To reproduce this bug, type in borrow cooking book date/11-12-2012 after executing the same command more than 4 times. It is as shown:

The priority parameter for delete command should accept a positive integer but it returns invalid priority number. To reproduce the bug, type in delete tasks p/4 as shown: