Code Monkey home page Code Monkey logo

Comments (1)

nus-pe-bot avatar nus-pe-bot commented on August 21, 2024

Team's Response

The purpose of the diagram below is slightly unclear as it is not labelled with the title of the diagram.

This diagram is under the Command component section, and the purpose of the diagram should be clear from this - it describes the Command component.

The connection between the enumeration classes and the command classes could be indicated to clarify which commands access the enumeration class while executing.

There does not need to be any links between usage and the enumeration as long as it is stated in the attributes section of the class itself. https://nus-cs2113-ay2021s1.github.io/website/se-book-adapted/chapters/uml.html#enumerations

image.png

I believe the arrow that indicates inheritance could be a bit larger as the arrows right now look kind of like connecting arrows.

I believe you mean they look like the association arrows. However, it is clear that the arrow head is hollow.

Maybe the size of the diagram could be made larger for easy viewing

This is due to the conversion to PDF, but if this is referring to the font size, then this would be a duplicate of #1861

I think that an architechture diagram could have been a little bit better to represent the various commands rather than a UML diagram as there is less complexity involved

Thanks for the suggestion but without justification for how the architecture diagram would be better, I do not think I can accept this.

Items for the Tester to Verify

❓ Issue severity

Team chose [severity.VeryLow]
Originally [severity.Low]

  • I disagree

Reason for disagreement: [replace this with your reason]


from pe.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.