grid: crash when LANG is unset about nwg-launchers HOT 7 CLOSED

I think this should do the job:

std::string get_locale() {
    std::string l {"en"};
    if (getenv("LANG") != NULL) {
        char* env_val = getenv("LANG");
        std::string loc(env_val);
        if (!loc.empty()) {
            if (loc.find("_") != std::string::npos) {
                int idx = loc.find_first_of("_");
                l = loc.substr(0, idx);
            } else {
                l = loc;
            }
        }
    }
    return l;
}

from nwg-launchers.

Damn, I thought this had been fixed in #63 ...

from nwg-launchers.

check if getenv returns NULL, you can't catch that in an exception

from nwg-launchers.

Yeah, I tested by giving $LANG an empty string value. Never happened to me to have $LANG unset.

from nwg-launchers.

You wouldn't find it anyway, because it only happens in freebsd(or linux if you use the same library) because we use a different library for the string class there and it doesn't check if the c string you pass to std::string is NULL when you create one, so we should check it. In linux it checks and throws an std::logic_error.

from nwg-launchers.

2997dc9 works for me:

$ nwggrid
WM: sway
Locale: en
28 .desktop entries found
/home/foo/.config/nwg-launchers/nwggrid/style.css
Focused display: 0, 0, 3840, 2160
Time: 443

from nwg-launchers.

Thanks! Merging, if so.

from nwg-launchers.