Code Monkey home page Code Monkey logo

Comments (5)

jwilder avatar jwilder commented on May 18, 2024

There might be a missing directive in the nginx template. Maybe proxy_pass_header is needed.

from nginx-proxy.

honi avatar honi commented on May 18, 2024

Yes, adding proxy_pass_header Cache-Control; in nginx.tmpl does the trick.

What would be the best approach for using custom templates? It would be nice if we could provide the template with a volume when running nginx-proxy, same way as the certs / htpasswd files.

Having custom templates per VIRTUAL_HOST also sounds reasonable. Are you or anybody else working on this feature?

from nginx-proxy.

md5 avatar md5 commented on May 18, 2024

That doesn't seem right. Cache-Control isn't in the list of headers that are stripped by default and I don't see a proxy_hide_header in the upstream Nginx conf that would make this happen.

I just coded up a quick Sinatra app that returns a Cache-Control header and was able to see the header through nginx-proxy. See here: https://gist.github.com/md5/f83bc66b48981d6db7a0

from nginx-proxy.

honi avatar honi commented on May 18, 2024

You are right @md5, my previous test was incorrect. There is no need for proxy_pass_header.

Though the custom nginx.tmpl feature is still valid I believe.

from nginx-proxy.

jwilder avatar jwilder commented on May 18, 2024

Custom includes was added w/ #106.

from nginx-proxy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.