Code Monkey home page Code Monkey logo

Comments (4)

ivan-aksamentov avatar ivan-aksamentov commented on May 28, 2024 1

@corneliusroemer Associating nucs and AAs is a tough task even for point mutations. Here you'd need to associate ranges. It wasn't forgotten, but it is not shown because this association is simply not implemented.

Do you have an algorithm in mind?

from nextclade.

corneliusroemer avatar corneliusroemer commented on May 28, 2024

I see! Wouldn't it be very similar to deletions? I can see how you do it for deletions and try to port to insertions. Will put it on backlog

from nextclade.

ivan-aksamentov avatar ivan-aksamentov commented on May 28, 2024

Good point. We handle deletions and insertions slightly differently, in that insertions are strippied away. In the code they are handled in very different places and have different data structure. But it might not matter.

I wonder about corner cases like:

  • 1- or 2- nuc insertions - there is no full codon, so no AA insertion. Or is there?
  • what if nuc deletions and insertions are combined (adjacent, interspersed), i.e. indels in their most general case
  • how it plays with frame shifts

from nextclade.

corneliusroemer avatar corneliusroemer commented on May 28, 2024

Right, there may be corner cases, but in practice they will be rare. Associations are only done for the web ui so if there's an occasional odd sequence that should be ok.

Oh I see, it's the whole association that's missing - I first assumed it was just not shown.

1-2 nuc insertion is a frame shift. So we just don't show anything. If deletions and insertions are combined we show both - we already provide AAs for indels and nucs, just not linked to rough nuc position in case of insertions. I don't see a fundamental problem.

Actually, it would be cool to show insertions similarly to the way we show deletions:

No fundamental reason why that isn't possible:
image

Rather than --- at the bottom, you would have --- at the top (or +++ to make it less confusing?)

from nextclade.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.