Comments (9)
srinivasankavitha
commented on July 19, 2024
2
I'm actually looking into this feature currently. Will post an update on
this thread.
…On Wed, Sep 14, 2022 at 12:18 PM James Baxley ***@***.***> wrote:
@paulbakker <https://github.com/paulbakker> did y'all ever implement
something like this? I'm interested in splitting a dgs app into a
multi-module project split by service boundary so there would be extended
types we would want to collect and merge in the main application
—
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ5JPXMD6FO7BNKDSJ2J5F3V6IQJDANCNFSM42VXQMEQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
from dgs-codegen.
paulbakker
commented on July 19, 2024
1
@jbaxleyiii we do exactly that, we have a few schemas containing "common" types, which are shipped in JAR files. Both the Intellij plugin and the framework support this if the schema is in META-INF/schema.
I don't think we ever added it to codegen, because it is less of a common need. We could bring that up again though.
from dgs-codegen.
srinivasankavitha
commented on July 19, 2024
1
The current solution we have is not ideal at all from a devex perspective
(hence the ticket to have the ability to generate types based on schemas in
JAR files). Our federated graph includes a "CommonTypes DGS" that hosts the
schema for such shared types. For code generation purposes, folks end up
downloading that schema from the schema registry to be treated as part of
the local file (purely for code generation). This is then used to generate
common types that are required for code generation. Any common interfaces
are handled the same way.
Having the ability to specify schemas from JAR files for code generation
will eliminate this step and generate all the corresponding types for the
shared/common schema.
…On Sun, Sep 18, 2022 at 5:51 PM James Baxley ***@***.***> wrote:
@srinivasankavitha <https://github.com/srinivasankavitha> how do you
handle shared interfaces? typeMapping doesn't allow you to link to the
generated interface
—
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ5JPXPHZVGURCYOZXKDHJ3V662KNANCNFSM42VXQMEQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
from dgs-codegen.
jbaxleyiii
commented on July 19, 2024
@paulbakker did y'all ever implement something like this? I'm interested in splitting a dgs app into a multi-module project split by service boundary so there would be extended types we would want to collect and merge in the main application
from dgs-codegen.
jbaxleyiii
commented on July 19, 2024
Gotcha! Any recommendations for setup in a multi-module project? One thing I was considering was having a single schema module that creates the generated code for all schemas sourced in the repo but could be used by other modules but not sure how that would scale.
Mainly so since the schema needs to be checked against all other parts for global consistency (i.e. extending a type and not having collisions) so having schemas be part of modules doesn't seem like it would create the ability to do extensions.
edit:
This approach is working but still would love to hear y'alls approach!
from dgs-codegen.
srinivasankavitha
commented on July 19, 2024
For our internal use cases with multi-module projects, we've generally
recommended that code generation plugin be configured for each module
separately with the schemas treated independently. We haven't yet explored
having all the schema in a separate module with the generated code due to
lack of use case. That approach could work I think, but as you mentioned,
it would depend on how large the schema is.
…On Wed, Sep 14, 2022 at 12:53 PM James Baxley ***@***.***> wrote:
Gotcha! Any recommendations for setup in a multi-module project? One thing
I was considering was having a single schema module which creates the
generated code for all schemas sourced in the repo but could be used by
other modules but not sure how that would scale
—
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ5JPXJYUTF4I3UC4OQJPYTV6IUK7ANCNFSM42VXQMEQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
from dgs-codegen.
jbaxleyiii
commented on July 19, 2024
@srinivasankavitha how do you handle shared interfaces? typeMapping doesn't allow you to link to the generated interface
from dgs-codegen.
srinivasankavitha
commented on July 19, 2024
Merged this PR: #468
Will be available in the next release (early next week)
from dgs-codegen.
srinivasankavitha
commented on July 19, 2024
Released in v5.4.0
https://netflix.github.io/dgs/generating-code-from-schema/#generating-code-from-external-schemas-in-jars
from dgs-codegen.
Related Issues (20)
- Generated code for nested input types with default values fails HOT 2
- Type Mapping ignored for input types with nesting HOT 1
- `generateKotlinNullableClasses` should still generate nice `toString` for objects
- Generate generic Pagination API for connections HOT 5
- Client projection of a field with arguments does not return correct projection HOT 1
- The JDK 21 compiler linter flags potential `this-escape` violations in DGS generated code
- Bug when serializing query with scalar of type java.time.Duration and java.time.Period HOT 3
- Generate interfaces for schema types defined in schema in kotlin projects HOT 1
- The "generated-examples" folder is always empty for Kotlin projects HOT 2
- generateJava fails with `Not a valid name: package` HOT 4
- Is the official document of generating codes outdated? or some classes are not auto-generated? HOT 1
- Generated Java-classes naming convention HOT 1
- Generating code from external schemas in JARs - META-INF requirement HOT 6
- Variable declaratino missing wenn miltiple operations are used
- Generate Deprecated Annotation For Queries HOT 1
- Fields with capital letters in the beginning are not deserialised by jackson. java
- Code is not compiling after aliases were added to projections HOT 3
- GraphQL interfaces should still be annotated when using the `@annotate` directive
- How to generate data class with "no arg constructor" and setter? (or a data class with builder) HOT 1
- Polymorphic Interfaces with default implementation HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dgs-codegen.