Bug when serializing query with scalar of type java.time.Duration and java.time.Period about dgs-codegen HOT 3 CLOSED

Can you try passing in the map of custom scalars as described here: https://netflix.github.io/dgs/advanced/java-client/#scalars-in-dgs-client

We need this information to know how to serialize scalars for queries.

from dgs-codegen.

Thanks! Your advice worked for us and we were able to correctly serialize GraphQL fields of type Period and Duration.
However, apart from implementing those 3 methods for custom scalars that are mentioned on https://netflix.github.io/dgs/scalars/ we also have to implement "valueToLiteral" method in our scalars like this:

@Override
@NotNull
public Value valueToLiteral(@NotNull Object input) {
    return new StringValue(this.serialize(input));
}

It would be good if the docs clearly stated somewhere, that it is needed to to implement "valueToLiteral" method if custom serialization is needed for the scalar.

Thanks again!

from dgs-codegen.

Thanks for the callout, we will update our docs accordingly!

from dgs-codegen.