Generate generic Pagination API for connections about dgs-codegen HOT 5 OPEN

@JLLeitschuh you're right - when creating the projections I was converting the type to kotlin first & then deriving the name of the projection by picking the innermost type. Obviously this failed if it found a mapped generic type & picked the inner type of the edge instead of the connection.

This should fix it by looking instead at the name of the GQL type itself for determining the name of the projection, effectively ignoring the mapped types when building the client. I updated one of the examples to use the relay mapping as well to confirm the behavior: #642

from dgs-codegen.

@mbossenbroek - could you please take a look when you get a chance?

from dgs-codegen.

@srinivasankavitha looks like the build passed on that PR; feel free to merge/release at your convenience

from dgs-codegen.

Does SimpleListConnection work for client types? I'm hoping it does.

Also, couldn't DGS automatically detect pagination structures and auto-generate the correct paginated API for the model types?

from dgs-codegen.

I'm not sure I follow what you mean by this:

Does SimpleListConnection work for client types?

You can specify that you'd like to use that class instead of the generated ones & it will put it in there. As to whether or not it deserializes correctly depends on the json library you're using.

Also, couldn't DGS automatically detect pagination structures and auto-generate the correct paginated API for the model types?

There is no specified "correct" paginated type as GQL doesn't specify that sort of thing. There are the relay types you found, which can certainly be used, but they have some faults of their own. Namely, they won't differentiate between explicit null fields and those that are simply not requested. Left alone, the code-gen will generate the appropriate pagination structures for a client without having to involve the relay classes.

from dgs-codegen.