Comments (5)
mbossenbroek
commented on July 19, 2024
1
Yeah, I just missed the escaping in that spot. This PR fixes it & confirms with the example above: #604
Feel free to merge/release at your leisure. Apologies for the delay there - I was out sick the past few days.
from dgs-codegen.
srinivasankavitha
commented on July 19, 2024
The generated code you posted does not seem to be from the dgs-codegen
plugin. This is what I see for the schema you posted:
```
public data class Person(
@com.fasterxml.jackson.`annotation`.JsonProperty("reserved")
public val reserved: kotlin.String,
) {
public companion object
}
```
The above compiles fine. Could you please check your set up again?
…On Sun, Sep 24, 2023 at 6:14 PM luke.89 ***@***.***> wrote:
If the field in the input schema is a reserved word, the Pair value of the
fields method of the generated code is missing a backup (`) resulting in a
compilation error.
Is there any way to solve the above issue?
Example Input Schema:
input SampleInput {
return: String!
}
Generated Code:
public class SampleInput(
public val `return`: String,
) : GraphQLInput() {
public override fun fields(): List<Pair<String, Any?>> = listOf("return" to return)
}
—
Reply to this email directly, view it on GitHub
<#602>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ5JPXM7IDJXWBJR3GL4D4DX4DLGVANCNFSM6AAAAAA5FKMM2Y>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
from dgs-codegen.
dkswjdals89
commented on July 19, 2024
@srinivasankavitha
The issue related to reserved keyword field names occurs when generating code for the Client API.
The dgscode set for the gradle is as follows.
schemaPaths = mutableListOf("$projectDir/src/main/resources/schema/services.graphql")
generateClient = true
packageName = "com.****.****.domain.generated"
generateDataTypes = true
snakeCaseConstantNames = true
generateKotlinClosureProjections = true
generateKotlinNullableClasses = true
language = "kotlin"
It appears that the problematic generated code is located under the 'dgs-codegen' folder, indicating that it is indeed generated by 'dgs-codegen'.
from dgs-codegen.
srinivasankavitha
commented on July 19, 2024
Oh I see, that's helpful. I didn't realize you were using generateKotlinClosureProjections for Client API.
@mbossenbroek - do we handle reserved keywords?
from dgs-codegen.
dkswjdals89
commented on July 19, 2024
@srinivasankavitha
Thank you. 👍🏼
Do you happen to know when the version release is scheduled?
from dgs-codegen.
Related Issues (20)
- Generate generic Pagination API for connections HOT 5
- Client projection of a field with arguments does not return correct projection HOT 1
- The JDK 21 compiler linter flags potential `this-escape` violations in DGS generated code
- Bug when serializing query with scalar of type java.time.Duration and java.time.Period HOT 3
- Generate interfaces for schema types defined in schema in kotlin projects HOT 1
- The "generated-examples" folder is always empty for Kotlin projects HOT 2
- generateJava fails with `Not a valid name: package` HOT 4
- Is the official document of generating codes outdated? or some classes are not auto-generated? HOT 1
- Generated Java-classes naming convention HOT 1
- Generating code from external schemas in JARs - META-INF requirement HOT 6
- Variable declaratino missing wenn miltiple operations are used
- Generate Deprecated Annotation For Queries HOT 1
- Fields with capital letters in the beginning are not deserialised by jackson. java
- Code is not compiling after aliases were added to projections HOT 3
- GraphQL interfaces should still be annotated when using the `@annotate` directive
- How to generate data class with "no arg constructor" and setter? (or a data class with builder) HOT 1
- Polymorphic Interfaces with default implementation HOT 3
- Support Custom Serialization for Date Fields in InputValueSerializer
- Error generating classes from generateClientApi or generateClientApiV2 HOT 9
- generating Java types failed with $ in graphql schema comment on interface
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dgs-codegen.