multy-io / multy-back Goto Github PK

It is not obvious that Address in configuration means.

All third-party dependencies should be located either within this repository (as submodules, subtrees, anything else) or hosted on Appscrunch's github. In rare case when moving a dependency to our github is too complicated or takes too much time, leave it at original location, but under no condition you should not refer to developer's private repository.

https://github.com/Appscrunch/Multy-back/blob/d11d67f6b099529f9ce76bf9695493e6fb1c3cf3/multy-back.go#L10

Errors are not handled (particularly in Ether case):

EventGetAdressNonce errors are simply ignored (if EventGetAdressBalance has nil error):

GetAllWalletEthTransactions simply not handled

This image is built and deployed successfully, but fail to run:

$ docker run multyio/multy-back
/bin/sh: /multy/multy-back: not found

Because:

https://stackoverflow.com/questions/34729748/installed-go-binary-not-found-in-path-on-alpine-linux-docker

CC @Enmk

Need asyncronous /server/status endpoint page showing status of various application components to track initialization problems. This page should be responsive even before DB and NS services initialization starts.

Having all cryptocurrency-specific settings in flat structure is not too nice, since we are going to support many blockchains\backends and that would become really ugly really fast.

Please introduce some sort of scope for each blockchain configuration data.

https://github.com/Appscrunch/Multy-back/blob/d11d67f6b099529f9ce76bf9695493e6fb1c3cf3/config.go#L14-L15

• Fix typo: NodeCommuunications:
  

  Multy-back/node-streamer/eth/streamer.proto

  Line 5 in 53b5704

  service NodeCommuunications {

• Remove unnecessary curly braces for rpc declaration
  

  Multy-back/node-streamer/eth/streamer.proto

  Lines 7 to 8 in 53b5704

  	rpc ServiceInfo (Empty) returns (ServiceVersion){
  	}

• Remove unnecessary Event prefixes for rpc endpoints:
  

  Multy-back/node-streamer/eth/streamer.proto

  Line 13 in 53b5704

  rpc EventInitialAdd (UsersData) returns (ReplyInfo){

• Rename AddressToResync to address, 'cause it's just an address:
  

  Multy-back/node-streamer/eth/streamer.proto

  Lines 133 to 135 in 53b5704

  	message AddressToResync {
  	string address = 1;
  	}

• Remove reply info, 'cause gRPC returns golang errors
  

  Multy-back/node-streamer/eth/streamer.proto

  Lines 150 to 155 in 53b5704

  	message ReplyInfo {
  	string message = 1;
  	}
  	message ServiceVersion {
  	string branch = 1;

• Remove unnecessary wallet info (WalletIndex, WalletIndex) from node service, it should be tracked on main, Multy-Back service:
  

  Multy-back/node-streamer/eth/streamer.proto

  Lines 145 to 147 in 53b5704

  	int32 WalletIndex = 2;
  	int32 AddressIndex = 3;
  	}

• Use Google.Protobuf.WellKnownTypes.Empty instead of redeclaring Empty message
• Use protobuf style guide for names - no CamelCase field names, only underscore_case

Right now if there is no connection to database, backend just dumps configuration and hangs with no activity. If there is no connection, it should at least give a first warning.

multy-back        | aaaaaaaaaaa
multy-back        | 2018-11-20/08:19:32.427 [ERROR] main: --------------------------------new multy back server session 
multy-back        | 2018-11-20/08:19:32.428 [INFO] main: CONFIGURATION={Name:Multy-Stage 
Database:{Address:mongodb:27000 DBUsers:userDB ... IOS:{Hard:0 Soft:0}}} 
multy-back        | 2018-11-20/08:19:32.428 [INFO] main: branch: dev 
multy-back        | 2018-11-20/08:19:32.428 [INFO] main: commit: 9e7cf01 
multy-back        | 2018-11-20/08:19:32.428 [INFO] main: build time: 2018-11-18T08:31:52+0000 
multy-back        | 2018-11-20/08:19:32.428 [INFO] main: tag:  

According to Go's naming convention factory function should be NewUserStore instead of InitUserStore
https://golang.org/doc/effective_go.html#composite_literals

https://github.com/Appscrunch/Multy-back/blob/d11d67f6b099529f9ce76bf9695493e6fb1c3cf3/store/store.go#L61

This is needed for healthcheck of our images before deploy to prevent things like #124.

Multy on startup dumps config with some password data. This is no good. Password can reveal two first symbols for identification purposes and be at least 12 symbols.

TableMempoolRatesETHTest: TableTxsDataETHTest:TableTxsDataETHTest 
DBRestoreState:RestoreState TableState:LastState Username:multy Password:17*********} 
SocketioAddr:0.0.0.0:6780 RestAddress:0.0.0.0:6778 Firebase:{Type: ProjectID: PrivateKeyID: 
PrivateKey: ClientEmail: ClientID: AuthURI: TokenURI: AuthProviderX509CertURL: 
ClientX509CertURL:} NSQAddress:0.0.0.0:1150 BTCNodeAddress:localhost:18334 
DonationAddresses:[{FeatureCode:10000 
DonationAddress:1FPv9f8EGRDNod7mSvJnUFonUioA3Pw5ng}