multy-io / multy-back Goto Github PK

View Code? Open in Web Editor NEW

27.0 16.0 13.0 46.52 MB

Back-end of the Multy - mobile multy-blockchain wallet.

License: Other

Makefile 0.47% Go 99.27% Dockerfile 0.26%

blockchain bitcoin btc-node ethereum

multy-back's Introduction

Docker images: https://hub.docker.com/r/multyio/multy-back/tags/

Multy-back

Back end server for Multy application

Usage Instructions

In all cases you would like to set configuration parameters in multy.config file with addresses, passwords, tokend and other settings. Note, that configuration file must be located in the same directory as the binary file.

From source

For building Multy-back, in Multy-back directory run:

make all-with-deps

After that in cmd directory binary file with name multy should appear.

To run a server:

make run

Notice, that program uses NSQ, MongoDB and BTC RPC API. You should install and run it by yourself.

From docker-compose

In docker-compose file (multy-back service) set volumes: multy.config and rpc.cert (for btc node).

If you want to use btc node from docker container, uncomment btcd-testnet part o fdocker-compose file and set its address in BTCNodeAddress field in cmd/multy.config.

To run a server:

docker-compose up

API

For API documentation, see https://godoc.org/github.com/Multy-io/Multy-back

multy-back's People

Contributors

Stargazers

Watchers

Forkers

kristinaetc cnliving jekabolt goku-xun vovapi srgtcauliflour enmk abitrolly thepowerofswift ricburton pashaklybik bspanda98 zzpu

multy-back's Issues

Fix for multy: line 1: /multy/multy-back: not found

This image is built and deployed successfully, but fail to run:

Multy-back/Dockerfile

Lines 24 to 27 in 822857b

    
           FROM base as multy-back 
        
           WORKDIR /multy 
        
           COPY --from=builder /go/src/github.com/Multy-io/Multy-back/cmd/multy-back/multy-back /multy/multy-back 
        
           ENTRYPOINT /multy/multy-back

$ docker run multyio/multy-back
/bin/sh: /multy/multy-back: not found

Because:

https://stackoverflow.com/questions/34729748/installed-go-binary-not-found-in-path-on-alpine-linux-docker

CC @Enmk

Make /server/status endpoint visible as soon as service starts

Need asyncronous /server/status endpoint page showing status of various application components to track initialization problems. This page should be responsive even before DB and NS services initialization starts.

Move cryptocurrency-specific configuration to sub-object

Having all cryptocurrency-specific settings in flat structure is not too nice, since we are going to support many blockchains\backends and that would become really ugly really fast.

Please introduce some sort of scope for each blockchain configuration data.

https://github.com/Appscrunch/Multy-back/blob/d11d67f6b099529f9ce76bf9695493e6fb1c3cf3/config.go#L14-L15

Show error in logs when DB connection failed

Right now if there is no connection to database, backend just dumps configuration and hangs with no activity. If there is no connection, it should at least give a first warning.

multy-back        | aaaaaaaaaaa
multy-back        | 2018-11-20/08:19:32.427 [ERROR] main: --------------------------------new multy back server session 
multy-back        | 2018-11-20/08:19:32.428 [INFO] main: CONFIGURATION={Name:Multy-Stage 
Database:{Address:mongodb:27000 DBUsers:userDB ... IOS:{Hard:0 Soft:0}}} 
multy-back        | 2018-11-20/08:19:32.428 [INFO] main: branch: dev 
multy-back        | 2018-11-20/08:19:32.428 [INFO] main: commit: 9e7cf01 
multy-back        | 2018-11-20/08:19:32.428 [INFO] main: build time: 2018-11-18T08:31:52+0000 
multy-back        | 2018-11-20/08:19:32.428 [INFO] main: tag:

Protobuf refactor proposal

Fix typo: NodeCommuunications:

Multy-back/node-streamer/eth/streamer.proto

Line 5 in 53b5704

service NodeCommuunications {
Remove unnecessary curly braces for rpc declaration

Multy-back/node-streamer/eth/streamer.proto

Lines 7 to 8 in 53b5704

rpc ServiceInfo (Empty) returns (ServiceVersion){

}
Remove unnecessary Event prefixes for rpc endpoints:

Multy-back/node-streamer/eth/streamer.proto

Line 13 in 53b5704

rpc EventInitialAdd (UsersData) returns (ReplyInfo){
Rename AddressToResync to address, 'cause it's just an address:

Multy-back/node-streamer/eth/streamer.proto

Lines 133 to 135 in 53b5704

message AddressToResync {

string address = 1;

}

Remove reply info, 'cause gRPC returns golang errors

Multy-back/node-streamer/eth/streamer.proto

Lines 150 to 155 in 53b5704

    
           message ReplyInfo { 
        
               string message = 1; 
        
           } 
        
           message ServiceVersion { 
        
               string branch = 1;

Remove unnecessary wallet info (WalletIndex, WalletIndex) from node service, it should be tracked on main, Multy-Back service:

Multy-back/node-streamer/eth/streamer.proto

Lines 145 to 147 in 53b5704

int32 WalletIndex = 2;

int32 AddressIndex = 3;

}
Use Google.Protobuf.WellKnownTypes.Empty instead of redeclaring Empty message
Use protobuf style guide for names - no CamelCase field names, only underscore_case

`multy status` command to run show some data and exit

This is needed for healthcheck of our images before deploy to prevent things like #124.

Rename Address to DBAddress or MongoAddress

It is not obvious that Address in configuration means.

Move third-parties dependencies to the Appscrunch github.

All third-party dependencies should be located either within this repository (as submodules, subtrees, anything else) or hosted on Appscrunch's github. In rare case when moving a dependency to our github is too complicated or takes too much time, leave it at original location, but under no condition you should not refer to developer's private repository.

https://github.com/Appscrunch/Multy-back/blob/d11d67f6b099529f9ce76bf9695493e6fb1c3cf3/multy-back.go#L10

Stick to convention for factory functions

According to Go's naming convention factory function should be NewUserStore instead of InitUserStore
https://golang.org/doc/effective_go.html#composite_literals

https://github.com/Appscrunch/Multy-back/blob/d11d67f6b099529f9ce76bf9695493e6fb1c3cf3/store/store.go#L61

getWalletVerbose: errors are not handled

Errors are not handled (particularly in Ether case):

EventGetAdressNonce errors are simply ignored (if EventGetAdressBalance has nil error):

Multy-back/client/rest.go

Lines 1404 to 1409 in 527bb21

    
           case currencies.ETHTest: 
        
           	nonce, err = restClient.ETH.CliTest.EventGetAdressNonce(context.Background(), &adr) 
        
           	amount, err = restClient.ETH.CliTest.EventGetAdressBalance(context.Background(), &adr) 
        
           case currencies.ETHMain: 
        
           	nonce, err = restClient.ETH.CliMain.EventGetAdressNonce(context.Background(), &adr) 
        
           	amount, err = restClient.ETH.CliMain.EventGetAdressBalance(context.Background(), &adr)

GetAllWalletEthTransactions simply not handled

Multy-back/client/rest.go

Line 1434 in 527bb21

    
           err = restClient.userStore.GetAllWalletEthTransactions(user.UserID, currencyId, networkId, &userTxs)

Passwords are exposed in logs at startup

Multy on startup dumps config with some password data. This is no good. Password can reveal two first symbols for identification purposes and be at least 12 symbols.

TableMempoolRatesETHTest: TableTxsDataETHTest:TableTxsDataETHTest 
DBRestoreState:RestoreState TableState:LastState Username:multy Password:17*********} 
SocketioAddr:0.0.0.0:6780 RestAddress:0.0.0.0:6778 Firebase:{Type: ProjectID: PrivateKeyID: 
PrivateKey: ClientEmail: ClientID: AuthURI: TokenURI: AuthProviderX509CertURL: 
ClientX509CertURL:} NSQAddress:0.0.0.0:1150 BTCNodeAddress:localhost:18334 
DonationAddresses:[{FeatureCode:10000 
DonationAddress:1FPv9f8EGRDNod7mSvJnUFonUioA3Pw5ng}

	FROM base as multy-back
	WORKDIR /multy
	COPY --from=builder /go/src/github.com/Multy-io/Multy-back/cmd/multy-back/multy-back /multy/multy-back
	ENTRYPOINT /multy/multy-back

	message ReplyInfo {
	string message = 1;
	}

	message ServiceVersion {
	string branch = 1;

	case currencies.ETHTest:
	nonce, err = restClient.ETH.CliTest.EventGetAdressNonce(context.Background(), &adr)
	amount, err = restClient.ETH.CliTest.EventGetAdressBalance(context.Background(), &adr)
	case currencies.ETHMain:
	nonce, err = restClient.ETH.CliMain.EventGetAdressNonce(context.Background(), &adr)
	amount, err = restClient.ETH.CliMain.EventGetAdressBalance(context.Background(), &adr)

	rpc ServiceInfo (Empty) returns (ServiceVersion){
	}

	int32 WalletIndex = 2;
	int32 AddressIndex = 3;
	}