Code Monkey home page Code Monkey logo

mrgreensworkshop / mrgreen-jekylltheme Goto Github PK

View Code? Open in Web Editor NEW
140.0 3.0 283.0 2.2 MB

Mr. Green is a multilingual theme generated with Jekyll and fully compatible with GitHub Pages.

Home Page: https://jekyll-theme-mrgreen-demo.mrgreensworkshop.com

License: MIT License

Ruby 0.33% HTML 36.76% Liquid 12.46% SCSS 30.59% JavaScript 19.87%
jekyll jekyll-theme jekyll-themes jekyll-website jekyll-blog jeykll-template jekyll-site responsive-web-design darkmode static-site

mrgreen-jekylltheme's Introduction

[English] [日本語]

Mr. Green's Workshop

Mr. Green's Workshop creates projects and content related to Software, Electronics, and Mechanics.

Mr. Green's Workshop

Visitor Count Follower Count Support me on Github Sponsors Support me on Patreon Tip me via Ko-fi

Web Site Youtube Instagram Twitter Mastodon

Motivation

I have worked in different fields and gained different experiences. I think it's time to give something back. My father always used to say, "Pay the tax on what you have learned by sharing it with others.".

Why Workshop?

As a maker, I like projects that involve software, electronic circuits, and mechanics individually or in combination, so I think the word "Workshop" is the best fit.

Sponsorship

Creating projects themselves don't pay the bills. It takes a lot of time and efforts to create and maintain projects. I hope you consider supporting me so that I can continue my work and creating new contents for everyone.

Sponsors

My sponsors! Thank you for supporting me.

Josh Buker

Languages, tools etc.

Languages and Frameworks C  C++  .NET  C#  Visual Basic  Java  Swift  python  SQL  SQLite  Ladder Logic 
Languages and Frameworks (Web) CSS  SASS  HTML  JavaScript  Jquery  MySQL  jekyll  Django 
Target OSes iOS  Android  Linux  MS Windows 
Target Embedded OSes, Platforms Arm Mbed OS  Zephyr OS  PlatformIO  Raspberry Pi  Arduino 
Tools and Editors Visual Studio  VS Code  Android Studio  Xcode  Github  bash  Homebrew  ssh  Vim  Vagrant 
Simulators NI Labview  NI Multisim  MATLAB 
CAD tools AutoCAD  Ultimaker  Cura 

mrgreen-jekylltheme's People

Contributors

fandangos avatar joshbuker avatar mrgreensworkshop avatar teshiba avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

mrgreen-jekylltheme's Issues

Home layout header picture using img tag

Is your feature request related to a problem? Please describe.

Currently home layout header picture set as background image.

  • it's better to give an option to choose background img and img tag.
  • It's better to have header picture disable option.

Describe the solution you'd like

  • choose which tag will be used in home layout
  • img tag enable / disable option in _data/conf/others.yml
  • img file will be disabled if img line is commented
# image for page specific usage
#img: ":home-heading.jpg"

Describe alternatives you've considered

none

Additional context

none

Giscus support

Is this enhancement or feature is related to a problem?

Thanks for making this awesome theme and making it open source. All the themes I could find were very minimalist.

https://giscus.app/ or https://github.com/giscus/giscus is a recent alternative to discus. It is free, open source, privacy focused and uses GitHub discussions.

Add giscus support to this theme.

Describe the solution you'd like

I can add it very easily using the steps at https://giscus.app/ but I myself can't do fine changes like configure such that when the dark toggle is clicked the giscus comments also change the theme. But I guess you will be able to do this. So official support is better. by default you can keep disqus but give the option to change to giscus in the config file or somewhere.

Thanks.

Describe alternatives you've considered

No response

Additional context

No response

Individual style for modules using sliding box

Is this enhancement or feature is related to a problem?

Cookie-consent setting box and language offer box styles set individually.
also some enhancement for mobile devices. (narrow width)

Describe the solution you'd like

With this approach we can use different styling for cookie-consent setting box and language offer box and newly created boxes.

Describe alternatives you've considered

none

Additional context

none

better readability for posts

Is your feature request related to a problem? Please describe.

line height spacing and spacing before and after headers not enough.
applies in blog posts, about page, home page where markdown-style were used.

Describe the solution you'd like

better spacing for markdown-styles

Describe alternatives you've considered

none

Additional context

none

Bump Up github-pages version

Is this enhancement or feature is related to a problem?

Looks like github-pages version is updated to 227
https://pages.github.com/versions/

Describe the solution you'd like

Change github-pages gem version from 226 to 227 in gemfile

Describe alternatives you've considered

No response

Additional context

No response

Mastodon icon for contacts links

Is this enhancement or feature is related to a problem?

I think it's better to have the mastodon icon for the contact option.

Describe the solution you'd like

Since the mastodon icon is not available in Font Awesome 4.7.0, I added an svg file for it.

The mastodon icon was obtained from mastodon repo

Describe alternatives you've considered

none

Additional context

none

Source code version wasn't updated.

Please check these items before go any further

  • I have watched Mr. Green theme tutorials playlist on YouTube.
  • I have searched the existing Issues.
  • I have searched the existing Discussions.
  • I have checked jekyll docs and the answer was not there.
  • I have tested in one of these browsers; Safari, Chrome, Firefox. (This project hasn't been tested in other browsers.)

Are you sure this is a bug?

  • I'm sure this is definitely a bug.

Describe the bug

The version written in source files is 1.1.0.
The current release version is 1.2.1.

Expected Behavior

release version should be 1.2.1.

Steps To Reproduce

Which browser have you used?

  • Chrome
  • Safari
  • Firefox
  • Other browsers (This project hasn't been tested in other browsers.)

Which device have you used?

  • Desktop
  • Mobile IOS
  • Mobile Android
  • Other platforms (This project hasn't been tested in other devices.)

Anything else?

I think I will remove version information because, even if I automate this, it creates many differences with forked repositories. so it is not nice.

Comments for image_viewer_on and image_lazy_loader_on

Is your feature request related to a problem?

These comments are common all pages and blog posts. Pages (non blog posts) also have same explanation.
If its not post, this comment is not accurate.

# optional
# if you enabled image_viewer_posts you don't need to enable this. This is only if image_viewer_posts = false
#image_viewer_on: true
# if you enabled image_lazy_loader_posts you don't need to enable this. This is only if image_lazy_loader_posts = false
#image_lazy_loader_on: true

Describe the solution you'd like

I want to keep using the same comments on all pages, so this is what I've come up with.

# please use the "image_viewer_on" below to enable image viewer for individual pages or posts (_posts/ or [language]/_posts folders). 
# image viewer can be enabled or disabled for all posts using the "image_viewer_posts: true" setting in _data/conf/main.yml.
#image_viewer_on: true
# please use the "image_lazy_loader_on" below to enable image lazy loader for individual pages or posts (_posts/ or [language]/_posts folders). 
# image lazy loader can be enabled or disabled for all posts using the "image_lazy_loader_posts: true" setting in _data/conf/main.yml.
#image_lazy_loader_on: true

Describe alternatives you've considered

No response

Additional context

No response

When the theme is used with only one language, the consent box doesn't work

Please check these items before go any further

  • I have watched Mr. Green theme tutorials playlist on YouTube.
  • I have searched the existing Issues.
  • I have searched the existing Discussions.
  • I have checked jekyll docs and the answer was not there.
  • I have tested in one of these browsers; Safari, Chrome, Firefox. (This project hasn't been tested in other browsers.)

Are you sure this is a bug?

  • I'm sure this is definitely a bug.

Describe the bug

When the theme is used with only one language, the consent box doesn't work.
Also, this error occurs.
Screenshot 2022-12-15 at 18 34 44

Expected Behavior

The consent box should work whether one language is used or more than one language is used.

Steps To Reproduce

  1. Delete the other language folders. (ja, pt)
  2. Delete _data/content/projects/ (ja.yml, pt.yml)
  3. Delete _data/lang/ (ja.yml, pt.yml)
  4. Delete _data/owner/ (ja.yml, pt.yml)
  5. Open _data/conf/main.yml
  6. Find language_switch_lang_list and set it to language_switch_lang_list: [en]
  7. Use bundle exec jekyll serve --watch --safe to run locally
  8. Open http://127.0.0.1:4000
  9. The consent box will not be shown.

Which browser have you used?

  • Chrome
  • Safari
  • Firefox
  • Other browsers (This project hasn't been tested in other browsers.)

Which device have you used?

  • Desktop
  • Mobile IOS
  • Mobile Android
  • Other platforms (This project hasn't been tested in other devices.)

Anything else?

No response

The type of sliding box animation could be changed from its init function

Is this enhancement or feature is related to a problem?

SlidingMsgBox were used for language_translation_offer_box feature and cookie consent box.
However, the slide type is set as shown below. (It looks like it's only used for language_translation_offer_box)

{%- capture sliding_msg_box_html -%}
<div class="slideBox {{ site.data.conf.main.language_translation_offer_slide }}">
<a class="close-button" href="javascript:void(0);"><i class="fa-fw fa fa-times"></i></a>
</div>
{%- endcapture -%}

This could be easily misunderstood, as I did before. #135  

Describe the solution you'd like

It may be possible to correct the misconfiguration by setting the slide type of the sliding box in its init function.

With this, we can individually set the slide type for both the language offer box and the cookie consent setting box at _data/conf/main.yml.

Describe alternatives you've considered

none

Additional context

none

Couldn't find the issue you created?

Probably moved to Discussions or deleted because the Issue wasn't filled out according to the template.

The Issues in this repository are only used to track 'Bug report' or 'Enhancement or Feature'.

update github-pages version

Is your feature request related to a problem? Please describe.

update github-pages gems version.
gem "github-pages", "~> 223" to gem "github-pages", "~> 226"

https://pages.github.com/versions/

Describe the solution you'd like

edit Gemfile

Describe alternatives you've considered

none

Additional context

none

version update

Is your feature request related to a problem? Please describe.

version update

Describe the solution you'd like

update version numbers

Describe alternatives you've considered

none

Additional context

none

Making markdown-style avaible for about and home layouts.

Is your feature request related to a problem? Please describe.

Quoted text color is red which is not good color for gray color based layout. By default markdown-style not available for about and home layouts.

Screen Shot 2022-06-15 at 15 49 44

Screen Shot 2022-06-15 at 15 50 29

Describe the solution you'd like
if markdown-style is available for about and home layouts should look like this.

Screen Shot 2022-06-15 at 15 49 49

Screen Shot 2022-06-15 at 15 51 54

Describe alternatives you've considered

none

Additional context

none

Seo enhancement

Is your feature request related to a problem? Please describe.

According to Online Seo site checkers.

  1. if <title> tag is too long. search engines doesn't like it.
  2. No H1 tag in blog post pages.
  3. search engines likes hreflang in html rather sitemap.xml.

Describe the solution you'd like

  1. for any pages truncate title to 60 chars. if page is blog post then don't add site brand to title.
  2. add H1 tag to blog post pages.
  3. enable hreflang in main.yml and disable in sitemap.xml

Describe alternatives you've considered

none

Additional context

none

Workflows runs on forked repos.

Please check these items before go any further

  • I have watched Mr. Green theme tutorials playlist on YouTube.
  • I have searched the existing Issues.
  • I have searched the existing Discussions.
  • I have checked jekyll docs and the answer was not there.
  • I have tested in one of these browsers; Safari, Chrome, Firefox. (This project hasn't been tested in other browsers.)

Are you sure this is a bug?

  • I'm sure this is definitely a bug.

Describe the bug

As discussion 170 suggests, build-test runs on forked repositories.

Originally posted by burninghering February 7, 2023
image
Github actions give me these issues. can you give me a solution?

Expected Behavior

None of the workflows must be running at a forked repository.

Steps To Reproduce

  1. Fork the repo
  2. Push the changes
  3. Check Actions tab on Github

Which browser have you used?

  • Chrome
  • Safari
  • Firefox
  • Other browsers (This project hasn't been tested in other browsers.)

Which device have you used?

  • Desktop
  • Mobile IOS
  • Mobile Android
  • Other platforms (This project hasn't been tested in other devices.)

Anything else?

No response

French language support

Is this enhancement or feature is related to a problem?

French language translations.

Describe the solution you'd like

French language translations.

Describe alternatives you've considered

No response

Additional context

No response

When privacy-policy.md removed related text still visible

Describe the bug
When privacy-policy.md removed (deleted or disabled with published: false)
visible in "Consent bar" and "Cookie settings"

Screenshots

privacy-policy.md exist
before

privacy-policy.md removed or disabled
after

To Reproduce
Steps to reproduce the behavior:

  • remove privacy-policy.md (deleted or disabled with published: false)
  • build locally or on github
  • check "Consent bar" or "Cookie settings"

Expected behavior

Text "Check" should be removed.
expected

Desktop (please complete the following information):
all

Mobile devices (please complete the following information):
all

Additional context

About page subtitle is not replaced with constant

Describe the bug
About page subtitle is not replaced with constant ($site_sample)

Screen Shot 2022-06-14 at 14 18 09

To Reproduce
Steps to reproduce the behavior:

  • build locally or on github
  • open about page

Expected behavior

Screen Shot 2022-06-14 at 14 17 23

Screenshots
Added to description

Desktop (please complete the following information):
all
Smartphone (please complete the following information):
all
Additional context

Adding Brazilian Portuguese language

Is this enhancement or feature is related to a problem?

Brazilian Portuguese language

Describe the solution you'd like

Brazilian Portuguese language

Describe alternatives you've considered

none

Additional context

none

contact links, github.com and twitter.com are non canonical urls

Describe the bug

GitHub and Twitter were using www. which isn't the canonical url (they'll redirect to github.com and twitter.com respectively). All the other social links are correct however (they all use www.).

Screenshots

Expected behavior

To Reproduce
Steps to reproduce the behavior:

Desktop (please complete the following information):

all

Mobile devices (please complete the following information):

all

Additional context

none

sitemap.xml does not include lang links and no country links

Describe the bug
other languages not included as link
lang codes with no country not included

testing sitemap.xml https://technicalseo.com/tools/hreflang/
more info: https://developers.google.com/search/docs/advanced/crawling/localized-versions

To Reproduce
Steps to reproduce the behavior:

  1. download repo(main commit: b9f2d31)
  2. unzip -> open folder
  3. run command bundle install
  4. run command bundle exec jekyll serve --watch --safe
  5. open _site/assets/sitemap.xml
  6. find and replace http://localhost:4000 with website url ex: https://www.example.com
  7. open https://technicalseo.com/tools/hreflang/ upload sitemap.xml
  8. check for results

Expected behavior

Screen Shot 2022-04-15 at 13 49 19

Screenshots
none

Desktop (please complete the following information):
all
Smartphone (please complete the following information):
all
Additional context
none

Add contact icons from image files

Is your feature request related to a problem? Please describe.

Although you want to add some icons, it's not always available in fontawesome. There is no way to add it.

Describe the solution you'd like

  • only black colored and transparent png or svg image files could be used.
  • works with adding paremeter to _data/const/contact.yml
your_new_contact:
  icon: "https://www.clker.com/cliparts/8/T/Y/I/3/E/black-spade-th.png"
  url: "https://www.example.com"

for local images

your_new_contact:
  icon: "/assets/img/default/new_icon.svg"
  url: "https://www.example.com"
  • icon path availibility for these 3
    • "/" (local)
    • "http://"
    • "https://"
default on hover
default color scheme Screen Shot 2022-06-15 at 14 12 15 Screen Shot 2022-06-15 at 14 13 02
dark color scheme Screen Shot 2022-06-15 at 14 13 10 Screen Shot 2022-06-15 at 14 13 17

Describe alternatives you've considered

upgrading fontawesome adds some new icons but you can't always find icon that you want.

Additional context

none

For any post show the tags (linking to list of posts with that tag) just below the title

Is this enhancement or feature is related to a problem?

This will be useful. When reading a post a reader might want to see what tags it is related to and he can click on that see similar posts.

On the blog page https://jekyll-theme-mrgreen-demo.mrgreensworkshop.com/tabs/blog/ it is not needed since tags are already there in the up navigation.

Describe the solution you'd like

I am not sure exactly. Normally Jekyll blogs are written such that each tag has its on page and tags below the title will be linked to that.

But here it is interactive kind of thing. All tags are there in the same page. They don't even have some bookmark in that page like #tagname. So, not sure how this can be done.

Describe alternatives you've considered

No response

Additional context

No response

Mastodon, identity verification feature

Is this enhancement or feature is related to a problem?

Mastodon uses identity verification which uses links. it is better to have it.

Describe the solution you'd like

How to do so is described here.

Describe alternatives you've considered

No response

Additional context

No response

contacts LinkedIn adress needs`/in` as a prefix

Describe the bug
Similar to how YouTube uses /channel, LinkedIn uses /in as a prefix for profiles.

Screenshots

Expected behavior

LinkedIn uses /in as a prefix for profiles.

To Reproduce
Steps to reproduce the behavior:

Desktop (please complete the following information):

Mobile devices (please complete the following information):

Additional context

last element's bottom margin is too much on about and home layouts

Describe the bug

last element's bottom margin is too much.

Screenshots

last element's bottom margin is too much.

Screen Shot 2022-06-15 at 19 57 41

Expected behavior

Screen Shot 2022-06-15 at 19 57 47

To Reproduce
Steps to reproduce the behavior:

  • build locally or on github

Desktop (please complete the following information):
all

Mobile devices (please complete the following information):
all

Additional context

Auto release note feature for the Repo

Is this enhancement or feature is related to a problem?

Creating release notes sometimes can be time consuming. To be honest nobody likes writing those.

Rules

  • Always add label to the issues.
  • Don't accept PRs without issues because those are used for creating release notes.
  • Always add issue link #xxx to the PR.
  • Always use merge pull request, don't use squash and merge or rebase and merge those are not visible to "git log --merges" command.

Describe the solution you'd like

That's why I use my time to make auto release note creator.

Describe alternatives you've considered

none

Additional context

none

Exclude .github and .vscode on site creation

Is this enhancement or feature is related to a problem?

When the site is created, the .github and .vscode directories are added to the _site folder. It is better not to include these directories.

Describe the solution you'd like

adding those folders to exclude line in _config.yml file.

Describe alternatives you've considered

none

Additional context

No response

Enable contact form only when about page is opened

Is this enhancement or feature is related to a problem?

Because the contact form feature is only available on the about page, don't load on other pages. (for fast page load)

Describe the solution you'd like

only load JavaScript on about page

Describe alternatives you've considered

none

Additional context

No response

Sometimes, site search result links not working

Describe the bug

When using the site search functionality, sometimes clicking on posts does not actually do anything. Instead it closes the search bar with no action.

Screenshots

Expected behavior

When clicking on one of the search results, the user is taken to the respective page.

To Reproduce
Steps to reproduce the behavior:

  1. Visit https://joshbuker.github.io/
  2. Search for a post, e.g. "sample" at time of writing.
  3. Click on one of the results
  4. Instead of taking you to the result, it closes the search with no action.

Desktop (please complete the following information):

  • OS: Linux
  • Browser: Firefox

Mobile devices (please complete the following information):

Additional context
I got it to actually follow through once, but couldn't replicate it consistently. Not sure what exactly is causing it to glitch out.

Auto padding for sliding boxes and changing cookie setting box size

Is this enhancement or feature is related to a problem?

Since sliding box padding is constant, for a balanced view, especially on mobile devices, it is better to change padding automatically. Doing so also fixes the problem for mobile devices, where the close button may not be visible. (width: 320px)

Describe the solution you'd like

Auto padding referenced to --main-container-margin

Describe alternatives you've considered

none

Additional context

none

Seo enhancement, Enable / Disable feature for schema-markup dates.

Is your feature request related to a problem? Please describe.

It turns out, search engines doesn't like if you change datePublished every time you generate the page. Only dateModifiedneeds to be changes if you make any changes in that page.

Describe the solution you'd like

its better to have enable / disable feature for schema-markup dates. Disable by default.

Describe alternatives you've considered

Additional context

The cookie settings button is not visible even though cookie_settings_button_enabled is true

Please check these items before go any further

  • I have watched Mr. Green theme tutorials playlist on YouTube.
  • I have searched the existing Issues.
  • I have searched the existing Discussions.
  • I have checked jekyll docs and the answer was not there.
  • I have tested in one of these browsers; Safari, Chrome, Firefox. (This project hasn't been tested in other browsers.)

Are you sure this is a bug?

  • I'm sure this is definitely a bug.

Describe the bug

If color_scheme_switch_side_nav is false, side-nav-bottom-buttons-container is not displayed.

https://github.com/MrGreensWorkshop/MrGreen-JekyllTheme/blob/570665d929690e5c0a3b01c24a5079ec6bc3324a/_includes/default/nav/navigation-side-nav-bottom-buttons.html

Therefore even though cookie_settings_button_enabled is true, the cookie setting button is also not displayed.

Expected Behavior

If color_scheme_switch_side_nav is true or cookie_settings_button_enabled is true then
side-nav-bottom-buttons-container is visible.

image

Steps To Reproduce

  1. Set color_scheme_switch_side_nav to false in _data\conf\main.yml

  2. Run bundle exec jekyll serve --baseurl "" on a terminal.

  3. browse http://127.0.0.1:4000/
    image

  4. It can not display the cookie settings button.

Which browser have you used?

  • Chrome
  • Safari
  • Firefox
  • Other browsers (This project hasn't been tested in other browsers.)

Which device have you used?

  • Desktop
  • Mobile IOS
  • Mobile Android
  • Other platforms (This project hasn't been tested in other devices.)

Anything else?

In the _includes\default\nav\navigation-side-nav-bottom-buttons.html
change the code as follows. It works I expected.

-{% if color_scheme_switch_enabled == true %}
+{% if color_scheme_switch_enabled == true or cookie_settings_button_enabled == true %}
  <div class="side-nav-bottom-buttons-container">

I have already fixed it so that I can pull request.

Feature, owner file for each language

Is your feature request related to a problem? Please describe.
Contact links, google analytics accounts could be different for different languages. So there is no solution for this.

Describe the solution you'd like
spliting _data/owner.yml to languages solves the problem.
_data/owner/[lang].yml

Describe alternatives you've considered
There wasn't any

Additional context
none

Contact form using Google Forms

Is this enhancement or feature is related to a problem?

I think we need contact form and this is what I came up with.

Describe the solution you'd like

There are other options to but for personal use, I think Google Forms will be sufficient.

This is the "Contact Form" button added after the about text; it is added to_layouts/about.md.

button

This is the loading text that appears until the Google Form is loaded.

loading

This is the Google Form that has been loaded.

form

Describe alternatives you've considered

https://formspree.io/plans
https://formspark.io/pricing

Additional context

How to use?

It is explained in these files. Search for "contact_form" in both these files: _data/owner/[language].yml and _data/conf/main.yml.

readme page youtube playlist link update

Is your feature request related to a problem? Please describe.

When youtube playlist opened, says private video.

Describe the solution you'd like

don't add first video link to playlist links.

Describe alternatives you've considered

none

Additional context

none

Search result long title problem on narrow screens

Describe the bug

if you use search on narrow screen devices and page titles are too long, the search result does not fit on the screen, it moves to the left.

Screenshots

Screen Shot 2022-07-04 at 14 08 51

Expected behavior

should be seen like this.

Screen Shot 2022-07-04 at 14 11 07

To Reproduce
Steps to reproduce the behavior:

  1. Go to any blog post
  2. Change title to longer text
  3. Narrow the browser size.
  4. Use search
  5. See error

Desktop (please complete the following information):
some (depends on text width)

Mobile devices (please complete the following information):
all

Additional context

Auto-build tool

Is this enhancement or feature is related to a problem?

Since I make lots of mistakes, It is better to have an auto-builder that tests after changes.

Describe the solution you'd like

When a push or pull request is made to the main branch, jekyll build is automatically launched and checks to see if the build was successful.

Describe alternatives you've considered

none

Additional context

none

About page title overlaps outer to div border

Describe the bug

when brand is too long About page title overlaps outer to div border.

Screenshots

Screen Shot 2022-06-15 at 17 53 10

To Reproduce
Steps to reproduce the behavior:

  • set longer brand name
  • build locally or on github

Expected behavior

Screen Shot 2022-06-15 at 17 53 58

Desktop (please complete the following information):
all

Mobile devices (please complete the following information):
maybe some tablets

Additional context

Sometimes, table of contents close button doesn't works.

Describe the bug

Sometimes, Table of contents close button doesn't works. Instead panel moves to right.

Screenshots

Screen Shot 2022-07-01 at 13 18 51

Expected behavior

when Close button clicked, eveytime closes the Table of contents box.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://jekyll-theme-mrgreen-demo.mrgreensworkshop.com/posts/2022-03-03-mr-green-jekyll-theme
  2. Click X button on the top right side of Table of contents.
  3. Check if closes.

Desktop (please complete the following information):
none

Mobile devices (please complete the following information):
some tablets.

Additional context

Its not reproducible evey time. Sometimes it occurs.

Giscus comment engine

Is this enhancement or feature is related to a problem?

As discussed in #165 its better to have giscus.

Describe the solution you'd like

Adding giscus as described here.

Describe alternatives you've considered

none

Additional context

No response

hreflang does not include no country links

Describe the bug
lang codes with no country not included

testing hreflang https://technicalseo.com/tools/hreflang/
more info: https://developers.google.com/search/docs/advanced/crawling/localized-versions

To Reproduce
Steps to reproduce the behavior:

  1. Fork the repo. (main commit: a9b7b80)
  2. Edit _config.yml and find url: set to url: "https://your_github_user_name.github.io"
  3. Edit _data/conf/main.yml and find hreflang: set to hreflang: true
  4. Rename the repo name to your_github_user_name.github.io
  5. open https://technicalseo.com/tools/hreflang/ test pages.
  6. check for results

Expected behavior
not complaining about links with no country code.

Screenshots
none

Desktop (please complete the following information):
all
Smartphone (please complete the following information):
all
Additional context
related bug #20

feature for adding youtube videos

Is your feature request related to a problem? Please describe.

feature for adding youtube videos by id

Describe the solution you'd like

YouTube video url : https://www.youtube.com/embed/nkZOOK4wM28
YouTube link:       https://www.youtube.com/embed/
VideoID :           nkZOOK4wM28
  • add videos using video links
{% include default/youtube-video.html link='nkZOOK4wM28' center=false %}
  • youtube video config will be set in _data/conf/main.yml file
youtube:
  privacy: false
  default_center: true
  • if center is not provided to include, default_center setting in _data/conf/main.yml will be used.
  • if privacy set true www.youtube-nocookie.com will be used.
    otherwise www.youtube.com will be used for youtube video links.

Describe alternatives you've considered

Additional context

Please help with adding Korean language support.

Is this enhancement or feature is related to a problem?

Public message for anyone who speaks Korean.

I intend to add Korean language support. I've already translated everything, but I need volunteers to double-check the translations. Could you please take a look and check if these translations are okay?

line, 4
https://github.com/MrGreensWorkshop/MrGreen-JekyllTheme/blob/feature_korean_language_support/ko/_posts/2023-02-19-mr-green-jekyll-theme.markdown?plain=1#L4

line 5,11,45
https://github.com/MrGreensWorkshop/MrGreen-JekyllTheme/blob/feature_korean_language_support/_data/owner/ko.yml

line, 7,8,15,18,21,28,29,176,177,189,210,218,226
https://github.com/MrGreensWorkshop/MrGreen-JekyllTheme/blob/feature_korean_language_support/_data/content/projects/ko.yml

line, 44,45,52,55,65,71,73,75,77,79,81,83,85,87,93
https://github.com/MrGreensWorkshop/MrGreen-JekyllTheme/blob/feature_korean_language_support/ko/tabs/links.md?plain=1

Almost all lines
https://github.com/MrGreensWorkshop/MrGreen-JekyllTheme/blob/feature_korean_language_support/_data/lang/ko.yml

Almost all lines
https://github.com/MrGreensWorkshop/MrGreen-JekyllTheme/blob/feature_korean_language_support/README-ko.md

If you think there is a mistake in the translation, please let me know by commenting on this issue, or you can submit a PR targeted to the this branch feature_korean_language_support.

Thanks in advance.

Describe the solution you'd like

Adding Korean Language

Describe alternatives you've considered

No response

Additional context

No response

In Blog posts, japanese read time is not realistic

Describe the bug
In Blog posts, japanese read time is too short.

Screenshots

To Reproduce
Steps to reproduce the behavior:

  • write a blog page
  • build locally or on github
  • open created blog post

Expected behavior
should be longer

Desktop (please complete the following information):
all

Mobile devices (please complete the following information):
all

Additional context

Bump Up github-pages version automatically

Is this enhancement or feature is related to a problem?

When github-pages version is updated I want to update Gemfile, but I don't want to do it manually.

Describe the solution you'd like

  • Make a new workflow
  • Check latest gem version of github-pages gem
  • If it is updated, try to build with new version
  • If successes update version and create a PR and an issue
  • If fails create an issue with build error
  • Other fixes in other files

Describe alternatives you've considered

No response

Additional context

No response

When titles in the blog post too long toc overlaps the blog post

Describe the bug
When titles in the blog post too long toc overlaps the blog post.

Screenshots
problem

To Reproduce
Steps to reproduce the behavior:

  • add long title on any blog post
  • build locally or on github
  • open edited blog post

Expected behavior
fix

Desktop (please complete the following information):
all

Mobile devices (please complete the following information):
tablets with large displays
none because toc not visible on smartphones.

Additional context
none

Date month is not translated in non english pages.

Please check these items before go any further

  • I have watched Mr. Green theme tutorials playlist on YouTube.
  • I have searched the existing Issues.
  • I have searched the existing Discussions.
  • I have checked jekyll docs and the answer was not there.
  • I have tested in one of these browsers; Safari, Chrome, Firefox. (This project hasn't been tested in other browsers.)

Are you sure this is a bug?

  • I'm sure this is definitely a bug.

Describe the bug

This is a screenshot of the search, after adding new language. Months added to _data/lang/[newlang].yml but month language is still English.

Screen Shot 2022-09-30 at 20 12 49

Effected pages

Home			home.md
Project page		projects.md
Blog post titles	post-info-data.liquid
Search			search-data.liquid

Expected Behavior

Translations of the months are expected to show.

Screen Shot 2022-09-30 at 20 06 02

Steps To Reproduce

  1. Check-out PR #118
  2. Go to one of effected pages
  3. Check the date
  4. See the problem

Which browser have you used?

  • Chrome
  • Safari
  • Firefox
  • Other browsers (This project hasn't been tested in other browsers.)

Which device have you used?

  • Desktop
  • Mobile IOS
  • Mobile Android
  • Other platforms (This project hasn't been tested in other devices.)

Anything else?

No response

Readme update

Is your feature request related to a problem? Please describe.

Read me update, adding sponsor links

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.