monero-ecosystem / csharp-monero-rpc-client Goto Github PK

Add "csharp" after the three backticks so that the C# code is highlighted properly instead of that ugly red.

Hi,
I want to create a wallet but it always return this error:
"Error experienced when making RPC call in OpenWalletAsync. JsonRpcError: Method not found".
I'm using this public node:
xmr.moneromerch.com:18089
and my code is
var walletClient = await MoneroWalletClient.CreateAsync("xmr.moneromerch.com", 18089, "mytestwallet", "mytestpassword");
is there any way to create wallet and address offline?

https://github.com/Agorist-Action/csharp-monero-rpc-client/blob/1f39c0bcccf67d61d29cf3547a9f9d1feac58add/Wallet/POD/AddressDetails.cs#L26

This should be NumUnspentOutputs.

If the RPC daemon reports an error it makes a small JSON object with 1 property error containing an object with error code and error string. The library currently does not detect this, always tries to deserialize the normal answer of the respective call, resulting in a null result object, which then ends in an "unexpected wallet error" exception thrown without any further info.

IMO this should get improved, in the interest of better debugging, the possibility to generate meaningful error messages in applications, etc.

By the way, sorry for being off-topic here, but I don't have a good idea where else to ask: Do you still receive e-mails from me, e.g. the one I sent last Friday December 11? I could work on this issue and a handful of other ones I found, but that would probably need some sort of coordination between the two of us, if you are also working on the library right now.

Hi @Agorist-Action . Please see monero-ecosystem/meta#78 (comment) and let me know how you plan to proceed forward.

https://github.com/Agorist-Action/csharp-monero-rpc-client/blob/1f39c0bcccf67d61d29cf3547a9f9d1feac58add/Utilities/ErrorGuard.cs#L10

Maybe use the [CallerMemberName] reserved attribute to get at the name of the calling method, so there is no need to call with a second argument evaluated with the help of nameof? I could not find any obvious drawback in Microsoft's doc of the feature.

https://github.com/Agorist-Action/csharp-monero-rpc-client/blob/1f39c0bcccf67d61d29cf3547a9f9d1feac58add/Network/RpcCommunicator.cs#L91

Maybe it's worth to put a constant / prepared object somewhere for a JsonSerializerOptions object configured as needed, to make this code a little less verbose.

I think I solved the riddle of the missing destinations in the wallet's record of transfers: If you close a wallet with your library it does not get saved. Why not? Because the close_wallet RPC method has a parameter autosave_current (that is not yet mentioned in the RPC documentation on GetMonero.org), and if that's not true the call does not save, as I saw directly in the RPC daemon's source code.

https://github.com/Agorist-Action/csharp-monero-rpc-client/blob/1f39c0bcccf67d61d29cf3547a9f9d1feac58add/Network/RpcCommunicator.cs#L187

Small typo, probably should be "null or whitespace".

https://github.com/Agorist-Action/csharp-monero-rpc-client/blob/1f39c0bcccf67d61d29cf3547a9f9d1feac58add/Network/MoneroCommunicatorResponse.cs#L114

I just wondered whether using properties is good for anything in such an internal and highly technical class, or if using variables would save some memory and execution time. Might be largely a matter of taste however.

https://github.com/Agorist-Action/csharp-monero-rpc-client/blob/1f39c0bcccf67d61d29cf3547a9f9d1feac58add/Network/MoneroRequestAdapter.cs#L65

How about about introducing a constructor of GenericRequest already setting jsonrpc and id and having method and params as parameters? I think the code would get shorter and more readable with such a constructor.

https://github.com/Agorist-Action/csharp-monero-rpc-client/blob/1f39c0bcccf67d61d29cf3547a9f9d1feac58add/Wallet/POD/TransferType.cs#L1

I am a little nitpicking here, but I find unneeded using statements a little confusing and misleading. But maybe it's best to clean this up later after the code stabilized some more, in one go over the whole codebase.

https://github.com/Agorist-Action/csharp-monero-rpc-client/blob/1f39c0bcccf67d61d29cf3547a9f9d1feac58add/Wallet/MoneroWalletClient.cs#L556

Just depositing my opinion here, feel free to ignore: Personally I would prefer Multisig over MultiSig, with the argument that multisig took on some life on its own as single word / term. And it's simpler :)