Missing 'autosave_current' parameter of the 'close_wallet' call about csharp-monero-rpc-client HOT 6 CLOSED

1. Isn't it true by default though?
2. Is the request being rejected on the RPC Server-side?

https://github.com/monero-project/monero/blob/8286f07b265d16a87b3fe3bb53e8d7bf37b5265a/src/wallet/wallet_rpc_server_commands_defs.h

struct COMMAND_RPC_CLOSE_WALLET
  {
    struct request_t
    {
      bool autosave_current;

      BEGIN_KV_SERIALIZE_MAP()
        KV_SERIALIZE_OPT(autosave_current, true)
      END_KV_SERIALIZE_MAP()
    };
    typedef epee::misc_utils::struct_init<request_t> request;

    struct response_t
    {
      BEGIN_KV_SERIALIZE_MAP()
      END_KV_SERIALIZE_MAP()
    };
    typedef epee::misc_utils::struct_init<response_t> response;
  };

What I do notice though, is that when I call CloseWalletAsync, I see nothing printed to screen on the RPC Server. Im guessing it should at least say something about the wallet being saved and closed.

from csharp-monero-rpc-client.

Hmm, you are right about the default, overlooked that. I will try to investigate further. First attempt will probably be to call the save method myself before closing.

I had at least one occurence where I lost some destinations by merely calling CloseWalletAsync but where later other destinations where made permanent when I stopped the RPC daemon with ^C which causes it to save the currently open wallet before terminating (which it also says on console).

from csharp-monero-rpc-client.

Yeah I noticed that. When I close with Ctrl ^ C I get the nice message. When I use the CloseWalletAsync call, I don't get anything, which I'm suspect of. Thanks for investigating further.

from csharp-monero-rpc-client.

I debugged the RPC binary on Linux and the default parameter mechanism was working, autosave_current was true. With this the mystery only deepens.

Preserving destinations (and maybe other things) works for me with a explicite call to SaveWalletAsync prior to closing, so for the time being that's a simple workaround. Calling save does not result in a log line "Saved" or similar apparently.

Anyway, as far as your library is concerned, I don't think adding that autosave_current parameter should have high priority.

from csharp-monero-rpc-client.

Feel free to close this Issue report then (unless you'd like to keep it open). Thanks for bringing this to my attention.

from csharp-monero-rpc-client.

Alright, let's close this, as the problem really is not on side of the library, and as I said adding the parameter does not seem pressing, as wanting to close a wallet without saving seems pretty obscure to me.

from csharp-monero-rpc-client.