moerill / layer-hotkeys Goto Github PK

**Any plans to update to v10 compatibility? **

Appreciate you consider the module "complete & stable", but it'd be nice not to see the old version flag :-)

Actually, I've just tried to install into my new v10 instance, and the module isn't showing up in the Foundry "Install Module" dialog :-(

Trying to Override either Bar1 or Bar2 to None results in nothing changing. Personally, I prefer to have Bar2 as HP and Bar1 as None, but when I set those settings, making a token successfully overrides Name, Bar2, etc but Bar1 stays the default "attributes.hp" instead of changing to None.

It would be great if it were possible to not only select the basic tool, but also the actual desired sub-menu tool.

There are two ways one could implement this:

1. Key combinations: you hit the main key followed quickly by a second key, which denotes which sub-tool to select
2. Key cycling: each time you hit the main key, it cycles one step through the sub-tool menu

If that makes sense? Happy to help code this if you can point me in the right direction – not sure where to find references to how to select the tools or how to discover their id's

Layer-Hotkeys triggers compatibility warnings on Foundry 0.6.6, and doesn't show any configuration options. Did I miss something?

Can you make it an option to not work when a token is selected how it used to function?

Every time I activate the module, I can no longer access the settings. I need to disable the module to be able to access the settings again. It's a real shame, because shortcuts to tools is absolutely basic functionality, which it's scary the app doesn't already provide by default.

Custom hotkeys are case sensitive, if a hotkey is set to a value of "q" it will not trigger if the keyboard key of 'q' is pressed in conjunction with a CapsLock being activated. And conversely, if a hotkey is set to a value of "Q" it will only trigger if the keyboard key of 'q' is pressed in conjunction with a CapsLock being activated.

Tested with just Layer Hotkeys enabled, and none of the hotkeys work to switch to that layer any more after updating foundry to 0.8.6.

Module version: 1.7.0
FVTT version: 0.6.5
Browser: Electron, Chrome, Firefox (Windows 10 x64)

If you hit a hotkey of an "active" tool, the one that produces some immediate effect, such as opening a window (Art Browser, FXMaster/Weather Controls, etc.), or Clear Templates, etc., the button will get highlighted, but nothing would happen.

If you hit a hotkey of a "toggle" tool, such as Toggle Notes Display, or others, the button will get highlighted (as if the toggle in On), but nothing will actually change.

No console errors are produced.

FCTT: 0.6.5
Layer-Hotkeys: 1.7.0

The below error happens in the console upon application launch.

Error:

foundry.js:2223 TypeError: Cannot read property 'layer' of undefined
    at layer-hotkeys.js:123
    at Function._call (foundry.js:2220)
    at Function.call [as __furnace_original_call] (foundry.js:2205)
    at Function.callOriginalFunction (Patches.js:57)
    at Function.<anonymous> (Debug.js:42)
    at SceneControls._render (foundry.js:3902)

Loaded Modules:
about-time--v0.1.48;
actually-private-rolls--v0.2;
adventuremusic--v1.0;
animated-spell-effects--v0.2.1;
betternpcsheet5e--v0.8.3;
calendar-weather--v2.7.5;
CautiousGamemastersPack--v0.1.6;
combat-utility-belt--v1.1.3;
dice-so-nice--v2.0.4;
dice-calculator--v0.5.10;
dww-battlemaps--v1.0.0;
dynamiceffects--v0.5.87;
fxmaster--v0.8.1;
koboldpressogl--v0.22;
layer-hotkeys--v1.7.0;
lmrtfy--v1.0;
mess--v0.11.2;
michaelghelfi--v1.0;
minor-qol--v0.1.58;
miskasmaps--v1.0;
music-d20-sampler--v1.0.0;
tomcartos-ostenwold--v1.0.0;
pings--v1.2.9;
SharedData--v1.0.0;
spellarena--v1.1.0;
furnace--v2.2;
tidy-ui_game-settings--v0.1.14;
tidy5e-sheet--v0.2.16;
token-action-hud--v0.5.12;
token-mold--v2.7.1;
trigger-happy--v0.6;
vtta-dndbeyond--v3.1.4;
vtta-iconizer--v2.1.12;

For players, the default settings seem to force keys 1-5 to select the subtools. However, with players, they are used to 1-0 selecting macro bar macros.

Either default player subtool keys to blank or give the GM the option to set the default player keys.

I am still on 0.7.9, noticed this error in the console

VM1028:8 TypeError: Cannot read property 'toUpperCase' of null
    at layer-hotkeys.js:200
    at Function._call (eval at <anonymous> (libWrapper-errors.js:249), <anonymous>:4:14)
    at Function.call (foundry.js:2481)
    at SceneControls._render (foundry.js:4547)

seems a pretty straightforward fix as you are not checking for null here

if (key !== undefined) li.title += " [" + key.toUpperCase() + "]";

I am still on 0.7.9, noticed this error in the console

settings-extender.js:89 Uncaught TypeError: Cannot read property 'ctrlKey' of null
    at settings-extender.js:89
    at Array.reduce (<anonymous>)
    at t (settings-extender.js:88)
    at i (settings-extender.js:97)
    at Function.s.eventIsForBinding (settings-extender.js:206)
    at window.addEventListener.useCapture (layer-hotkeys.js:88)

seems like you are not checking for null and undefined here

if (window.Azzu.SettingsTypes.KeyBinding.eventIsForBinding(ev, key)) {

Trying out Layer-Hotkeys. Loaded it in FVTT. F12 shows an error. I'll present it here (or whereever GitHub wants to have me place it.

Screen Dump

Module version: 1.7.0
FVTT version: 0.6.5
Browser: Electron, Chrome, Firefox (Windows 10 x64)

Whenever an actor token is selected, hotkeys seem to stop working.

No errors in console.