mlasevich / jenkins-pipeline-library-reference Goto Github PK

Hi,

identifying cps issues during development is critical to jenkins pipeline development. I am glad you are attempting to address it here. I am challenged with the same. I was trying to factor your repo to detect issues that you would normally see only when run on Jenkins i.e with cps transformation. For instance "a non cps method will fail in jenkins when it calls a cps transformed method". But I was not able to test that scenarios successfully with your implementation. I do not have insight into internal groovy:cps implementation or haven't attempted that yet. Can you help me figure out why the following test case fails. shouldn't it throw CpsCallableInvocation. The same script fails with expected to call WorkflowScript.nonCpsMethodCallingCpsMethod but wound up catching WorkflowScript.cpsMethod; see: https://jenkins.io/redirect/pipeline-cps-method-mismatches/ when run on jenkins.

This test does NOT throw CpsCallableInvocation as expected. This test case fails

def "ascpsscript"(){
        when:
        asCPSScript("""

import com.cloudbees.groovy.cps.NonCPS
                @ NonCPS
        public void nonCpsMethodCallingCpsMethod(){
            println "this is a non cps method"
            cpsMethod()
        }
        public void cpsMethodCallingNonCps(){
            println "this is a cps method calling non cps method"
            nonCpsMethodCallingCpsMethod()
            println "after:this is a cps method calling non cps method"
        }
        public void cpsMethod(){
            println "this is a cps method"
        }
        @NonCPS
        public nonCpsMethod(){
            println "this is a non cps method"
        }
        nonCpsMethodCallingCpsMethod()
        """)
        then:
        thrown CpsCallableInvocation;
    }