Comments (5)
interesting, I can reproduce this. I think I focused on running CPS code, and missed this use-case - which is important. I think there likely needs to be some extra checks inside for CPS failures. Will need to look into it further. Thank you.
from jenkins-pipeline-library-reference.
I think I identified what is going on, but unsure of the full impact of this change. I believe this should resolve the issue.
@natsen Please test in real-world use, I will do the same prior to merging
Thank you for reporting this, it explains an occasional oddity I have seen.
Also, the actual CPS code throws IllegalStateException
in case of a mismatch, not a CpsCallableInvocation
from jenkins-pipeline-library-reference.
Thank you for the quick fix.
invokeCPSMethod does not work as expected. This is making the similar call as the asCPSScript but with invokeCPSMethod.
This test fails.
def "test non cps calling cps method"(){
when:
invokeCPSMethod(sut, "nonCpsMethodCallingCpsMethod")
then:
thrown IllegalStateException;
}
sut
import com.cloudbees.groovy.cps.NonCPS
@ NonCPS
public void nonCpsMethodCallingCpsMethod(){
println "this is a non cps method"
cpsMethod()
}
public void cpsMethodCallingNonCps(){
println "this is a cps method calling non cps method"
nonCpsMethodCallingCpsMethod()
println "after:this is a cps method calling non cps method"
}
public void cpsMethod(){
println "this is a cps method"
}
@NonCPS
public nonCpsMethod(){
println "this is a non cps method"
}
from jenkins-pipeline-library-reference.
Hmm, curious - asCPSScript()
just compiles the script and then calls invokeCPSMethod()
so there should be no difference between the two :-/
from jenkins-pipeline-library-reference.
I am unable to replicate the second issue, but I added unit tests for most common scenarios (#4) - can you take a look and see if I am missing something
from jenkins-pipeline-library-reference.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jenkins-pipeline-library-reference.