non cps method calling cps method does not throw CpsCallableInvocation as expected about jenkins-pipeline-library-reference HOT 5 CLOSED

interesting, I can reproduce this. I think I focused on running CPS code, and missed this use-case - which is important. I think there likely needs to be some extra checks inside for CPS failures. Will need to look into it further. Thank you.

from jenkins-pipeline-library-reference.

I think I identified what is going on, but unsure of the full impact of this change. I believe this should resolve the issue.

@natsen Please test in real-world use, I will do the same prior to merging

Thank you for reporting this, it explains an occasional oddity I have seen.

Also, the actual CPS code throws IllegalStateException in case of a mismatch, not a CpsCallableInvocation

from jenkins-pipeline-library-reference.

@mlasevich

Thank you for the quick fix.

invokeCPSMethod does not work as expected. This is making the similar call as the asCPSScript but with invokeCPSMethod.
This test fails.

def "test non cps calling  cps method"(){
       when:
       invokeCPSMethod(sut, "nonCpsMethodCallingCpsMethod")
       then:
               thrown IllegalStateException;
   }

sut

import com.cloudbees.groovy.cps.NonCPS
                @ NonCPS
        public void nonCpsMethodCallingCpsMethod(){
            println "this is a non cps method"
            cpsMethod()
        }
        public void cpsMethodCallingNonCps(){
            println "this is a cps method calling non cps method"
            nonCpsMethodCallingCpsMethod()
            println "after:this is a cps method calling non cps method"
        }
        public void cpsMethod(){
            println "this is a cps method"
        }
        @NonCPS
        public nonCpsMethod(){
            println "this is a non cps method"
        }

from jenkins-pipeline-library-reference.

Hmm, curious - asCPSScript() just compiles the script and then calls invokeCPSMethod() so there should be no difference between the two :-/

from jenkins-pipeline-library-reference.

I am unable to replicate the second issue, but I added unit tests for most common scenarios (#4) - can you take a look and see if I am missing something

from jenkins-pipeline-library-reference.