Code Monkey home page Code Monkey logo

dnd5e-custom-skills's People

Contributors

doumoku avatar misthero avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

dnd5e-custom-skills's Issues

Skills Not Appearing

Sup, nice idea with the custom stuff, allows a lot of things but...ehm its not working.
Granted i have latest version of foundry, and various other modules but when i simply try to add a skill for testing purposes the space is given in the char sheet but the skill does not appear.
Any clue as to why?
And yes i tried with the disable enable or reopen char sheet, i even created a new one as well.

Allow modifiers in the new skills

In the fashion of being creative and adding new custom skills, I would find it very useful if we could add a modifier to those skills on top of selecting an attribute to associate it with. Even further, adding two attributes and have flexible conditions would make it even more customizable and intuitive to use. Few example of what I was thinking to achieve:
Skill A: default attibute: Dex , extra modifier: +2
Skill B: default attribute: Dex, secondary attribute: Int, method: choose highest
Skill C: default attribute: Dex, secondary attribute: Int method: take average of the two
Skill D: default attribute: Dex, extra modifier: -(@classes.druid.levels / 2)

That way we could make skills that are more flexible or more specific by default, instead of having to adjust them manually per character.

Proficiency value is not applied when updated by an Active Effect

The behavior of a custom skill does not match the behavior of a native skill when proficiency value is set by an active effect.
image
image

Looking at roll data, the ability values are structured differently, and the multiplier field is not being set.

image

When manually selecting a proficiency value, the roll data is updated as expected.
image

NPC Character Sheets not Triggering CUB.

I have set triggler to mark dead and unconcious for both NPCs and PCs. However, it does not work on NPCs that are using an NPC sheet.

From left to right, NPC Token with NPC Character Sheet, NPC Token with PC Character Sheet, PC Token with PC Character sheet. Triggers marked with NPC only only trigger on PC character sheets that don't have owners.

Screenshot (16)

Skills not disappearing after removal

I hit reset, didn't help, now the skill just has no name. i hid the skill, but then when i disabled the module it shows up again. How do i get rid of this?

Sheet breaking attributes line in Tidy5e

Currently, i found that adding a new skill is breaking the attributes line, as its adding space between them and not adding to the width that the character sheet opens in. Its something minor, but it can be a bother sometimes.

With the added skill:
image

Without the added skill:
image

Create New Actor freezes with module 5e-Custom-Skills

Hi,

I'm running Foundry VTT v10.284 with DnD5e 2.0.2 and 5e-Custom-Skills module v1.1.1 installed.
There are several other modules installed, but all are turned off.

I get these warnings and errors upon creating a new actor.

image

image

The creation process is extremely slow with the module turned on, compared to have no module installed.
Also, if I activate other modules, foundry vtt completely freezes, unfortunately without being able to get an error report.
If I turn off 5e-Custom-Skill, but leave the other modules on, everything works fine.

Does someone might have an idea what went wrong in this case?

Skills not hidden on NPC sheets

Hiding skills in the module settings works just fine for player characters, and hiding abilities works fine for any sheet, but I'm running into an issue where none of the skills set to hidden in the settings are actually hidden on NPC sheets.

image

I'm on Foundry build 291 and DND5e 2.1.4. The screenshot is using TidySheet of course, but I'm getting identical behavior with the default sheet as well.

Modifier from effects get applied twice

Dnd Version: 2.3.1
Foundry Version: 10.303
Module version: 1.2.1

Hello.
When using this module with DAE, if I use an effect to modify the value of an ability score, then the effect gets applied twice:
image
image
image

As you can see, toggling the effect adding only one to wisdom, I get to 12 instead of 11.

If I turn off DAE, wisdom gets back to 11. Similarly, if I turn of 5e custom skills, it gets back to 11.

This is a fresh install of foundry, so I'm pretty sure it's some legacy configuration on my side. Do you have any idea of what's happening / is this fixable?

I tried looking at the code myself but was unable to isolate the source of the problem.

Thank you,
Maravedis

Do not hide skills

It has recently stopped hiding selected skills. I don't know if it's because of the new versions of the module or D&D5. I attach a screenshot of the error that is shown multiple times in the console when opening the configuration window.

CS Error

(DAE x Custom Skills) Making some "passive effects" that increase some values not work correctly

Foundry Version: 9.280
Module list:
image
Custom Skills Version: 1.0.8 probably (It does show as 1.0.8 on Foundry so most likely)
DAE Version: 0.10.30

I will start it saying that I don't know the full extent of this problem, I do know however that it's affecting HP increasing effects and movement increasing effects.

Please do ignore the absurd values

image
image

This is respectively the HP and Movement of this creature if I have both DAE and Custom Skills enabled, but the thing is it was supposed to be higher, it has effects that boost both it's HP and it's movement speed, which start working the second I turn Custom Skills off.

The module list that I ran this next test on

image

New HP and Movement with the working effects

image
image

The effects remained untouched between tests, so I don't think they're relevant at all, but they're as follows:

image
image

I think that's about all the relevant information and even some extra, but if you do need any extra info I'll be more than happy with providing it!

Edit: AC IS PARTIALLY WORKING, if you use "data.attributes.ac.bonus" it works fine, but not if you use data.attributes.value for some reason, which works usually, and now it's working without Custom SKills and DAE on

(Issue) Tidy5e causing skill ability modifier to go to dex & not using new stats

It's not leaving behind any errors that I can notice, I had to manually remove each module 1 by 1 to see what was causing the issue and it seems to only occur with Tidy5e (& maybe TidyUI - Game Settings?)

How to reproduce (from my experience at-least):
1: Make custom skills with different ability modifiers.
2: Create new actor

(Before)
Report1
(After)
image

Note: A workaround for now if you want to keep Tidy is to disable it when creating the actor then re-enabling it after.

Languages Ita

Greetings,
thank you very much for the module, it is really nice and it was just what I was looking for. Congratulations.
I am writing for a problem with languages: with the tidy sheet if I set my language, it's okay, if I also activate your module, it goes back to English.
How can I solve?
Thank you very much and sorry for my bad english.

Best Regards

Roberto

Not all skills are being added

I'm working on adding skills to a module I'm building. I'm currently on Testing channel of Foundry v10.279
Here's what I put in
input
This is the result after hitting apply to a character sheet
Result
Then this is what I see at the settings page
input

It seems to delete my entries.

No longer works with DnD 5e 3.0 update

The big DnD 5e 3.0 update came out today and the custom skills didn't carry over. I tried removing and re-adding the module to no avail.

When I go to Configure Settings and click on Custom Abilities & Skills Configuration, the button does nothing - it doesn't open a new window or do anything. The box highlights orange and that's it.

Screenshot from 2024-02-01 12-09-06

I believe this is more of an issue with the fact the 3.0 update bricked something rather than specifically an issue with the module, as it was working perfectly before.

TidySheet5e Improper Labeling with Abilities

Foundry Version: 9.225
D&D5e System Edition: 1.6.3

Hello! I'm loving the concept of the module, but I'm finding difficulty when it comes to adding new abilities to TidySheet5e, which should have full support. The following label appears after applying changes to world and reloading:

image
image

This problem only affects TidySheet5e, as the Default Sheet is working as intended:

image

Thank you for your continued development on the module!

EDIT: I believe this has to do with the fact that TidySheet5e shortens the names of abilities, unlike the Default Sheet. For instance: "Intelligence" becomes "INT".

Errors pushing on character sheet creations

The system lags out with a mass number of errors. I have three skills added and one ability, which one of the skills relies on...
Skill/Dexterity
Skill/Con
Skill/Made up ability

Screen Shot 2022-09-11 at 8 32 22 PM

Module Active but no configuration entries

Foundry V10 Build 291
D&D 5e 2.1.5

I just installed the module, so it should be up to date.

I activated this module, but can't find its functionality anywhere. There are no entries for it in Configure Settings.

I deactivated every other module, no change. I created a completely new world and activated just this module. Still nothing.

I'll be updating to V11 before I actually use it, but I thought it was worth reporting that it isn't showing up at all with the versions I currently have installed.

Feature Request: Alphabetize List of Skills

image
Currently, the skill list has the unhidden core skills alphabetized, followed by the custom skills alphabetized. However, especially for some of my less adept players, having the list be split that way makes it hard for them to find what they're looking for.

I would like the option to have the full list of skills alphabetize without being split into two sections.

Passive skills and named effects

Ola.

I'm trying to use this to remove investigation and perception and combine them into a new skill.

Awareness(INT)

I got it all setup, but now, using monk token bar, see passive awareness instead of passive investigation and perception.

How do I go about finding out what the active effect naming convention is for the new skill.

Instead of skills.prc.passive?

More custom things, as an example proficiencies.

With this system, for skills and attributes, is there a way to add in the same system but for proficiencies as well?
There is an assortment of other things that can be added, like custom weapon and armor types (for instance firearms from the Artificer Class), custom tools, custom languages, and custom damage types as well.
I know the DND system already has some of these can you can pencil in, but being able to select them from a checkbox menu would be nice.
I know the DND system recently got updated with a trait system (for classes and races) so being able to select homebrew options there would be pretty nice.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.