minetest-mods / xdecor Goto Github PK

2015-12-04 16:03:25: ERROR[Main]: ServerError: Lua: Runtime error from mod 'xdecor' in callback nodemeta_inventory_AllowPut(): /home/u
ser/minetest/bin/../mods/xdecor/enchanting.lua:74: attempt to concatenate local 'toolname' (a nil value)
2015-12-04 16:03:29: ERROR[Main]: stack traceback:
2015-12-04 16:03:29: ERROR[Main]: /home/user/minetest/bin/../mods/xdecor/enchanting.lua:74: in function </home/user/minetest/bin
/../mods/xdecor/enchanting.lua:70>

0.4.13-dev, looks like tool which crash server is mese pick. Also i use worktable mod.

If while sitting in a chair/cushion a player teleports /home, they will become stuck in place, in a sitting position.

La fonction "cauldron.filling" sert pour le cauldron vide et le plein d'eau, mais n'a aucun test pour savoir si on a un bucket vide ou plein en fonction du cauldron, si on click sur un cauldron vide avec un bucket vide le bucket est rempli.
Si on a plusieurs bucket vide empilés ils sont tous remplacer par un seul plein.

The itemframe doesn't display the item on display in the latest version (as of may 28th 2016). The itemframe does, however, accept the item when you right-click it.

When a player without the fly-priv sits down on a chair, and then teleports to anywhere (like using /spawn or /home) the player stays in seated position and can now fly!

I think hive produce honey too fast. In reall world beekeeper can take honey once a year. Hive in xdecor inexpensive. Now the player is enough just of one beehive but will be good if player will need create apiary.

deleted

https://github.com/kilbith/xdecor/blob/master/nodes.lua#L197

did you ment default:chest? :)

is this intentional or a bug?

I recognize the sprite of the bee displayed in the artificial hive as the one used for drones of the class of bees that includes common and industrious bees in Forestry, a mod for Minecraft. Where was the sprite sourced?

EDIT: The file in question is textures/hive_bee.png

The mod uses some Minecraft slang which should be avoided IMO:

• Ender Chest: This name only makes sense if there would something like The End in Minetest Game or this mod, but this is not the case. I suggest the name used in Minetest TNG: “Teleporter Chest”
• Bamboo Frame: Apparently the papyrus required for this magically turns into bamboo after crafting ;-). I suggest “Papyrus Frame”.

The workbench is untrustworthy on a server:

• It's not protected, people can steal your best stuff while it's being repaired.
  Even if you protect your house, players can usebug, at least with the mod areas to sneak in and steal.

• There's no log of what goes in and out of the workbench.
  Unlike the MT_Game containers. It's very thief-friendly.

Even when you are careful and never use its storage feature, it happens that you forget your stuff in the repair bench and you get robbed. So could there be a locked version of it or, at least, could it work like the furnace in protected areas ? And log the moves?

hi, before i'll try to make this by my self without much experience i guess makeing this issue is a good idea. Cutting wool might be a nice feature :)

2016-01-21 14:32:15: ERROR[Main]: ServerError: Lua: Runtime error from mod 'xdec
or' in callback node_on_receive_fields(): ...e/cwz/worlds/tt_survival/worldmods/
xdecor/enchanting.lua:60: attempt to concatenate local 'name' (a nil value)
2016-01-21 14:32:15: ERROR[Main]: stack traceback:
2016-01-21 14:32:15: ERROR[Main]: ...e/cwz/worlds/tt_survival/worldmods/xd
ecor/enchanting.lua:60: in function <...e/cwz/worlds/tt_survival/worldmods/xdeco
r/enchanting.lua:53>

Picking up a cut piece in the "forms" list of the workbench and then clicking the "Storage" button and placing it down in that list does not remove the original material. This allows for infinite pieces, like slabs which can then be combined into whole blocks. Meaning that the workbench has a bug that allows for infinite materials.

I accidentally knocked the default:junglesapling of it's xdecor:itemframe and couldn't get it to stick back on. I tried with newest version itemframe and newest sapling and still didn't work as it did before. Also, seeds never worked.

2016-03-19 00:06:12: ACTION[Server]: TARD places node xdecor:barrel at (-99,38,-43)
2016-03-19 00:06:12: ACTION[Server]: facedir: 3
2016-03-19 00:06:17: ACTION[Server]: TARD uses screwdriver:screwdriver, pointing at [node under=-99,38,-43 above=-98,38,-43]
2016-03-19 00:06:17: ERROR[Main]: ServerError: Lua: Runtime error from mod 'screwdriver' in callback item_OnUse(): ...bin/../$
2016-03-19 00:06:17: ERROR[Main]: stack traceback:
2016-03-19 00:06:17: ERROR[Main]: ...bin/../games/minetest_game/mods/screwdriver/init.lua:58: in function 'screwdriver_$
2016-03-19 00:06:17: ERROR[Main]: ...bin/../games/minetest_game/mods/screwdriver/init.lua:96: in function <...bin/../ga$

I recently added better xdecor support to the darkage mod.
but If I want to make the compatibility visible to the user by writing xdecor? to the depends.txt no nodes are cuttable anymore, because xdecor gets loaded before darkage.

2016-03-19 13:52:07: ACTION[Server]: amis uses simple_protection:claim, pointing at [node under=-58,-6,-9 above=-58,-5,-9]
2016-03-19 13:52:08: ACTION[Server]: amis uses simple_protection:claim, pointing at [node under=-58,-6,-9 above=-58,-6,-8]
2016-03-19 13:52:10: ERROR[Main]: ServerError: Lua: Runtime error from mod 'xdecor' in callback nodemeta_inventory_AllowPut(): /home/ubuntu/.minetest/mods/xdecor/encha$
2016-03-19 13:52:10: ERROR[Main]: stack traceback:
2016-03-19 13:52:10: ERROR[Main]: /home/ubuntu/.minetest/mods/xdecor/enchanting.lua:86: in function 'allowed'
2016-03-19 13:52:10: ERROR[Main]: /home/ubuntu/.minetest/mods/xdecor/enchanting.lua:95: in function </home/ubuntu/.minetest/mods/xdecor/enchanting.lua:91>

Hi, when I'm trying to access the mailbox the game crashes and I got the following error:

2016-05-30 19:20:32: ERROR[Main]: ServerError: Lua: Runtime error from mod 'titanium' in callback item_OnPlace(): ...t/minetest/bin/../games/minetest/mods/xdecor/mailbox.lua:11: attempt to index field 'tiles' (a nil value) 2016-05-30 19:20:32: ERROR[Main]: stack traceback: 2016-05-30 19:20:32: ERROR[Main]: ...t/minetest/bin/../games/minetest/mods/xdecor/mailbox.lua:11: in function 'img_col' 2016-05-30 19:20:32: ERROR[Main]: ...t/minetest/bin/../games/minetest/mods/xdecor/mailbox.lua:31: in function 'formspec' 2016-05-30 19:20:32: ERROR[Main]: ...t/minetest/bin/../games/minetest/mods/xdecor/mailbox.lua:85: in function 'on_rightclick' 2016-05-30 19:20:32: ERROR[Main]: /home/minetest/minetest/bin/../builtin/game/item.lua:333: in function </home/minetest/minetest/bin/../builtin/game/item.lua:326>

Hi, im here to report a bug to you, first an IRC discussion :

R_R_E_Designs : Cauldron is to cook. You can make soup in it.
ihatedrift : whaaaat
R_R_E_Designs : But it doesn't work. We tried with gravgun.
MinetestForFun : Why it doesn't work ?
R_R_E_Designs : He thinks it's due to buckets now working with right clik. Because you can't fill it with water.
R_R_E_Designs : Right clicking places a node of water, as normal, but doesn't fill the cauldron.
MinetestForFun : Oh, yes, that's a good point, I report it to kilbith

Like @rredesigns reported it to us, we met a problem with cauldrons when bucket working with right click, indeed we can't fill cauldrons is this case.

Please, can you add to your mod a way to fix it and, in the better case, add a minetest.conf option to activate the right click filling with bucket or not for your cauldrons ?

Thank you in advance,

There's a serious bug in this mod: You used paramtype="light" for many nodes, even “solid” ones. I bet you misunderstood what this paramtype means. A side-effect of this is that it will cause light to propagate THROUGH the node, so if you place a torch behind a stone tile (for example), it glows! I am sure this is not intended. You need this paramtype for nodeboxes usually but for normal cubes you should only use this paramtype if you really want light to go through (like for leaves or glass). First I thought this attribute is only set for the runestone (this is actually pretty interesting, maybe let's keep the light propagation for this stone) but after a quick check I noticed this is set for pretty much every node.

this first occured in 9d31ec9 .
Steps to reproduce:

1.) checkout 0a1e65b
2.) place some xwall nodes -> they connect to each other
3.) checkout 9d31ec9
4.) place some xwalls; they do no longer connect to one another

Currently there is no way to opt-in or opt-out any node for the workbench saw.

In my opinion it would be the best if the mod's author can decide by himself if it want to support xdecor or not. So please add a function like xdecor.register_for_workbench("modname:nodename").

Or add at least a way to opt out nodes that should not registered for workbench.

Btw: The workbench slows down loading of Minetest heavily:
with dofile workbench.lua:
[xdecor] loaded in 472 ms
with dofile workbench.lua commented out:
[xdecor] loaded in 21 ms

Currently this mod does not have a screenshot or description file included. Both are used when displaying the mod in the Mods tab of the main menu of Minetest.

The screenshot should be in a 3:2 aspect ratio, be named "screenshot.png", and be placed in the main directory of the mod.

The description file should be a small text file with a short description of the mod, be named "description.txt", and be placed in the main directory of the mod.

This looks ugly...

2016-01-10 03:30:27: ERROR[main]: UNRECOVERABLE error occurred. Stopping server. Please fix t
he following error:
2016-01-10 03:30:27: ERROR[main]: Lua: Double fault error from mod 'xdecor' in callback node_
on_receive_fields(): error in error handling

In thread 7f21b76c0780:
/home/user/minetest/src/server.cpp:511: void Server::step(float): A fatal error occurred: Lua
: Double fault error from mod 'xdecor' in callback node_on_receive_fields(): error in error h
andling
Debug stacks:
DEBUG STACK FOR THREAD 7f21aabfd700:
#0 virtual void* EmergeThread::Thread()

(Leftover data: #1 MapBlock* ServerMap::loadBlock(v3s16))
(Leftover data: #2 void ServerMap::loadBlock(std::string_, v3s16, MapSector_, bool))
(Leftover data: #3 void ItemStack::deSerialize(std::istream&, IItemDefManager*))
DEBUG STACK FOR THREAD 7f21ab5fe700:
#0 virtual void* CurlFetchThread::Thread()

DEBUG STACK FOR THREAD 7f21abfff700:
#0 virtual void* ServerThread::Thread()
#1 void Server::Receive()

(Leftover data: #2 virtual void Server::deletingPeer(con::Peer_, bool))
(Leftover data: #3 void RemoteClient::GetNextBlocks(ServerEnvironment_, EmergeManager_, floa
t, std::vector&))
(Leftover data: #4 void ItemStack::serialize(std::ostream&) const)
(Leftover data: #5 bool getCraftingResult(Inventory_, ItemStack&, std::vector&, b
ool, IGameDef_))
(Leftover data: #6 void ItemStack::deSerialize(std::istream&, IItemDefManager_))
(Leftover data: #7 void ItemStack::deSerialize(std::istream&, IItemDefManager*))
DEBUG STACK FOR THREAD 7f21b76c0780:
#0 int main(int, char**)
#1 Dedicated server branch
#2 void dedicated_server_loop(Server&, bool&)
#3 void Server::step(float)

(Leftover data: #4 void Server::SendAccessDenied_Legacy(irr::u16, const wstring&))

Mod updated ~ 24 hours ago. 0.4.13 stable with minetest_game development version. 93.170.76.99

Mods:

serveressentials
protection_lagporter
no_sneak_glitch
home_gui
daynight
chat2
advancedban
craft_guide
default
workbench
torches
mobs
fake_fire
compassgps
columnia
caverealms
boost_cart
xpanes
wool
lrfurn
boats
beds
farming
potions
stairs
darkage
vessels
tnt
give_initial_stuff
flowers
ethereal
creative
bucket
inventory_plus
skins
3d_armor
playeranim
wieldview
technic_armor
shields
hud
hunger
screwdriver
doors
xdecor
protector
dye

Several xdecor elements exist as part of xdecor and as standalone mod.

• https://github.com/minetest-mods/realchess
• https://github.com/minetest-mods/enchanting
• https://github.com/minetest-mods/workbench
• https://github.com/minetest-mods/craftguide

To reduce maintenance and development efforts, it would be great if we could deduplicate these.
For example by removing them from xdecor or by closing the standalone mod.

This decision could of course be made for each element individually.

What do you think?
Which elements would you like to use separate of xdecor, which would you miss in xdecor?

Wield image of enchanted shovels needs to be ^[transformR90'ed

If you have full inventory and you trying to replace item with a new item from "cut" menu, it will don't work.

Mod was download today.

• A global code cleaning.
• Use of texture atlases on some nodes, minetest/minetest@7057c1
• Use hardware coloring on the curtains, minetest/minetest@d04d8ab
• Make the enchantment table's glyph particles look better, minetest/minetest@7279f0b
• Add a shitload of new enchantments, minetest/minetest@a637107
• Make the enchantments stronger depending on the number of bookshelves around the table.
• Rehabilitate 3d_armor enchanting.
• Merge this and add aliases.
• Use minetest.register_on_mods_loaded() to determine which nodes to cut for the workbench.
• Polish the chess AI (using minimax + alpha-beta pruning).
• Fix the pane textures.
• Add an history log of moves in the chessboard.
• Import this patch: minetest-mods/realchess@f9188fe
• Add wooden panels with some hacks to display the town names depending on the pointing angle.
• Use a particle for item frame?
• Add a fish tank with fishes as particles.
• Bees particles around the hive.
• Import some nodes from ExtraBlocks.

I get this error trying to open mailbox with items inside:

2016-03-12 20:24:48: ERROR[Main]: ServerError: Lua: Runtime error from mod 'default' in callback item_OnPlace(): /home/john/.minetest/mods/xdecor/mailbox.lua:22: attempt to concatenate a nil value

...removed the :match bits and it worked for itemname and texture.

I added hive and planted some flowers under a tree but I'm not seeing any honey.

ERROR[Main]: ServerError: Lua: Runtime error from mod 'xdecor' in callback nodemeta_inventory_AllowPut(): /home/minetest/minetest/bin/../mods/xdecor/worktable.lua:7: attempt to index local 'def' (a nil value)
ERROR[Main]: stack traceback:
ERROR[Main]: #011/home/minetest/minetest/bin/../mods/xdecor/worktable.lua:7: in function 'nodes'
ERROR[Main]: #011/home/minetest/minetest/bin/../mods/xdecor/worktable.lua:270: in function </home/minetest/minetest/bin/../mods/xdecor/worktable.lua:266>

a player did tryed to put the hammer in the place...and the server crashed.

Hi

It would be really great with some documentation about usage. For example sitting in the cushion, how does one get up again?

Looking in the code seems like "sneak" + "right click", or maybe I have misunderstood? Anyway, we're get stuck in a sitting position.

Otherwise, great mod, thanks a lot!

This minetest-mods/craftguide@51a00b9 change must be also applied here imho @t4im

Trampolines look messed up
using the blank mailbox texture

If you sit down on a chair then hold w to walk, you will start moving and will be unable to jump, you will just be flying around in a sitting position and cannot go up or down. This is with no fly/noclip/fast privs on a two player server. Just tried in single player and it did the same thing. You have to rejoin to stop it or rightclick on the chair again.

http://i.imgur.com/cO7OlZO.png

https://vid.me/FY5p

Steps to reproduce bug: Right click in chair to sit on it, press any WASD key to move, you will now not be able to jump.

Not sure what yet, still trying to figure it out, and what they could have put in there to get it to crash.

2016-06-26 11:52:37: ERROR[Main]: ServerError: Lua: Runtime error from mod 'xdecor' in callback nodemeta_inventory_AllowPut(): ...i3hard139/.minetest/games/dcb/mods/xdecor/enchanting.lua:107: attempt to concatenate local 'tool' (a nil value)
2016-06-26 11:52:37: ERROR[Main]: stack traceback:
2016-06-26 11:52:37: ERROR[Main]:    ...i3hard139/.minetest/games/dcb/mods/xdecor/enchanting.lua:107: in function 'allowed'
2016-06-26 11:52:37: ERROR[Main]:    ...i3hard139/.minetest/games/dcb/mods/xdecor/enchanting.lua:116: in function <...i3hard139/.minetest/games/dcb/mods/xdecor/enchanting.lua:112>

Cc: @adrido

https://forum.minetest.net/viewtopic.php?p=226487#p226487

I also found out, that there are hundreds of nodes registered for that saw that doesn't make logically and from looking of the textures sense.

Please investigate and report which nodes should not be cuttable in the workbench, and share their definitions so that we can improve the filtering.

I noticed when right clicking a chair, and then left clicking it after sitting results in a sticky situation! Is there a way to "stand" upon movement keypress perhaps?

Since minetest/minetest_game@2c355a8 , the door api allow mods to register their doors in their own namespace. Just like it was with the old api.
And the auto-replace abm can now replace doors declared in mod namespace.

This could be used as a smooth transition from doors before 3fa4083 to new doors.

So the question is: will you get back to xdecor namespaced doors, or should I replace manually my current xdecor doors with the new one defined as doors:xdecor_... ?

Seems to check for armor, but shields is a separate mod.

Dans mechanisms.lua ligne 33, pour chaque porte trouvée la fonction door_toggle est lancée, ligne 6 elle check le nom du node, place un pressure_on puis le replace après 2 secondes par un _off, sauf que si il y a + d'une porte, la 1ère place un pressure_on, la 2ème trouve donc un pressure on, du coup elle replace un pressure_on.
C'est aussi lancé pour chaque player trouvés.

un 2eme bug/usebug, si entre temps on dig le pressure, vu qu'il est replacé après 2 secondes on peut récupérer un stack de pressure.

Hi, i updated as you requested and the server is falling into crashloop now ;)

Feb  5 22:48:14 lsw-minetest minetestserver[5548]: 2016-02-05 22:48:14: WARNING[Main]: Undeclared global variable "homedecor_register_slope" accessed at /home/minetest/minetest/bin/../mods/steel/steel/init.lua:196
Feb  5 22:48:14 lsw-minetest minetestserver[5548]: 2016-02-05 22:48:14: ERROR[Main]: ModError: Failed to load and run script from /home/minetest/tchncslsw/worldmods/xdecor/init.lua:
Feb  5 22:48:14 lsw-minetest minetestserver[5548]: 2016-02-05 22:48:14: ERROR[Main]: /home/minetest/tchncslsw/worldmods/xdecor/worktable.lua:348: attempt to index field 'tiles' (a nil value)
Feb  5 22:48:14 lsw-minetest minetestserver[5548]: 2016-02-05 22:48:14: ERROR[Main]: stack traceback:
Feb  5 22:48:14 lsw-minetest minetestserver[5548]: 2016-02-05 22:48:14: ERROR[Main]: #011/home/minetest/tchncslsw/worldmods/xdecor/worktable.lua:348: in main chunk
Feb  5 22:48:14 lsw-minetest minetestserver[5548]: 2016-02-05 22:48:14: ERROR[Main]: #011[C]: in function 'dofile'
Feb  5 22:48:14 lsw-minetest minetestserver[5548]: 2016-02-05 22:48:14: ERROR[Main]: #011/home/minetest/tchncslsw/worldmods/xdecor/init.lua:19: in main chunk

If you enchanted some tool then quick move it to inventory and press button again - server will crash. 0.4.13.

2016-02-04 22:11:42: ERROR[main]: UNRECOVERABLE error occurred. Stopping server. Please fix the following error:
2016-02-04 22:11:42: ERROR[main]: Lua: Runtime error from mod 'xdecor' in callback node_on_receive_fields(): ...r-13/minetest-rivergen/bin/../mods/xdecor/enchanting.lua:86: attempt to concatenate local 'name' (a nil value)
2016-02-04 22:11:42: ERROR[main]: stack traceback:
2016-02-04 22:11:42: ERROR[main]: ...r-13/minetest-rivergen/bin/../mods/xdecor/enchanting.lua:86: in function <...r-13/minetest-rivergen/bin/../mods/xdecor/enchanting.lua:79>

In thread b7180700:
/mnt/sda3/minetest-master-13/minetest-rivergen/src/server.cpp:511: void Server::step(float): A fatal error occurred: Lua: Runtime error from mod 'xdecor' in callback node_on_receive_fields(): ...r-13/minetest-rivergen/bin/../mods/xdecor/enchanting.lua:86: attempt to concatenate local 'name' (a nil value)
stack traceback:
...r-13/minetest-rivergen/bin/../mods/xdecor/enchanting.lua:86: in function <...r-13/minetest-rivergen/bin/../mods/xdecor/enchanting.lua:79>
Debug stacks:
DEBUG STACK FOR THREAD b3dffb40:
#0 virtual void* EmergeThread::Thread()

(Leftover data: #1 MapBlock* ServerMap::loadBlock(v3s16))
(Leftover data: #2 void ServerMap::loadBlock(std::string_, v3s16, MapSector_, bool))
(Leftover data: #3 void ItemStack::deSerialize(std::istream&, IItemDefManager*))
DEBUG STACK FOR THREAD b476bb40:
#0 virtual void* ServerThread::Thread()
#1 void Server::Receive()

(Leftover data: #2 void Server::SendBlocks(float))
(Leftover data: #3 void RemoteClient::GetNextBlocks(ServerEnvironment_, EmergeManager_, float, std::vector&))
(Leftover data: #4 void ItemStack::serialize(std::ostream&) const)
(Leftover data: #5 bool getCraftingResult(Inventory_, ItemStack&, std::vector&, bool, IGameDef_))
DEBUG STACK FOR THREAD b7180700:
#0 int main(int, char**)
#1 Dedicated server branch
#2 void dedicated_server_loop(Server&, bool&)
#3 void Server::step(float)

After commit f892413, as sandstone has the crumbly group, it's excluded from the cuttable nodes.

As a quick fix for me, I modified the worktable.nodes function to:

function worktable.nodes(def)
    if(def.groups["cuttable"]) then
        return true
    end

    return (def.drawtype == "normal" or def.drawtype:find("glass")) and not
        def.on_construct and not def.after_place_node and not
        def.after_place_node and not def.on_rightclick and not
        def.on_blast and not def.allow_metadata_inventory_take and not
        def.groups["crumbly"] and not def.groups["not_in_creative_inventory"] and not
        def.description:find("Ore") and def.light_source == 0 and
        def.description
end

And added the "cuttable" group to the sandstone.

Several items are not craftable because there are missing recipes for xpanes:bar, xpanes:rusty_bar, xpanes:chainlink. The actual craftable versions of these xpanes things are not what the prison_door, rusty_prison_door, screen_door and iron_lightbox expect.

Mailbox broke. Always shows formspec for insertion and never owner formspec.