Code Monkey home page Code Monkey logo

Comments (8)

Napiophelios avatar Napiophelios commented on June 15, 2024

aside from players' awareness of the compatibility,
what do you lose if you don't add xdecor to the depends text?

Can't you just add something to the mod description to let players know
about the added features if xdecor is present?

from xdecor.

adrido avatar adrido commented on June 15, 2024

I do lose nothing. The only odd thing is that you can explicitly drop support of xdecor that way

from xdecor.

adrido avatar adrido commented on June 15, 2024

Another odd thing is if there is a mod eg. called "zoo". zoo gets probably loaded after xdecor so zoo nodes are never compatible to xdecor (not cuttable in workbench)

I does not know how Minetest sets the load order, but if this changes some day because another mod is added that leads to a different load order, mods that where previously compatible with xdecor does not longer work anymore.

from xdecor.

Napiophelios avatar Napiophelios commented on June 15, 2024

I see what you mean.
I added xdecor to a modpack to work around the problem in my subgame.
This is really the only solution I could think of without modifying xdecor.
This helps with controlling the load order, but doesn't help with adding it as a dependency though.

from xdecor.

kilbith avatar kilbith commented on June 15, 2024

Yeah, the workbench filtering is some kind of a hack, since mods are loaded in alphabetical order and xdecor is often loaded in last position or close.

Like @Napiophelios says, I suggest to do not recommend xdecor in depends.txt and fill that table with the nodes you want to be cut : https://github.com/minetest-mods/xdecor/blob/master/src/workbench.lua#L31

from xdecor.

adrido avatar adrido commented on June 15, 2024

Uhm you forgott that workbench is a local variable and cant be accessed by any mod
https://github.com/minetest-mods/xdecor/blob/master/src/workbench.lua#L31

from xdecor.

kilbith avatar kilbith commented on June 15, 2024

There you go : 4209040

from xdecor.

adrido avatar adrido commented on June 15, 2024

Thanks

from xdecor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.