1. open vscode (version 1.17.2)
2. search edge extension and install
   verify the edge installation version is 0.1.0 instead of 0.2.0
   Is it by design?

Currently, Dockerfile for ARM32V7 can only be built on Linux X64 because .NET Core SDK is not supported yet on ARM (see https://github.com/dotnet/core/blob/master/samples/RaspberryPiInstructions.md)

On the other hand, the RUN command is not supported when building on Linux X64, so users cannot add custom steps into the runtime image except copying the .NET Core dlls.

1. New edge solution in vscode
2. input "test" as module name.
3. Open deployment.template.json and the router name in routers are "sensorToFilter" "filterToIoTHub". It is confusing to user the router name doesn't honor the module name

steps:
1.create new IoT Edge solution
2.Add 1 C# Edge Module
3.delete the launch.json in your .vscode folder
4.press F5 and select IoT Edge (.NER Core).
verify launch.json is generated.
5. Add another C# Edge Module
verify the module was created successfully, but get an error when updated launch.json file. the new module was not added in launch.json.

otherwise, users will build linux image when clicking the windows-amd64 without warning.

OS: Microsoft Windows [Version 10.0.16299.248]

Docker Version:

Version 17.12.0-ce-win47 (15139)
Channel: stable
9c692cd

Inner Loop in VS Code

Optimized C# module experience

Raw logs:

bugbash.log

In https://github.com/shizn/azure-docs-pr/blob/master/articles/iot-edge/tutorial-multiple-modules-in-vscode.md#prepare-your-first-iot-edge-solution,
"PipeFunctionToIoTHub": "FROM /messages/modules/SampleFunction/outputs/output1 INTO $upstream" shoud be "PipeFunctionToIoTHub": "FROM /messages/modules/SampleFunction/outputs/alertOutput INTO $upstream"

now user can click host.json file to select "Convert to IoT Edge Module", but the edge command is not support "Convert to IoT Edge Module" now.

1.Open a legacy C# Function Module project
2.Right-click on host.json file, and click Convert to IoT Edge Module

https://review.docs.microsoft.com/en-us/azure/iot-edge/tutorial-csharp-module?branch=pr-en-us-35471#create-an-iot-edge-module-project

Better to use this link: https://pip.pypa.io/en/stable/installing/#installation

From https://github.com/MicrosoftDocs/azure-docs-pr/pull/35471#commitcomment-28118909

Create a new IoT Edge Solution named EdgeSolution with a C# Module SampleModule.
Build IoT Edge Solution
Deploy to IoT Edge device (local machine)
Debug > Debug IoT Edge Module SampleModule (.NET Core)

Observe: 'Name not defined in current configuration' error in VS Code.

if the module name is "c#module03", and localhost:5000/"c#module03"

Verify the deployment.template.json file is not updated: the module JSON is not added into the modules section

From https://github.com/MicrosoftDocs/azure-docs-pr/pull/35471#commitcomment-28118863

if input module name is /Sample/Module/, will get error :
Command failed with exit code 214750003

The current Dockerfile.amd64.debug causes significantly longer rebuild times than necessary, and requires significantly more bytes to be pushed due to Docker layer changes. With the changes below, a trivial C# Module on rebuild only needs to push ~10MB instead of 170MB+, and rebuilds are faster since the vsdbg layer is cached. The main issue is vsdbg is installed as one of the last steps, when it should be installed as one of the first steps.

Current Dockerfile.amd64.debug template:

FROM microsoft/dotnet:2.0-sdk AS build-env
WORKDIR /app

COPY *.csproj ./
RUN dotnet restore

COPY . ./
RUN dotnet publish -c Debug -o out

FROM microsoft/dotnet:2.0-runtime-stretch AS runtime
WORKDIR /app
COPY --from=build-env /app/out ./

RUN apt-get update
RUN apt-get install -y unzip procps
RUN curl -sSL https://aka.ms/getvsdbgsh | bash /dev/stdin -v latest -l ~/vsdbg

ENTRYPOINT ["dotnet", "echo-service.dll"]

Improved Dockerfile.amd64.debug template:

FROM microsoft/dotnet:2.0-runtime-stretch AS runtime

RUN apt-get update
RUN apt-get install -y unzip procps
RUN curl -sSL https://aka.ms/getvsdbgsh | bash /dev/stdin -v latest -l ~/vsdbg

FROM microsoft/dotnet:2.0-sdk AS build-env
WORKDIR /app

COPY *.csproj ./
RUN dotnet restore

COPY . ./
RUN dotnet publish -c Debug -o out

FROM runtime
WORKDIR /app
COPY --from=build-env /app/out ./

ENTRYPOINT ["dotnet", "echo-service.dll"]

We may meet with below error, when edgeHub Module not started, but Python Module started

1. install the released function template (to test the legacy template)
2. Select deployment.template.json to add module
3. Use C# function module type
4. Error shows since there is no "-r" option in legacy template
5. Check the deployment.template.json and launch.json, however, they are both updated.

Desired:
if new module failed, deployment.template.json and launch.json should not be updated

there is no readme file in new Edge solution now

https://review.docs.microsoft.com/en-us/azure/iot-edge/tutorial-multiple-modules-in-vscode?branch=pr-en-us-35471#prepare-your-first-iot-edge-solution

steps:
1.create a new IoT Edge solution (c# Module)
2.add 3 IoT Edge Module
3.Build IoT Edge Solution
4.Deploy Edge Device
5.Setup and start Edge runtime
6.Debug Edge Module
Navigate to debug view, and select “Debug IoT Edge Module SampleModule (.NET Core)”, then press F5
get error :
Executing: docker exec -i SampleModule sh -c "sh -s" < C:\Users\v-czg.vscode\extensions\ms-vscode.csharp-1.14.0\scripts\remoteProcessPickerScript
Linux
stderr: sh: 1: ps: not found
Error Message: Command failed: docker exec -i SampleModule sh -c "sh -s" < C:\Users\v-czg.vscode\extensions\ms-vscode.csharp-1.14.0\scripts\remoteProcessPickerScript
sh: 1: ps: not found

After Build IoT Edge solution, the .config should be config:

1. New IoT Edge solution
2. Add Python Module
3. build and push the Iot edge image
   4.Generate IoT Edge Deployment Manifest
   
4. Create deployment for Edge device
   6.Setup and start Edge runtime
   7.Debug Edge Module
   there is an error:
   Unable to open 'DotNetFunctionInvoker.cs': File not found (file:///home/ahmed/repos/azure-webjobs-sdk-script/src/WebJobs.Script/Description/DotNet/DotNetFunctionInvoker.cs).

steps:
1.Open a legacy C# Module project
2. Right-click on .csproj file, and click Convert to IoT Edge Module
Verify an error will throw out.
It would be better to display a message instead of an error.

https://review.docs.microsoft.com/en-us/azure/iot-edge/tutorial-python-module?branch=pr-en-us-35471

Steps:
1.create a new IoT edge solution
2.add 2 function modules
3.Verify the deployment.template.json file
the second module route JSON is not added into the routes block.
now it only has the first module route json here.

From https://github.com/MicrosoftDocs/azure-docs-pr/pull/35471#commitcomment-28119491

If the user used the new Edge extension to build and push the image, the image tag should be the version and the platform, e.g., "0.0.1-arm64", not "latest".

In the Prerequisites, Python extension for Visual Studio Code is optional, not required. Better to make it be:

[Optional] Python extension for Visual Studio Code

Right-click the deployment.template.json file, and click Build IoT Edge Solution
verify all the modules are built ,but pushed failed

because user not start a local registry:  docker run -d -p 5000:5000 --name registry registry:2 

but in our tool , Did not tell the user to register it.

The name 'deployment.template.json' is hard-coded for the 'Generate IoT Edge Deployment Manifest' command. There are significant differences when building arm32v7 (e.g. the container images for systemModules are different, plus all my module images). It would be nice to support platforms:

[1] 'Generate IoT Edge Deployment Manifest' and 'Build IoT Edge Solution' should have a parameter to pick which platform to build from the same set in module.json (amd64/amd64.debug/arm32v7/windows-amd64), which is filled in as a parameter in the deployment.template.json - ${MODULES..PLATFORM}

After edge solution is created, it would be better if VS Code will open a new window with my solution. Now VS Code will close original window and reload with my solution

Users may be confused with the "Run the solution" part when directly follow the steps in "Develop a Python module" document to play.

This document never mention that simulate an edge device is required until users go to "Run solution" part.

1. New Edge Solution project
2. Select the folder
3. Drop down shown to select module type
4. There is no python module

Right-click on deployment.template.json file, and click Add IoT Edge Module

Follow the steps and input required fields to add a new module
the SampleModule already exist, so I want to add a Module named FunctionSampleModule

when I input the first letter F, The cursor will automatically move to the end of the word

Steps:
1.press F1 and select Edge:create Edge Device
2.input device ID named edgeDeviceC#
verify there is an error as bellow.

[Edge Device] Creating Edge Device 'edgeDeviceC#'
[Edge Device] [Create] error: ArgumentError: Error:

Bad Request - Invalid URL

HTTP Error 400. The request URL is invalid.

ISSUE
Some Dockerfiles require additional arguments to build correctly. For example, some may require Environment variables or other arbitrary Docker arguments (--add-host). Right now, the docker build command only supports custom image tags:
https://github.com/Microsoft/vscode-azure-iot-edge/blob/master/src/container/containerManager.ts

SOLUTION
Add support in module.json for extra Docker build commands. E.g. add a parameter for docker build arguments:

"docker": {
"build-args": [ "arg1", "arg2" ]
}

Please advise what to do or install to solve that in the document.
The error I got is '[pylint] E0401:Unable to import 'iothub_client''

if user want to delete an Edge Module in solution, after click delete, the deployment.template.json/launch.json  file is not updated.

Follow the doc : https://review.docs.microsoft.com/en-us/azure/iot-edge/tutorial-python-module?branch=pr-en-us-35471
Got the following error:

Machine temperature 27.0104326896 exceeds threshold 25
Confirmation[0] received for message with result = OK
Properties: {'MessageType': 'Alert'}
Total calls confirmed: 11
Data: <<<{"machine":{"temperature":27.030986996382,"pressure":1.6870744679422534},"ambient":{"temperature":20.770010575312195,"humidity":24},"timeCreated":"2018-03-16T08:34:29.5137673Z"}>>> & Size=177
Properties: {}
Total calls received: 12
Machine temperature 27.0309869964 exceeds threshold 25
Confirmation[0] received for message with result = OK
Properties: {'MessageType': 'Alert'}
Total calls confirmed: 12

Python 2.7.12 (default, Dec 4 2017, 14:50:18)
[GCC 5.4.0 20160609]

IoT Hub Client for Python
Adding TrustedCerts from: /mnt/edgemodule/edge-device-ca.cert.pem
set_option TrustedCerts successful
Starting the IoT Hub Python sample using protocol MQTT...
The sample is now waiting for messages and will indefinitely. Press Ctrl-C to exit.
Error: Time:Fri Mar 16 08:45:46 2018 File:/usr/sdk/src/c/c-utility/adapters/socketio_berkeley.c Func:socketio_open Line:584 Failure: socket state is not closed.
Error: Time:Fri Mar 16 08:45:46 2018 File:/usr/sdk/src/c/c-utility/src/tlsio_openssl.c Func:on_underlying_io_open_complete Line:751 Invalid tlsio_state. Expected state is TLSIO_STATE_OPENING_UNDERLYING_IO.
Error: Time:Fri Mar 16 08:45:46 2018 File:/usr/sdk/src/c/c-utility/src/tlsio_openssl.c Func:tlsio_openssl_open Line:1251 Failed opening the underlying I/O.
Error: Time:Fri Mar 16 08:45:46 2018 File:/usr/sdk/src/c/umqtt/src/mqtt_client.c Func:mqtt_client_connect Line:980 Error: io_open failed
Error: Time:Fri Mar 16 08:45:46 2018 File:/usr/sdk/src/c/iothub_client/src/iothubtransport_mqtt_common.c Func:SendMqttConnectMsg Line:1932 failure connecting to address iverwin10.fareast.corp.microsoft.com.
Error: Time:Fri Mar 16 08:45:48 2018 File:/usr/sdk/src/c/c-utility/adapters/socketio_berkeley.c Func:socketio_open Line:584 Failure: socket state is not closed.
Error: Time:Fri Mar 16 08:45:48 2018 File:/usr/sdk/src/c/c-utility/src/tlsio_openssl.c Func:on_underlying_io_open_complete Line:751 Invalid tlsio_state. Expected state is TLSIO_STATE_OPENING_UNDERLYING_IO.
Error: Time:Fri Mar 16 08:45:48 2018 File:/usr/sdk/src/c/c-utility/src/tlsio_openssl.c Func:tlsio_openssl_open Line:1251 Failed opening the underlying I/O.
Error: Time:Fri Mar 16 08:45:48 2018 File:/usr/sdk/src/c/umqtt/src/mqtt_client.c Func:mqtt_client_connect Line:980 Error: io_open failed
Error: Time:Fri Mar 16 08:45:48 2018 File:/usr/sdk/src/c/iothub_client/src/iothubtransport_mqtt_common.c Func:SendMqttConnectMsg Line:1932 failure connecting to address iverwin10.fareast.corp.microsoft.com.
Error: Time:Fri Mar 16 08:45:52 2018 File:/usr/sdk/src/c/c-utility/adapters/socketio_berkeley.c Func:socketio_open Line:584 Failure: socket state is not closed.
Error: Time:Fri Mar 16 08:45:52 2018 File:/usr/sdk/src/c/c-utility/src/tlsio_openssl.c Func:on_underlying_io_open_complete Line:751 Invalid tlsio_state. Expected state is TLSIO_STATE_OPENING_UNDERLYING_IO.
Error: Time:Fri Mar 16 08:45:52 2018 File:/usr/sdk/src/c/c-utility/src/tlsio_openssl.c Func:tlsio_openssl_open Line:1251 Failed opening the underlying I/O.
Error: Time:Fri Mar 16 08:45:52 2018 File:/usr/sdk/src/c/umqtt/src/mqtt_client.c Func:mqtt_client_connect Line:980 Error: io_open failed
Error: Time:Fri Mar 16 08:45:52 2018 File:/usr/sdk/src/c/iothub_client/src/iothubtransport_mqtt_common.c Func:SendMqttConnectMsg Line:1932 failure connecting to address iverwin10.fareast.corp.microsoft.com.
Error: Time:Fri Mar 16 08:46:00 2018 File:/usr/sdk/src/c/c-utility/adapters/socketio_berkeley.c Func:socketio_open Line:584 Failure: socket state is not closed.
Error: Time:Fri Mar 16 08:46:00 2018 File:/usr/sdk/src/c/c-utility/src/tlsio_openssl.c Func:on_underlying_io_open_complete Line:751 Invalid tlsio_state. Expected state is TLSIO_STATE_OPENING_UNDERLYING_IO.
Error: Time:Fri Mar 16 08:46:00 2018 File:/usr/sdk/src/c/c-utility/src/tlsio_openssl.c Func:tlsio_openssl_open Line:1251 Failed opening the underlying I/O.
Error: Time:Fri Mar 16 08:46:00 2018 File:/usr/sdk/src/c/umqtt/src/mqtt_client.c Func:mqtt_client_connect Line:980 Error: io_open failed

Setting Docker, downloading Docker components and creating docker image takes a lot of time in my machine.
There is no need to do that work in local if I don't want to do local testing and debugging.
Consider move that part to Azure so that I could submit code only.