Code Monkey home page Code Monkey logo

draw-bridge's Introduction

Draw-Bridge

Curseforge Downloads Curseforge Versions Discord

This mod adds a draw bridge block.

How to build this mod

Setup Eclipse

  • ./gradlew genEclipseRuns eclipse
  • Import project as existing workspace

Setup IntelliJ IDEA

  • ./gradlew genIntellijRuns
  • Import as gradle project

Build

  • ./gradlew build

How to include this mod

  • Repository: repo.u-team.info
  • Artifact: info.u-team:draw_bridge-${config.forge.mcversion}:${config.drawbridge.version}
  • {config.forge.mcversion} is the minecraft version.
  • {config.drawbridge.version} is the drawbridge version.

Using in Forge Gradle 3:

repositories {
    maven { url = "https://repo.u-team.info" }
}

dependencies {
  compileOnly fg.deobf("info.u-team:draw_bridge-${config.forge.mcversion}:${config.drawbridge.version}")
}

License

  • This mod is licensed under apache 2 license. For more information see here.
  • This mod can be packed in any curseforge modpack you like.

Issues

  • Please report issues to the github issues.
  • Include your minecraft version, forge version and mod version.
  • Upload your log on gist or pastebin and include link in your report.

draw-bridge's People

Contributors

crimix avatar dependabot-preview[bot] avatar dependabot[bot] avatar hycrafthd avatar imgbotapp avatar mrtroble avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar

draw-bridge's Issues

[1.14.4] Draw Bridge not rendered when extended

Describe the bug
When the drawbridge is extended, the Draw Bridge block itself becomes invisible, giving XRay below it

To Reproduce
Steps to reproduce the behavior:

  1. Put fences/walls/any other non-full, but solid block in the Draw Bridge
  2. Extend Draw Bridge
    Doesn't matter if you have a Displayed Block in or not

Expected behavior
The Draw Bridge, or its chosen rendered block to be displayed below the wall/fence

Screenshots
2019-10-31_20 59 58

Versions

  • Minecraft Version 1.14.4
  • Forge Version 28.1.69
  • UTeamCore Version 2.7.5.135-SNAPSHOT
    I know it's not the latest version of the UTeamCore, but I didn't see this mentioned in the changelog

[1.12.2] Race condition result in infinite loop (very rare, but happens)

The usage of parallelStream result in off thread execution of certain checks in the minecraft world. This should never be done in an other thread than the main minecraft thread. Fix by using stream() instead of parallelStream().

Used here:

final boolean newPoweredState = drawBridges.parallelStream().anyMatch(drawBridge -> world.isBlockPowered(drawBridge.pos)) | newPowered;

drawBridges.parallelStream().forEach(drawBridge -> drawBridge.updatePoweredState(newPoweredState));

getNeighbors(callerTileEntity.pos).parallelStream().forEach(neighbor -> {

Does not work in water

Drawbridge does not work in water. Only works with air.

(put here by mod maker's request. Thanks for making a great mod!)

1.15.2 Client crash when applying camouflage

If I try to place a stone brick wall as the camouflage the client crashes. This also crashes any other players on our server who are in the same chunk.

Expected behavior
It would be nice if the drawbridge would prevent non-compatible blocks from being applied to the camouflage slot in the draw bridge block.

Versions

  • Mod version: draw_bridge-1.15.2-1.4.3.18
  • Minecraft version: 1.15.2
  • Forge version: 31.1.88
  • UTeamCore version: u_team_core-1.15.2-2.11.0.156.jar

https://paste.ee/p/24FNz
https://paste.ee/p/8HYxI

BTW: I love your mod!

Request - Sounds / Animation

Hi again o/

I would like to suggest that you add the placement sound of blocks that the Drawbridge places, when the Drawbridge is activated.

Additionally, and I know this is (also) a big suggestion, but a draw/retract animation would be really cool, to add a little extra flare.

I hope you'll consider it, and thank you for making the mod regardless :)

[1.14.4] Drawbridge Render as non-full block

Describe the bug
using the drawerbridge, there is a slot for the block to render as another to blend in with the rest of your base, but as you can see if its not a full block it allows x-ray

Additionally, placing a complex block as the render block can crash you - It does with a Wire from the mod Silent Mechanisms. Crash-report at the bottom.

To Reproduce
Steps to reproduce the behavior:

  1. Place Drawbridge
  2. Give it a torch as a render item
  3. See-through drawbridge

Expected behavior
For the Drawbridge to reject/not accept the item, or otherwise indicate that it should not be used. Maybe default to normal Drawbridge render.

Screenshots
Screenshot

Versions

  • Minecraft Version 1.14.4
  • Forge Version 28.1.39
  • UTeamCore Version 1.14.4-2.7.4.134

Log (if crash occures)
https://gist.github.com/NillerMedDild/9bbd31a0abf3aeea8374d42927659342

[1.12.2] Dupe glitch using pistons

Basically, pistons can be used on a draw bridge to duplicate the blocks already in it.
To reproduce, just place down a sticky piston, put a draw bridge block on the front of the piston, put some blocks into the draw bridge, and activate the piston.
The blocks inside the draw bridge will come out of it as if it were being broken, and if you click on the drawbridge, the blocks will still be in there.

Game version: 1.12.2
Mod version: 1.12.2-1.2.1.8

[Suggestion] Some sort of button to toggle the power state for the Drawbridge Block.

By default, the drawbridge block is 'off' and needs a redstone signal in order to place the blocks. Could there be some sort of button to invert the block's power state?

Like... for example... if you turn it's power state to 'on'... it'll place the blocks as if it had a redstone signal, however if you give it a redstone signal while it's 'on'... it'll turns off and put away the blocks.

I guess you could call it a 'Inverted Drawbridge Block' in a way.

[Suggestion] Push players/elevator

It would be great to have the blocks push the player upwards if he stands over the drawbridge. This would allow elevators.
I'm not a programmer but I guess it would just take teleport commands (one teleport command if the drawbridge is set to 0 ticks or multiple teleport commands if the drawbridge is set to >0 ticks).

drawbridge cannot be hidden with a block of grass

Bug description and reproduction steps

I have tried to hide the drawbridge block with a block of grass, but its texture became very weird and it looks grey, is there a way to fix this problem?

Log files and Screenshots

2024-03-26_14 48 25

Used minecraft version

1.12.x

Used forge or fabric version

14.23.5.2860

Used mod version

Draw-Bridge-1.12.2-1.2.1.8

[1.14.4] Some render issues

Describe the bug
Does not render the side of the drawbridge model if a non solid block is connected. Only happens if the drawbridge extends this block.

To Reproduce
Steps to reproduce the behavior:

  1. Place anvils in the drawbridge
  2. Extend
  3. Bug happen

Expected behavior
Should render the drawbridge or the cammoflage model.

Screenshots
grafik

Versions

  • Minecraft Version: 1.14.4
  • Forge Version: 28.1.70
  • UTeamCore Version: 2.7.4.134
  • Mod Version: 1.2.3.12

[MC-Version] 1.12.2

Bug description and reproduction steps

disguise block not showing rendering

Log files and Screenshots

[DynamicBakedModelProvider.class:?]
at net.minecraft.client.renderer.block.model.ModelManager.getModel(ModelManager.java:42) [cgc.class:?]
at net.minecraftforge.client.ItemModelMesherForge.getItemModel(ItemModelMesherForge.java:541) [ItemModelMesherForge.class:?]
at net.minecraft.client.renderer.ItemModelMesher.getItemModel(ItemModelMesher.java:44) [buv.class:?]
at net.minecraft.client.renderer.RenderItem.getItemModelWithOverrides(RenderItem.java:247) [bzw.class:?]
at codechicken.lib.render.item.CCRenderItem.getItemModelWithOverrides(CCRenderItem.java:393) [CCRenderItem.class:?]
at codechicken.lib.render.item.CCRenderItem.renderItemAndEffectIntoGUI(CCRenderItem.java:334) [CCRenderItem.class:?]
at net.minecraft.client.gui.inventory.GuiContainer.drawSlot(GuiContainer.java:265) [bmg.class:?]
at net.minecraft.client.gui.inventory.GuiContainer.drawScreen(GuiContainer.java:98) [bmg.class:?]
at cpw.mods.ironchest.client.gui.chest.GUIChest.drawScreen(GUIChest.java:100) [GUIChest.class:?]
at net.minecraftforge.client.ForgeHooksClient.drawScreen(ForgeHooksClient.java:396) [ForgeHooksClient.class:?]
at net.minecraft.client.renderer.EntityRenderer.updateCameraAndRender(EntityRenderer.java:1124) [buq.class:?]
at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1119) [bib.class:?]
at net.minecraft.client.Minecraft.run(Minecraft.java:3614) [bib.class:?]
at net.minecraft.client.main.Main.main(SourceFile:123) [Main.class:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_51]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_51]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51]
at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51]
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
Caused by: com.google.common.util.concurrent.UncheckedExecutionException: java.lang.RuntimeException: Encountered an exception when loading model definition of model minecraft:blockstates/old_wood_slab.json

the blocks exrtend out ok just the drawbridge block remains the same and does not update when adding a block to disguise it

Used minecraft version

1.12.x

Used forge or fabric version

forge 14.23.5.285

Used mod version

1.2.1.8

[1.14.4] Render issue with animation when using not full blocks

Describe the bug
See screenshot. It renders the ironbars kind of weird.

To Reproduce
Steps to reproduce the behavior:

  1. Insert ironbars and an other block
  2. Extract the drawbridge
  3. Look at the animation

Expected behavior
I don't know if that is fixable, but it seems the block state for rendering is kind of buggy.

Screenshots
grafik

Versions

  • Minecraft Version: 1.14.4
  • Forge Version: 28.1.70
  • UTeamCore Version: 2.7.4.134
  • Mod Version: 1.2.3.12

[1.14.4] Blocks already in the range are consumed

Describe the bug
When you extend the Draw Bridge, blocks that are already in its extension area are simply consumed. It seems to have a low chance to add those back to the inventory

To Reproduce
Steps to reproduce the behavior:

  1. Place down Draw Bridge
  2. Place 1 item in the first slot
  3. Place 1-9 blocks in the world, in front of the Draw Bridge
  4. Power Draw Bridge
  5. De-power Draw Bridge
  6. All blocks you placed are likely gone now. Not in the inventory of the Draw Bridge, nor will push out again when powering it

Expected behavior
To either ignore blocks it didn't place (preferred, goes well with #14 too), or add those picked up blocks to its inventory.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions

  • Minecraft Version 1.14.4
  • Forge Version 28.1.69
  • UTeamCore Version 2.7.5.135-SNAPSHOT

Powered Draw Bridge oddity?

I was going to suggest a linked draw bridge kind of thing where if you have draw bridge blocks connecting to one another... they would all power on from one redstone source. That's kind there... here's an image with 3 drawbridge blocks with 3 iron bars in each of them.

"Left"
The draw bridge block in the middle is powered by the actual redstone and apparently it powers up the blocks on the sides allowing a 3 block door, if you wish.

"Right"
The draw bridge block in the middle is powered by the block that the redstone is placed on... and only one places the blocks that are stored while the other two are not powered.

Unsure if it's a quirk with the redstone or maybe I'm missing something. There's no hidden redstone in the works in the picture.

If this is just vanilla minecraft doing it's think... don't suppose linked drawbridges could become a thing? Could be neat to have say a hanger doorway of some sorts or a 3x3 door made of glass or something.

[1.14.4] Crash when opening Draw Bridge

Describe the bug
I crashed directly after opening the GUI of a Drawbridge.

To Reproduce
Steps to reproduce the behavior:

  1. Obtain Drawbridge
  2. Place it
  3. Open it

Expected behavior
The Drawbridge GUI to open.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions

  • 1.14.4
  • forge-1.14.4-28.1.20
  • u_team_core-1.14.4-2.7.3.132
  • draw_bridge-1.14.4-1.2.2.9

Log (if crash occures)
https://gist.github.com/NillerMedDild/2d9f4bccbfb58873ec022926df2de041

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.