Code Monkey home page Code Monkey logo

Comments (29)

HyCraftHD avatar HyCraftHD commented on September 15, 2024 3

Thanks for the suggestions.
The sound is easy and was a plan in further updates. (Currently this is only a port of the 1.12.2 version)

Animations would be very cool but I don't really know how to do this in a performant way. @MrTroble Do you have an idea?

from draw-bridge.

MrTroble avatar MrTroble commented on September 15, 2024 3

Update: Pistons seem to use a special render while extending. I will go for that too. This should be pretty doable.

from draw-bridge.

MrTroble avatar MrTroble commented on September 15, 2024 2

I have fixed an other round of bugs!
Sounds still missing

from draw-bridge.

MrTroble avatar MrTroble commented on September 15, 2024 1

Possible, have to look into the block rendering system again ... I may have some time in the future to do so. Might be worth to look into pistons!

Cheers
~MrTroble

from draw-bridge.

MrTroble avatar MrTroble commented on September 15, 2024 1

OK I found both issues and fixed them

from draw-bridge.

MrTroble avatar MrTroble commented on September 15, 2024

So I made some progress. https://youtu.be/LJeQlTn-B_4 Looking good? Any feedback?

from draw-bridge.

NielsPilgaard avatar NielsPilgaard commented on September 15, 2024

That looks awesome! I would speed it up a bit though, maybe 1.25x.

from draw-bridge.

MrTroble avatar MrTroble commented on September 15, 2024

The speed is actually determined by the speed the bridge is extending at. In other words you can modify the speed with the speed modifier in the GUI.

Cheers
~MrTroble

from draw-bridge.

NielsPilgaard avatar NielsPilgaard commented on September 15, 2024

Damn, great work! :D
Would it be possible to apply the smooth movement to the very first block as well? It looks like it just appears/disappears.

from draw-bridge.

MrTroble avatar MrTroble commented on September 15, 2024

Yeah this is currently a problem in the backend I will try to rewrite this bits asap.
It is actually more work then I anticipated.

Cheers
~MrTroble

from draw-bridge.

MrTroble avatar MrTroble commented on September 15, 2024

@HyCraftHD Ya wanna make sounds?

from draw-bridge.

HyCraftHD avatar HyCraftHD commented on September 15, 2024

Im not sure what sound we should make. A continues sond when the drawbridge extracts or just a sound per block place?

from draw-bridge.

MrTroble avatar MrTroble commented on September 15, 2024

A would suggest a continues sound as the animation is also continues. Any suggestions @NillerMedDild

Cheers
~MrTroble

from draw-bridge.

NielsPilgaard avatar NielsPilgaard commented on September 15, 2024

I also think continuous sound would make the most sense. What about a continuous wire pulling sound, and when each block is fully placed, play the piston sound?

I hope you know what I mean by wire pulling sound, otherwise I'll try to find some reference material this evening :)

from draw-bridge.

MrTroble avatar MrTroble commented on September 15, 2024

I would appreciate some reference sound tho.

Cheers
~MrTroble

from draw-bridge.

NielsPilgaard avatar NielsPilgaard commented on September 15, 2024

I couldn't find what I was thinking of, so... nevermind on the wire pulling sound :P

from draw-bridge.

MrTroble avatar MrTroble commented on September 15, 2024

What in the world a we doing for sound then?

from draw-bridge.

HyCraftHD avatar HyCraftHD commented on September 15, 2024

Well, I'll find something. But other question. Is your animation system now working without any bugs?

from draw-bridge.

MrTroble avatar MrTroble commented on September 15, 2024

It is just not rendering the first one but besides the everything seems to be bugfree

from draw-bridge.

HyCraftHD avatar HyCraftHD commented on September 15, 2024

Okay, can you fix that in reasonable time?
I'll then try to find a sound.

from draw-bridge.

MrTroble avatar MrTroble commented on September 15, 2024

I will do it just now.

from draw-bridge.

MrTroble avatar MrTroble commented on September 15, 2024

The new beta version should be on curseforge! Still missing sound tho
Thank you for your request. Please go check it out. I'd be happy to get some feedback on it :)

Cheers
~MrTroble

from draw-bridge.

NielsPilgaard avatar NielsPilgaard commented on September 15, 2024

I'll check it out right away, thanks :D

from draw-bridge.

NielsPilgaard avatar NielsPilgaard commented on September 15, 2024

It looks really great! I did find 2 things that made me go huh though:

  • Drawbridges set to the same speed, triggered at the same time, will extend their blocks with a short delay. About 1 redstone tick between the Drawbridges as far as I can tell.
  • Extending Iron Bars results in the Iron Bar collision box being the same as a full block. This is a really minor issue, just something I noticed.

from draw-bridge.

MrTroble avatar MrTroble commented on September 15, 2024

ok the first one is weird. I know where the second one is coming from, this was done due to rendering issues. I will fix this asap

from draw-bridge.

MrTroble avatar MrTroble commented on September 15, 2024

An other release is out now!

from draw-bridge.

NielsPilgaard avatar NielsPilgaard commented on September 15, 2024

Thank you!

from draw-bridge.

HyCraftHD avatar HyCraftHD commented on September 15, 2024

Because the animation introduced so many bugs and @MrTroble didn't have time to fix these the animation is removed in further builds

from draw-bridge.

NielsPilgaard avatar NielsPilgaard commented on September 15, 2024

Alright, fair enough.

from draw-bridge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.