matt-oakes / php-last.fm-api Goto Github PK

Hi, after I call

$user_auth = new AuthApi('setsession', $auth_args);

How can I check that the user is successfully logged ?
Thanks for your work !

In the examples when I want to auth I am redirected to LastFM but after this I am not redirected back to the original page like on Twitter so I stay on LastFM.

Custom callback url is missing

I'm getting a constant error from using the libary at the moment. Could someone have a look at this? I can't find the error:

Notice: Undefined offset: 0 - lastfmapi/class/apibase.php (110);
Notice: Trying to get property of non-object - lastfmapi/class/apibase.php (111)

This is what I see :

// Pass the array to the auth class to eturn a valid auth
$auth = new lastfmApiAuth('setsession', $authVars);
// Call for the album package class with auth data
$apiClass = new lastfmApi();
$artistClass = $apiClass->getPackage($auth, 'artist', $config);

• lastfmApi needs a dependency which is an instance of lastfmApiAuth
• lastfmApi::getPackage always needs an instance of lastfmApiAuth

Dependency injection begins here so what I think :

1. Create a constructor for the lastfmApi which takes as first parameter an instance of himself (yes because all classes extends him..). Share the instance in lastfmApi::$auth
2. In lastfmApi::getPackage, remove the first parameters and at the end of this functions when packages are lazy loaded, pass $this->auth to the constructor of each package

Final result :

// Pass the array to the auth class to eturn a valid auth
$auth = new lastfmApiAuth('setsession', $authVars);
// Call for the album package class with auth data
$apiClass = new lastfmApi($auth);
$artistClass = $apiClass->getPackage('artist', $config);

Do you agree ? I tested and nothing is broken.

I tried to add a limit=999 to the call, it works using the URL http://ws.audioscrobbler.com/2.0/?method=user.getlovedtracks&api_key=f34bb72e2efe4eca9c784bdde6cf9343&user=morena84k&limit=999 but it failes to make the call through the socket. Do you know why?

The method is missing so I wrotten it :

/**
 * Get all images for an artist on Last.fm.
 * @param array $methodVars An array with the following values: <i>artist</i> or <i>mbid</i>
 * @return array
 */
public function getImages($methodVars) {
    $vars = array(
        'method'  => 'artist.getinfo',
        'api_key' => $this->auth->apiKey
    );
    $vars = array_merge($vars, $methodVars);

    if ( $call = $this->apiGetCall($vars) ) {
        $info['image']['small']      = (string) $call->artist->image[0];
        $info['image']['medium']     = (string) $call->artist->image[1];
        $info['image']['large']      = (string) $call->artist->image[2];
        $info['image']['extralarge'] = (string) $call->artist->image[3];
        $info['image']['mega']       = (string) $call->artist->image[4];

        return $info;
    }
    else {
        return FALSE;
    }
}

Guys, please take a look at http://stackoverflow.com/questions/19618068/using-getinfo-for-album-does-not-return-tracks/21731109#21731109 and my own answer to this issue. Please implement in the future release.

I assigned the variables I needed for my code, but I think there are more (http://www.last.fm/api/show/album.getInfo) :
$i = 0;
foreach ( $call->album->tracks->track as $track ) {
$info['tracks'][$i]['name'] = (string) $track->name;
$info['tracks'][$i]['rank'] =(string)$track['rank'][0];
$info['tracks'][$i]['duration'] = (string) $track->duration;
$i++;
}

Hi guys, and thanks for this nice library !!!

I just implemented it in my Wordpress plugin, WP Soundsystem.

Almost everything works except that I can't manage to make it scrobble.

I have the updateNowPlaying() calls working (called when track starts), it shows up on my Last.FM profile as Scrobbling now.
Then when the track has finished playing, I call scrobble().
But the track do not show up in my Last.FM library :/

Here's an example of what I set as arguments for the scrobble() function (it's a json from my debug log)

{"artist":"Ice Cube","track":"Man s Best Friend","timestamp":"1495026495897","album":null,"chosenByUser":0,"duration":"126"}

I also did try to unset chosenByUser but it does not change anything.

You can check the code here and see it in action there.

Thanks a lot !!!

http://www.matto1990.com/projects/phplastfmapi/ just leads to the front page :-)

It is a best practice in modern PHP to throw Exceptions of custom type. This way people know something's wrong in the code right away while developing/debugging code.

A big disadvantage of current implementation is that there should be such checks after every single object construction or method call:

    $auth = new AuthApi('setsession', ['apiKey' => $api_key, 'secret' => $api_secret]);

    if (empty($auth->error)) {
      $artist_api = new ArtistApi($auth);

      if (empty($artist_api->error)) {
        $artist_info = $artist_api->getInfo(['artist' => $artist]);

        if (empty($artist_api->error)) {
          return $artist_info;
        }
      }
    }

And it would be great to have it !
The love method could be duplicated except that the api method should be 'track.unlove'.

'method' => 'track.unlove',

Thanks !

When i try to execute one of the tests (any test) i receive an error:
Example:
http://localhost/PHP-Last.fm-API-master/tests/Api/AlbumTest.php

I receive error:
( ! ) Fatal error: Class 'Tests\Api\BaseNotAuthenticatedApiTest' not found in C:\www\PHP-Last.fm-API-master\tests\Api\AlbumTest.php on line 13Call Stack#TimeMemoryFunctionLocation10.0008407528{main}( )...\AlbumTest.php:0

I did install all composer and the project dependacies, added .env file,
I did try to implement my own test like in the readme file but it always return nothing (blank) (without the BaseNotAuthenticatedApiTest class)

Trying to authenticate a user on Last.fm with the following code:

    $auth = new AuthApi('gettoken', [
      'apiKey' => $api_key,
      'secret' => $api_secret,
    ]);

    $auth = new AuthApi('getsession', [
      'apiKey' => $api_key,
      'secret' => $api_secret,
      'token' => $auth->token,
    ]);

Getting:

Error: Call to undefined method LastFmApi\Api\AuthApi::apiSig() in LastFmApi\Api\AuthApi->getToken() (line 140 of vendor\matto1990\lastfm-api\src\lastfmapi\Api\AuthApi.php).

Seems that AuthApi class should extend the BaseApi, but it does not.

I want to get information from a playlist of a user using the playlist.php and the fetch function

Want I want to achieve is, that I can play the playlist in a javascript player like Soundmanager2 as playlist.

Hi Matt,
when I use deployer while using your repository "composer install" command fails with:
[LastFmApi\Exception\InvalidArgumentException]
Must send an apiKey, secret, usernamne, subcriber and sessionKey in the call for setsession

Temporary solution is setting LASTFM_API_KEY variable in .env file.
My guess is that it commes from one of tests. Do tests require any value set in .env file?

It doesn't seem to be a track.scrobble. Can you add it for me please? (forked, writing :)