Code Monkey home page Code Monkey logo

Comments (4)

devilcius avatar devilcius commented on August 16, 2024

@mikeshiyan, as noted in the README (v1.2) only read calls are working. As far as I know token authentication is broken since last.fm new redesign. Once it fixed, all signed calls must be rewritten.
I've just pushed a test to check it.

from php-last.fm-api.

mikeshiyan avatar mikeshiyan commented on August 16, 2024

Well, I've tested a little, and the authentication looks healthy. At least with my own account in both roles: as an application creator and as an authenticating user.

Anyway, thanks for fast reaction on my issue. But I also have some notices about the referenced commit:

  1. You moved apiSig() method from BaseApi class to AuthApi. But there are other classes left (like TrackApi, for example) which use this method from $this context: $this->apiSig(...). And now this is broken.
  2. You changed the field $secret to $apiSecret in the AuthApi class. But there are still references to the old $auth->secret notation. For example, in BaseApi constructor.

from php-last.fm-api.

devilcius avatar devilcius commented on August 16, 2024

@mikeshiyan I've managed to authenticate as a web application and finally could fix these errors in v1.5. There's a test with a signed call.

from php-last.fm-api.

mikeshiyan avatar mikeshiyan commented on August 16, 2024

Thanks. Great work!!! 👍

from php-last.fm-api.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.