Code Monkey home page Code Monkey logo

itemscroller's People

Contributors

asmprgmc3 avatar maruohon avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

itemscroller's Issues

[bug] DropAllMatching doesnt work in creative

To my testing, the dropp all matching doesnt work in creative [neither with the standart hotkeys or with the hotkey set to another key]. This affects version for 1.16.3 (maybe also others but i havent tested that].
In survival and adventuremode it works just fine though.

[Suggestion] Option to disregard enchantments/durability when dropping or moving all matching items.

When dealing with the output of a skeleton spawner grinder I tried to use drop all of the bows using drop all matching but it only dropped one. I went into a creative world and found that items are "different" if they have different durability/enchantments.

It would be nice to have a way to deal with situations like this. I don't know anything about java coding, but something to the effect of checking the namespaced id of an item and using that to define whether or not an item is the "same".

Please Test if a Slot is in the Slots Array before using it.

Mod hasn't compat with EasierVillagersTrading

When Itemscroller exists at the same time, EasierVillagersTrading by gbl don't take effect although his mod can be loaded. Trading is shown as vanilla.

First I went to gbl for help however the pity is that he can't do much about that. Can you solve the problem?Thanks.
gbl/EasierVillagerTrading#21

Game Verison: 1.16.5
a) When I load MaLiLib with any one of above, EasierVillagersTrading works normal.
b) When I load all mods except Item Scroller, EasierVillagersTrading works normal.
c) When I load MaLiLib and Item Scroller with any one of others, EasierVillagersTrading can't work but it is loaded (appear in the modmenu mod).

ItemScroller with Optifine 1.14.4_F4 & Optifabric crashes upon world loading.

Optifine F4_pre6 was the last version that worked with this combination of mods installed.

---- Minecraft Crash Report ----
// Don't do that.

Time: 11.11.19 10:01
Description: Unexpected error

java.lang.IncompatibleClassChangeError: Inconsistent constant pool data in classfile for class java/util/stream/Stream. Method 'java.util.stream.Stream of(java.lang.Object)' at index 490 is CONSTANT_MethodRef and should be CONSTANT_InterfaceMethodRef
at net.minecraft.class_156.method_17815(class_156.java:299)
at net.minecraft.class_1863.method_17718(class_1863.java:69)
at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:271)
at java.base/java.util.HashMap$ValueSpliterator.tryAdvance(HashMap.java:1698)
at java.base/java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:127)
at java.base/java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:502)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:488)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
at java.base/java.util.stream.FindOps$FindOp.evaluateSequential(FindOps.java:150)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.findFirst(ReferencePipeline.java:543)
at net.minecraft.class_1863.method_8132(class_1863.java:69)
at fi.dy.masa.itemscroller.util.InventoryUtils.onSlotChangedCraftingGrid(InventoryUtils.java:67)
at net.minecraft.class_1714.handler$onUpdateResult$zhb000(class_1714.java:534)
at net.minecraft.class_1714.method_17399(class_1714.java:61)
at net.minecraft.class_1723.method_7609(class_1723.java:131)
at net.minecraft.class_1715.method_5447(class_1715.java:70)
at net.minecraft.class_1735.method_7673(class_1735.java:80)
at net.minecraft.class_1703.method_7610(class_1703.java:465)
at net.minecraft.class_634.method_11153(class_634.java:1122)
at net.minecraft.class_2649.method_11439(class_2649.java:49)
at net.minecraft.class_2649.method_11054(class_2649.java:12)
at net.minecraft.class_2600.lambda$checkThreadAndEnqueue$0(class_2600.java:33)
at net.minecraft.class_1255.method_18859(class_1255.java:170)
at net.minecraft.class_4093.method_18859(class_4093.java:23)
at net.minecraft.class_1255.method_16075(class_1255.java:135)
at net.minecraft.class_1255.method_5383(class_1255.java:115)
at net.minecraft.class_310.method_1523(class_310.java:915)
at net.minecraft.class_310.method_1514(class_310.java:410)
at net.minecraft.client.main.Main.main(Main.java:155)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:567)
at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:188)
at net.fabricmc.loader.launch.knot.Knot.init(Knot.java:131)
at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:26)
A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head --
Thread: Client thread
Stacktrace:
at net.minecraft.class_156.method_17815(class_156.java:299)
at net.minecraft.class_1863.method_17718(class_1863.java:69)
at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:271)
at java.base/java.util.HashMap$ValueSpliterator.tryAdvance(HashMap.java:1698)
at java.base/java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:127)
at java.base/java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:502)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:488)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
at java.base/java.util.stream.FindOps$FindOp.evaluateSequential(FindOps.java:150)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.findFirst(ReferencePipeline.java:543)
at net.minecraft.class_1863.method_8132(class_1863.java:69)
at fi.dy.masa.itemscroller.util.InventoryUtils.onSlotChangedCraftingGrid(InventoryUtils.java:67)
at net.minecraft.class_1714.handler$onUpdateResult$zhb000(class_1714.java:534)
at net.minecraft.class_1714.method_17399(class_1714.java:61)
at net.minecraft.class_1723.method_7609(class_1723.java:131)
at net.minecraft.class_1715.method_5447(class_1715.java:70)
at net.minecraft.class_1735.method_7673(class_1735.java:80)
at net.minecraft.class_1703.method_7610(class_1703.java:465)
at net.minecraft.class_634.method_11153(class_634.java:1122)
at net.minecraft.class_2649.method_11439(class_2649.java:49)
at net.minecraft.class_2649.method_11054(class_2649.java:12)
at net.minecraft.class_2600.lambda$checkThreadAndEnqueue$0(class_2600.java:33)
at net.minecraft.class_1255.method_18859(class_1255.java:170)
at net.minecraft.class_4093.method_18859(class_4093.java:23)
at net.minecraft.class_1255.method_16075(class_1255.java:135)

-- Affected level --
Details:
All players: 1 total; [class_746['Heitzenberg'/121, l='MpServer', x=332.57, y=56.00, z=589.51]]
Chunk stats: Client Chunk Cache: 729, 140
Level dimension: minecraft:overworld
Level name: MpServer
Level seed: 0
Level generator: ID 01 - flat, ver 0. Features enabled: false
Level generator options: {}
Level spawn location: World: (515,97,460), Chunk: (at 3,6,12 in 32,28; contains blocks 512,0,448 to 527,255,463), Region: (1,0; contains chunks 32,0 to 63,31, blocks 512,0,0 to 1023,255,511)
Level time: 20416608 game time, 1000 day time
Level storage version: 0x00000 - Unknown?
Level weather: Rain time: 0 (now: false), thunder time: 0 (now: false)
Level game mode: Game mode: creative (ID 1). Hardcore: false. Cheats: false
Server brand: fabric
Server type: Integrated singleplayer server
Stacktrace:
at net.minecraft.class_638.method_8538(class_638.java:574)
at net.minecraft.class_310.method_1587(class_310.java:1923)
at net.minecraft.class_310.method_1514(class_310.java:430)
at net.minecraft.client.main.Main.main(Main.java:155)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:567)
at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:188)
at net.fabricmc.loader.launch.knot.Knot.init(Knot.java:131)
at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:26)

-- System Details --
Details:
Minecraft Version: 1.14.4
Minecraft Version ID: 1.14.4
Operating System: Windows 10 (amd64) version 10.0
Java Version: 13.0.1, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode, sharing), Oracle Corporation
Memory: 420165080 bytes (400 MB) / 1291845632 bytes (1232 MB) up to 3221225472 bytes (3072 MB)
CPUs: 12
JVM Flags: 10 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx3G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:ParallelGCThreads=6 -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=16M
Launched Version: fabric-loader-0.6.4+build.169-1.14.4
LWJGL: 3.2.2 build 10
OpenGL: GeForce GTX 1060 6GB/PCIe/SSE2 GL version 4.6.0 NVIDIA 440.97, NVIDIA Corporation
GL Caps: Using GL 1.3 multitexturing.
Using GL 1.3 texture combiners.
Using framebuffer objects because OpenGL 3.0 is supported and separate blending is supported.
Shaders are available because OpenGL 2.1 is supported.
VBOs are available because OpenGL 1.5 is supported.

[Suggestion] Alt + Middle Click fills inventory

Holding Alt whole middle clicking and dragging an item too an Inventory fills all available slots of that inventory with that item. Would make filling up a chest super easy since middle click dragging is annoying.

[Suggestion] Masscrafting for grindstones

This feature should work just like with crafting; select item of choice, e.g., an enchanted book to the grindstone, and it takes all enchanted books, the inventory, and grindstones the items, which would make this otherwise tedious task much faster

Refined storage compatibility

There is no way to take items from the Grid by CTRL/SHIFT.
When holding CTRL/SHIFT and using the Grid's crafting window, it works but also scrolls items in the grid which is pretty annoying.

Item Scroller doesn't load

Sometimes Item Scroller doesn't load at all.
I have to restart Minecraft and even then it doesn't load (sometimes).

version: v0.15.0-dev.20200624214738

Crashing from using mouse scroll wheel in an Applied Energistics crafting terminal.

I am having an issue with trying to use the mouse scroll wheel in an Applied Energistics crafting terminal. Everytime I try to scroll while the mouse is in the middle of the screen the game crashes. Happens on server and single player. Happens on multiple computers.

This is from a player who plays my modpack after looking at the crash report i think its a compatibility issues with this mod and AE2

Minecraft 1.15.2
Forge 31.2.36
appliedenergistics2-7.0.1
itemscroller-forge-1.15.2-0.15.0-dev.20200412.215325
https://pastebin.com/KQT20GqL

How to favorite a villager's trades?

There is the villagerTradeFavorites hotkey, which trades "everything possible with all the favorited trades of the current villager". However, the favorited trades list appears to start off empty, and I don't know how I can add trades to my favorited trades list so that they get executed when pressing the villagerTradeFavorites hotkey.

What hotkeys do I need to press and what do I need to do in order to favorite a villager's trades?

Minecraft: 1.16.4
Fabric Loader: 0.10.8
Item Scroller: 0.15.0-dev.20201103.183933
MaLiLib: 0.10.0-dev.21+arne.2

Not working for 1.13.2

When launching, warning message comes up saying: "File itemscroller-rift-1.13.2-0.1.4.2.jar is not a valid mod file.

Does Item Scroller work in 1.16.5?

The latest file itemscroller-fabric-1.16.4-0.15.0-dev.20210111.205029.jar only says that it works in Minecraft 1.16.4 according to the file name. Does this work in 1.16.5, or will that support be in the next version?

1.13.2-0.14.2 crashes on startup using 1.13.2-rift-1.0.4-SNAPSHOT

[23:41:23] [main/INFO]: Loading tweak class name org.dimdev.riftloader.launch.RiftLoaderClientTweaker
[23:41:23] [main/INFO]: Using primary tweak class name org.dimdev.riftloader.launch.RiftLoaderClientTweaker
[23:41:23] [main/INFO]: Calling tweak class org.dimdev.riftloader.launch.RiftLoaderClientTweaker
[23:41:23] [main/INFO]: Searching mods on classpath
[23:41:23] [main/INFO]: Loaded mod 'rift'
[23:41:23] [main/INFO]: Searching for mods in C:\mods
[23:41:23] [main/INFO]: Loaded mod 'itemscroller'
[23:41:23] [main/INFO]: Loaded mod 'voxelmap'
[23:41:23] [main/INFO]: Loaded 4 mods
[23:41:23] [main/INFO]: Initializing mods
[23:41:23] [main/ERROR]: Unable to launch
java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
at org.dimdev.riftloader.launch.RiftLoaderTweaker.injectIntoClassLoader(RiftLoaderTweaker.java:28) ~[rift-1.0.4-SNAPSHOT.jar:?]
at net.minecraft.launchwrapper.Launch.launch(Launch.java:115) [launchwrapper-1.12.jar:?]
at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
Caused by: java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_51]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_51]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51]
at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51]
at org.dimdev.riftloader.launch.RiftLoaderTweaker.injectIntoClassLoader(RiftLoaderTweaker.java:26) ~[rift-1.0.4-SNAPSHOT.jar:?]
... 2 more
Caused by: java.lang.NoClassDefFoundError: fi/dy/masa/malilib/interfaces/IInitializationHandler
at java.lang.Class.forName0(Native Method) ~[?:1.8.0_51]
at java.lang.Class.forName(Class.java:348) ~[?:1.8.0_51]
at org.dimdev.riftloader.RiftLoader.loadListeners(RiftLoader.java:248) ~[rift-1.0.4-SNAPSHOT.jar:?]
at org.dimdev.riftloader.RiftLoader.getListeners(RiftLoader.java:233) ~[rift-1.0.4-SNAPSHOT.jar:?]
at org.dimdev.riftloader.RiftLoader.initMods(RiftLoader.java:188) ~[rift-1.0.4-SNAPSHOT.jar:?]
at org.dimdev.riftloader.RiftLoader.load(RiftLoader.java:54) ~[rift-1.0.4-SNAPSHOT.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_51]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_51]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51]
at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51]
at org.dimdev.riftloader.launch.RiftLoaderTweaker.injectIntoClassLoader(RiftLoaderTweaker.java:26) ~[rift-1.0.4-SNAPSHOT.jar:?]
... 2 more
Caused by: java.lang.ClassNotFoundException: fi.dy.masa.malilib.interfaces.IInitializationHandler
at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:191) ~[launchwrapper-1.12.jar:?]
at java.lang.ClassLoader.loadClass(ClassLoader.java:424) ~[?:1.8.0_51]
at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_51]
at java.lang.Class.forName0(Native Method) ~[?:1.8.0_51]
at java.lang.Class.forName(Class.java:348) ~[?:1.8.0_51]
at org.dimdev.riftloader.RiftLoader.loadListeners(RiftLoader.java:248) ~[rift-1.0.4-SNAPSHOT.jar:?]
at org.dimdev.riftloader.RiftLoader.getListeners(RiftLoader.java:233) ~[rift-1.0.4-SNAPSHOT.jar:?]
at org.dimdev.riftloader.RiftLoader.initMods(RiftLoader.java:188) ~[rift-1.0.4-SNAPSHOT.jar:?]
at org.dimdev.riftloader.RiftLoader.load(RiftLoader.java:54) ~[rift-1.0.4-SNAPSHOT.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_51]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_51]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51]
at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51]
at org.dimdev.riftloader.launch.RiftLoaderTweaker.injectIntoClassLoader(RiftLoaderTweaker.java:26) ~[rift-1.0.4-SNAPSHOT.jar:?]
... 2 more
Caused by: java.lang.NullPointerException
at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:182) ~[launchwrapper-1.12.jar:?]
at java.lang.ClassLoader.loadClass(ClassLoader.java:424) ~[?:1.8.0_51]
at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_51]
at java.lang.Class.forName0(Native Method) ~[?:1.8.0_51]
at java.lang.Class.forName(Class.java:348) ~[?:1.8.0_51]
at org.dimdev.riftloader.RiftLoader.loadListeners(RiftLoader.java:248) ~[rift-1.0.4-SNAPSHOT.jar:?]
at org.dimdev.riftloader.RiftLoader.getListeners(RiftLoader.java:233) ~[rift-1.0.4-SNAPSHOT.jar:?]
at org.dimdev.riftloader.RiftLoader.initMods(RiftLoader.java:188) ~[rift-1.0.4-SNAPSHOT.jar:?]
at org.dimdev.riftloader.RiftLoader.load(RiftLoader.java:54) ~[rift-1.0.4-SNAPSHOT.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_51]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_51]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51]
at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51]
at org.dimdev.riftloader.launch.RiftLoaderTweaker.injectIntoClassLoader(RiftLoaderTweaker.java:26) ~[rift-1.0.4-SNAPSHOT.jar:?]
... 2 more

What is the best way to continously mass craft honey blocks

Hi,

first of all, thanks for the awesome mod!

I recently upgraded to 1.15.2 and just build a massive honey farm. Now I used the mass craft feature to quickly craft my inventory into honey blocks. Unfortunately, I cannot do this continously (e.g. while being fed by droppers with new honey bottles) because the empty glass bottles stay in my inventory.

What is the best way to also drop out the empty glass bottles while crafting honey?

Many thanks and best regards!

[Feature] New type of move "matching"

This type of "move matching" shall move all items from one inventory to the other that has the same item already present in the other chest. That is, if I have a chest with different mob drops items (&free slots) I just hit that key combo and any of those mob drop also present in my inventory will be moved from my inventory to the chest.

[Suggestion] Trade Favorites Max Price

A generic setting makes the user not trade for the favorited items if the price is more than x emeralds.

In my case, I trade for diamond armor from armorers and have all diamond armor trades favorited, and I would only want to trade if the price is 1 emerald. Sometimes after trading a lot, the price increase on 1 or 2 items. With this feature, you could still trade favorites, but it skips the trades which are set to cost more than the setting.

Method overwrite conflict for getSlotIndex

itemscroller-fabric-1.14.4-0.15.0-dev.20190720.190250.jar
tweakeroo-fabric-1.14.4-0.9.10.jar

[main/WARN]: Method overwrite conflict for getSlotIndex in mixins.tweakeroo.json:IMixinSlot, previously written by fi.dy.masa.itemscroller.mixin.IMixinSlot. Skipping method.

maruohon/tweakeroo#11

MC 1.11.2 scroll up issue

When you scroll the mouse wheel up (by default), it puts one item at a time. But there is a desync or something on servers. After putting an item it picks up the stack, but not really. If you close the inventory nothing will drop. So you have to click twice, the first time will actually pick up the stack and the second will put it back down. There are no problems with scroll down (pull items), just the put. There are no other mods that add item scrolling on client or server. And I don't really have problems on single player. I've tried the server with this mod and also without it. Problem still persists.

All features randomly stop working, requiring restart

I haven't figured out how to reproduce this. But sometimes (randomly), all features of the mod will stop working, reverting to vanilla behaviour as if the mod weren't there (except for the configuration menu -- that still opens correctly).

Sometimes, the mod stops working right when the game starts up. Sometimes, it stops working a few minutes into playing the game. Most of the time, the bug never happens at all.

The only way to fix this, that I've found, is to restart the game when the issue occurs to restore the mod's functionality.

My OS is Pop!_OS 20.10. I know that Linux has some input issues (like MC-122477), could that be related?

  • Minecraft 1.16.4
  • Fabric Loader 0.10.8
  • Fabric API 0.26.0
  • malilib 0.10.0
  • itemscroller 0.15.0

1.17 snapshot masscraft duplication with a stackable and an unstackable item

expected behavior: the items are crafted together and there are none created

actual behavior: the stackable item in the crafting grid duplicated a very large amount of items

mods used:

  • itemscroller-fabric-1.17-snap-20w51a-0.15.0-dev.20201218.025932.jar

  • malilib-fabric-1.17-snap-20w51a-0.10.0-dev.21+beta.1.jar

steps to reproduce:

  1. fill 35 inventory slots with a random item

  2. put a stack or so of dye furnaces, tnt, hoppers, or tnt in the 36th slot

  3. drop around 64 minecarts or beds (for dye) on the ground

  4. arrange the items in a crafting table so that the stackable is on top of the unstackable

  5. masscraft
    the stackable item generates an insane amount of items
    2021-01-19_23 25 07

Shift + Left Click (Hold) and Hovering through Tinker's Inventories

First discovered in FTB Unstable pack on on these versions:

  • itemscroller-1.10.2-0.5.2
  • itemscroller-1.10.2-0.6.0 (Saw this update, issue found on this as well)

Along with this Tinker's version:

  • TConstruct-1.10-2.3.3a

When using the "Shift + Left Click" functionality from itemscroller, when holding left click and moving the cursor through a Tinker's inventory (crafting table as well as smeltry), items may or may not be moved into the player's inventory, but more importantly, items from the player's inventory may also be moved back into the Tinker's inventory.

Example: Using this functionality to empty a Tinker's crafting table of ingredients, I've had my tools be pulled into the crafting grid when I was just removing stone from the crafting table.

I would guess that Tinker's is doing something unique with its inventory (custom or utilizing Forge). This behavior does not happen with vanilla crafting tables. I have also removed any other inventory sorting or enhancement mods (such as inventory tweaks) to make sure it wasn't some kind of conflict - I'm fairly certain my testing has isolated it down to your mod interacting with Tinker's Construct.

If you need anything else just let me know.

Help fixing Mod Compat

I'm trying to make my Inventory Control Tweaks (repo) mod work alongside itemscroller.

itemscroller causes malilib's MixinMouse#hookOnMouseClick(...) to cancel mouse clicks, so my mixin that makes it so certain items shift-click to the player's offhand isn't reached.

I've created an itemscroller-compat branch where I tried registering a click handler using

InputEventHandler.getInputManager().registerMouseInputHandler(new ClickHandler());

however my handler is reached after the stack has already moved (the same way it does in vanilla), so clickedStack is always empty when I reach this line.

I'd appreciate help fixing compatibility between the two mods.

Disables JEI hide item functionality

MC Version: 1.10.2
Forge Version: 2007 & 2008
Mod Version: 1.10.2-0.5.1

Adding this mod to my pack makes JEI's hide item functionality, unusable.

Steps to Reproduce: Install this mod, attempt to hide item in JEI in proper mode, nothing happens.
Uninstalling returns functionality.

Crash if key_key.drop is bind to non qwerty key

Hello,

Minecraft client crash on item stack movement action if ctrl or shift key is pressed and key_key.drop is bind to a key absent from QWERTY keyboard (ex : < key on AZERTY).

Required mods to get theses crashes:

  • forge | 14.23.5.2836 | forge-1.12.2-14.23.5.2836-universal.jar
  • itemscroller | 0.12.0 | itemscroller-1.12.2-0.12.0.jar

Crash reports:

Configuration:
Keyboard layout : AZERTY
Drop key : <

These crash seems to be related to following bugs reports:
#10 (This should be fixed in 0.12.0.)
#16 (This should be fixed in 0.12.0)

Interesting links for understanding the problem:
Direwolf20-MC/BuildingGadgets#103
https://bugs.mojang.com/browse/MC-102867

Source code links
Item scroller call to lwjgl :

boolean dropKeyDown = dropKey > 0 ? Keyboard.isKeyDown(dropKey) : dropKey + 100 < Mouse.getButtonCount() && Mouse.isButtonDown(dropKey + 100);

lwjgl 2.9.4 Keyboard class: https://github.com/LWJGL/lwjgl/blob/129d0711c5d53e45d7c2e7aa1bf7dabdae77551d/src/java/org/lwjgl/input/Keyboard.java

I hope that all the elements allowing to find the bug are present.

Disconnect from server

Hi!
I've used Item Scroller for a few months now and I love it. After installing it (and some other mods) I started getting disconnected from the server randomly. The message I'm getting in my client is Internal Exception: java.io.IOEexception: An existing connection was forcibly closed by the remote host
I'm an admin of the server so I've checked the server console and there it just says that player disconnected.

After a few months of this I decided to try and find the issue. I tried a clean client, and no disconnects after 1 hour.
Then I tried a clean instance and reinstalled all the mods that I had on the old one. Disconnected within 5 minutes.
Then I started trying each mod loaded on its own and that's when I was able to conclude that Item Scroller was the issue.
I also tried loading the game with only MaLib enabled and that worked fine.

The disconnect happens more, but not exclusively, when I'm moving quickly(IE flying elytra) or using a nether portal.

My version of minecraft: 1.15.2
Fabric version: 0.8.9+build.203
Fabric API: fabric-api-0.14.0+build.317-1.15
MaLib: malilib-fabric-1.15.2-0.10.0-dev.21+arne.3
Item Scroller: itemscroller-fabric-1.15.2-0.15.0-dev.20200616.032713

Running all this through MultiMC if that makes a difference
No one else on the server claims to have these issues.

Copy-paste doesn't work in the anvil GUI

I recently noticed that I can't copy-paste text into an anvil anymore. Without itemscroller, it's working fine. Is this a config issue or something else?

(itemscroller-fabric-1.16.4-0.15.0-dev.20210111.205029)

Item Scrolling doesn't keep it's function

While scrolling the mouse wheel up, the item goes from my inventory to target inventory fine,
Scrolling down it picks the item inventory.
Fine until that point, when I put the mouse inside the target inventory, it inverts the outcome, scrolling the mouse wheel up it goes from the target inventory to my inventory, instead of keeping the default behavior, and the inversion configs does not fix that behavior, it just inverts everything.

Expected:

  • - Scroll up in your inventory, item goes from your inventory to target inventory
  • - Scroll down in your inventory, item goes from your inventory to target inventory
  • - Scroll up in target inventory, item goes from your inventory to target inventory
  • - Scroll down in target inventory, item goes from target inventory to your inventory

[Bug] Mass craftEverything not using precise amounts of resources for rockets

MC version: 1.16.5
Item scroller: v1.15.0-dev.20210111.205029

When using the craftEverything feature to make rockets, You will sometimes get different types of rockets. Specifically, it may craft 1, 2, or 3 second rockets despite only executing the recipe for 3-second rockets. This does not seem to happen every time, but In trying to make around a chest of rockets (27 stacks), there resulted also 3 rockets that only have a 2 second duration. This implies that one of the slots of gunpowder had a smaller stack than the others, and ran out mid-crafting.

Testing more deliberately, I found that if you had gunpowder in your inventory at an imperfect ratio versus paper, you can get incorrect rocket types. I tested this by having 6 paper and 16 gunpowder in inventory (6 and 18 would be a perfect ratio of 1:3). When executing craftEverything, it seems that the function split the 6 gunpowder into uneven stacks (5, 5, 6), resulting in 15 3-second rockets, and 3 1-second rockets. Each paper used rocket crafting yields 3 rockets, so that mean that there were 5 cycles of 3 gunpowder + 1 paper, and one cycle of 1 GP + 1 paper. This issue even occurs with full, but incorrect ratio, stacks, as 64/3 = 2 stacks of 21, and 1 stack of 22. So if you had a single stack of gunpowder in your inventory and enough paper, you would get 63 longer rockets and a single 1-second rocket.

If it does not exist already, can you please implement a recipe completeness check that checks for partial stacks before firing the crafting action? Or maybe only load precise stacks into the crafting interface instead of doing a split of whatever is in inventory and putting all of it into the crafting interface? This might only need to be done for rockets (might be simpler to code), but I can foresee it being useful for custom datapack recipes, so making it universal may be more elegant.

Thanks so much for your hard work!

Quark compatibility

Quark has a feature called "Better Crafting Shift-Clicking" where if you shift-click an item from your inventory while using a crafting table, it moves the item to the crafting table rather than your hotbar (and villagers as well, despite it not being mentioned on Quark's website).

Item Scroller prevents this functionality from working for crafting tables, but not for villagers. This issue occurs regardless of the value of "enableScrollingStacksFallback".

Crash on launch with Forge version 28.1.61

The game crashed whilst initializing game
Error: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException


this is with no other mods in the mods folder using file version:
itemscroller-forge-1.14.4-0.15.0-dev.20191023.012451

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.