Code Monkey home page Code Monkey logo

Comments (9)

maruohon avatar maruohon commented on August 17, 2024 1

Personally I would prefer feature requests and any support requests to happen on Discord, and only actual bugs/issues to be posted on Github for the most part. But this isn't currently indicated anywhere and also the Discord invite links aren't really clearly added to all the projects, or the issue templates set up to indicate this, so basically currently I can't expect people who aren't already on the Discord server to know this.

Basically the main issue about "conversation-like" issues is that I have a Discord bot on two different servers, so the channels get quite spammy if there are lots of short messages sent.

As to the actual issue in hand here... Basically everything currently happens in the massive InventoryUtils class. I kind of want to try to rewrite things a little bit to be a bit cleaner and better maintainable. The actual fix for this is quite simple, the crafting grid just needs to be cleared after each craft, which already is done, but also in a case where the grid gets new non-recipe items after a craft, those items should be dropped, but only when the crafting is done in the massCraft mode.

from itemscroller.

maruohon avatar maruohon commented on August 17, 2024

I hadn't thought about that. I need to make it also drop all the returned items (left on the grid) from a craft, unless they are used in the recipe again (which I think doesn't happen in vanilla?).

from itemscroller.

andreas-eberle avatar andreas-eberle commented on August 17, 2024

I don't know of any receipt that would need the left grid results. Would be really awesome to have this feature! Let me know when there is a test version :)

from itemscroller.

maruohon avatar maruohon commented on August 17, 2024

There seems to be an extra problem with this... If your inventory is full, then vanilla seems to simply delete the returned items when you craft from input stacks larger than one.

So in other words when you for example craft Honey Blocks and have for example 4 honey bottles in the 4 crafting grid slots, if your inventory is full of honey bottles or honey blocks or whatever so that there is no place for the empty bottles, they will just get destroyed on all except the last craft where the grid becomes empty and the bottles can be returned to the grid.

from itemscroller.

andreas-eberle avatar andreas-eberle commented on August 17, 2024

OK, so it is important to not overflow your inventory. However, if itemscroller drops all empty glass bottles and honey blocks you can only have an issue if you instantly add more honey bottles then your inventory can handle, right?

from itemscroller.

Boobies avatar Boobies commented on August 17, 2024

Why are people abusing the bug tracker? This is meant for bug reports and anything else is disruptive to the development process because it obscures actual bugs. Join Discord for support.

from itemscroller.

andreas-eberle avatar andreas-eberle commented on August 17, 2024

@Boobies: This actually is a feature request. So I think its at the right place. Also, as long as the maintainer has no issue with this, I think it's fine. Adding such non-helpful comments seems like spam to me.

from itemscroller.

andreas-eberle avatar andreas-eberle commented on August 17, 2024

@maruohon: Can you give me a hint were I would have to start looking to implement this feature? Maybe I can send you a PR.

from itemscroller.

Andrews54757 avatar Andrews54757 commented on August 17, 2024

@andreas-eberle If your still looking for a solution, take a look at this recent commit I made in my fork. The code can probably be improved, I just made this quickly since a member of my tech server needed it for his new honey farm.

Andrews54757@d12091d

from itemscroller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.