lukasmut / vice Goto Github PK

Unittests in main need to be updated. Currently, they are implemented using an old version of the code, where an object-oriented-programming paradigm was not yet applied.

Hi, I was running the provided evaluation code and ran into the following error.

Traceback (most recent call last):
  File "VICE/main_robustness_eval.py", line 312, in <module>
    evaluate_models(
  File "VICE/main_robustness_eval.py", line 237, in evaluate_models
    val_batches = utils.get_batches(
                  ^^^^^^^^^^^^^^^^^
AttributeError: module 'utils' has no attribute 'get_batches'

Could you point me to this function? Thanks!

should this not be eps = -(self.mu.mu.weight.data.std().log() ** -1.0).exp() instead?

The branch multiprocessing, where we exploit embarrassingly parallel computations to run models with different hyperparameter values in parallel, has to be updated according to the new object-oriented programming paradigm (e.g., class inheritance) used in the main branch.

Currently, tripletize.py uses functions to tripletize the data. However, it'd be cleaner and more in line with the other files to be re-written in an object-oriented way (e.g., Tripletizer(**kwargs)).