Code Monkey home page Code Monkey logo

Comments (8)

SeerLite avatar SeerLite commented on May 25, 2024 1
  • not using -f in bspwm hide cmd. (This doesn't focus parent but no jumping around).

Actually that's exactly what I did in a451448 haha

from pidswallow.

Liupold avatar Liupold commented on May 25, 2024

bspwm specific instruction is not working, i think it's a lot of work to maintain that, IMO we should drop that, using windowmap the window get dynamically placed (better) user can specify the placement of the window using.

bspc node -p {west,south,north,east}

from pidswallow.

Liupold avatar Liupold commented on May 25, 2024

This is sort of fixed but the window is getting resized improperly after vomit, And the toggle window is not resizing to account for others. (Using BSPWM specific recommendations).

from pidswallow.

Liupold avatar Liupold commented on May 25, 2024

The only thing that is sub optimal is preglue_hook. I can live without that, Everything else is working much better without BSPWM recommendation.

from pidswallow.

SeerLite avatar SeerLite commented on May 25, 2024

This is sort of fixed but the window is getting resized improperly after vomit, And the toggle window is not resizing to account for others. (Using BSPWM specific recommendations).

What about checking for the current desktop before moving?

diff --git a/pidswallow b/pidswallow
index a990855..b377a17 100755
--- a/pidswallow
+++ b/pidswallow
@@ -43,6 +43,7 @@ vomit() {
 
         [ -f "/tmp/swallowed-by-$cwid-desk" ] \
                 && desk=$(cat /tmp/swallowed-by-"$cwid"-desk) && \
+                [ "$(xdotool get_desktop_for_window "$pwid")" -ne "$desk" ] && \
                 xdotool set_desktop_for_window "$pwid" "$desk"
         [ -f "/tmp/swallowed-by-$cwid-pos" ] \
                 && cpos=$(cat /tmp/swallowed-by-"$cwid"-pos) && \

Edit: a451448

from pidswallow.

SeerLite avatar SeerLite commented on May 25, 2024

The only thing that is sub optimal is preglue_hook. I can live without that, Everything else is working much better without BSPWM recommendation.

I'm not sure I understand heh

from pidswallow.

SeerLite avatar SeerLite commented on May 25, 2024

bspwm specific instruction is not working, i think it's a lot of work to maintain that, IMO we should drop that, using windowmap the window get dynamically placed (better) user can specify the placement of the window using.

bspc node -p {west,south,north,east}

Personally I don't like this approach. My idea of swallowing is that windows should occupy the exact same place as the child that swallowed them.
A plus would be that the parent (swallowed) window regains focus (only) if the child was focused when it was closed. Not sure how to implement this though

from pidswallow.

Liupold avatar Liupold commented on May 25, 2024

It is doing that except for the window state, and for doing just this a loooot of thing had to be coincided. (With bspwn specific recommendation). Call me crazy but I think it will be really hard to maintain,

What I suggest:
* Drop SWALLOW_CMD , VOMIT_CMD , PREGLUE_HOOK

  • not using -f in bspwm hide cmd. (This doesn't focus parent but no jumping around).

from pidswallow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.